Re: [Powertop] [PATCH 1/2] devlist: Remove an unnecessary sprintf
On (09/19/12 00:13), Namhyung Kim wrote:
Date: Wed, 19 Sep 2012 00:13:17 +0900
From: Namhyung Kim <namhyung(a)gmail.com>
To: powertop(a)lists.01.org
Subject: [Powertop] [PATCH 1/2] devlist: Remove an unnecessary sprintf
X-Mailer: git-send-email 1.7.9.2
The 'filename' is not used in the loop anymore.
Signed-off-by: Namhyung Kim <namhyung(a)gmail.com>
---
src/devlist.cpp | 1 -
1 file changed, 1 deletion(-)
looks good.
-ss
diff --git a/src/devlist.cpp b/src/devlist.cpp
index 5ec0a8b..828f47f 100644
--- a/src/devlist.cpp
+++ b/src/devlist.cpp
@@ -147,7 +147,6 @@ void collect_open_devices(void)
continue;
dev->pid = strtoull(entry->d_name, NULL, 10);
strncpy(dev->device, link, 251);
- sprintf(filename, "/proc/%s/comm", entry->d_name);
strncpy(dev->comm, read_sysfs_string("/proc/%s/comm",
entry->d_name).c_str(), 31);
target->push_back(dev);
--
1.7.9.2
_______________________________________________
PowerTop mailing list
PowerTop(a)lists.01.org
https://lists.01.org/mailman/listinfo/powertop