Re: [Powertop] [PATCH] Optionally check for ncurses pkgconfig file.

On (05/08/14 10:06), Joe Konno wrote: > On Tue, May 06, 2014 at 05:38:24PM -0700, Kok, Auke-jan H wrote: > > On Tue, May 6, 2014 at 12:53 AM, Sergey Senozhatsky > > <sergey.senozhatsky(a)gmail.com&gt; wrote: > > > On (05/05/14 23:42), Auke Kok wrote: > > >> --- > > >> configure.ac | 3 ++- > > >> 1 file changed, 2 insertions(+), 1 deletion(-) > > >> > > >> diff --git a/configure.ac b/configure.ac > > >> index baa5faa..5a90fe3 100644 > > >> --- a/configure.ac > > >> +++ b/configure.ac > > >> @@ -46,7 +46,8 @@ AC_FUNC_REALLOC > > >> AC_FUNC_STRTOD > > >> AC_CHECK_FUNCS([fdatasync getpagesize gettimeofday memmove memset mkdir munmap pow realpath regcomp select setlocale socket sqrt strcasecmp strchr strdup strerror strncasecmp strstr strtoul strtoull]) > > >> > > >> -AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], AC_MSG_ERROR([ncurses is required but was not found]), []) > > >> +PKG_CHECK_MODULES([NCURSES], [ncurses], [LIBS="$LIBS $ncurses_LIBS"], > > > ^^^^^^^^^ > > > [ncursesw ncurses]? > > On my gentoo system (x86_64) with ncurses 5.9, after applying this patch, > -lncurses is linked, but not -lncursesw. > > > > > Good question, I actually do not know, and I don't have an ncurses > > pkgconfig around to see if that works. > > > > Alexandra, can you see if this works with: > > > > +PKG_CHECK_MODULES([NCURSES], [ncursesw ncurses], [LIBS="$LIBS $ncurses_LIBS"], > > After hacking in this change, both -lncursesw and -lncurses are linked. > > If I checkout the v2.5 tag, only -lncursesw is linked. > > So, three different linking scenarios. Which one is "correct" for powertop? > ncursesw is preferred.