Re: [Powertop] [PATCH] cpufreq: only try to open files under cpuX
On 12/12/2012 10:05 AM, Jaroslav Skarvada wrote:
-
> Hello,
> thanks for your patch. however, I'm afraid it does not fix all the
> cases. looking at src/tuning/cpufreq.cpp we
> have several more places with exactly the same cpuX detection --
> ::toggle*().
>
NP, I will try to fix them all, I will post new version of the patch soon.
> could you also please remove 'strlen(dirent->d_name) < 4', looks loke
> a small overhead there.
>
Right :)
it makes sense to clean this up indeed
now, I'm still wanting to rewrite the whole frequency side... it's not great code
right now,
and makes assumptions that aren't going to be true going forward.
but until that's done.. by all means lets do improvements like this to the existing
code.