Re: [Powertop] [PATCH] do not implement get_user_input() in DISABLE_NCURSES builds

On 8/20/2012 8:31 AM, Chris Ferron wrote: > On 08/20/2012 08:21 AM, Arjan van de Ven wrote: >> On 8/20/2012 8:18 AM, Chris Ferron wrote: >> >>>> -ss >>> The only reason we allowed DISABLE_NCURSES in the first place, was to support android. If we don't want to support android out of the box, we can start removing the crude >>> and android can patch PowerTOP within their distro if they wanted. >> ..or for an android build one adds ncurses to the local android.. like libpci and libnl are anyway >> > Yep, another perfectly reasonable option. So lets make ncurses a hard requirement and remove the ifdef's. it's already a runtime option anyway (with --html and co) worst case, if someone really cannot stand this, they can contribute a mini "stub" ncurses that we then compile in for those people who can't cope. But that really should be a separate stub (similar to how we do the pevent lib), not a ton of ifdefs in code.