Re: [Powertop] [PATCH 01/12] configure: use vertical lists and AS_IF macro
On Sat, Aug 02, 2014 at 12:54:06PM +0100, Sami Kerola wrote:
Horizontal lists has downside of being managed as a single entry in
version control, which makes commits that add and remove items difficult
to follow. With vertical lists each entry is managed separately, which
is much nicer.
I agree with this but there is a small issue - in autoconf you don't need to
have \'s at the end of the lines.
Additionally make the 'if' statements to use AS_IF() macro,
add project
URL to autoconfig init
It is always better to separate patches :-)
and pretty print macro expressions to have
indentation, and bracing that follows more or less in K&R style.
This is pretty much a style issue and I ain't certain about which style I
prefer. I am also unsure about the messages - have you adde newlines to any
message?
/MF