Signed-off-by: Sami Kerola <kerolasa(a)iki.fi&gt; --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 35d41c2..d00973f 100644 --- a/.gitignore +++ b/.gitignore @@ -44,6 +44,7 @@ src/.deps/ src/Makefile src/calibrate/.deps/ src/cpu/.deps/ +src/cpu/rapl/.deps src/devices/.deps/ src/measurement/.deps/ src/parameters/.deps/ -- 2.0.3

The same error was fixed in multiple files to made clang++ work. error: variable length array of non-POD element type 'string' (aka 'basic_string<char>') Signed-off-by: Sami Kerola <kerolasa(a)iki.fi&gt; --- src/cpu/cpu.cpp | 18 ++++++++++++------ src/devices/ahci.cpp | 3 ++- src/devices/device.cpp | 6 ++++-- src/devlist.cpp | 3 ++- src/process/do_process.cpp | 9 ++++++--- src/report/report.cpp | 3 ++- src/tuning/tuning.cpp | 10 ++++++---- 7 files changed, 34 insertions(+), 18 deletions(-) diff --git a/src/cpu/cpu.cpp b/src/cpu/cpu.cpp index dbca20c..4e040c1 100644 --- a/src/cpu/cpu.cpp +++ b/src/cpu/cpu.cpp @@ -479,12 +479,12 @@ void report_display_cpu_cstates(void) /* Tables for PKG, CORE, CPU */ pkg_tbl_size.cols=2; pkg_tbl_size.rows= ((cstates_num+1)-LEVEL_HEADER)+1; - string pkg_data[pkg_tbl_size.cols * pkg_tbl_size.rows]; + string *pkg_data = new string[pkg_tbl_size.cols * pkg_tbl_size.rows]; core_tbl_size.cols=2; core_tbl_size.rows=(cstates_num *_package->children.size()) + _package->children.size(); - string core_data[core_tbl_size.cols * core_tbl_size.rows]; + string *core_data = new string[core_tbl_size.cols * core_tbl_size.rows]; int num_cpus=0, num_cores=0; for (core = 0; core < _package->children.size(); core++) { @@ -506,7 +506,7 @@ void report_display_cpu_cstates(void) cpu_tbl_size.cols=(2 * (num_cpus / num_cores)) + 1; cpu_tbl_size.rows = ((cstates_num+1-LEVEL_HEADER) * _package->children.size()) + _package->children.size(); - string cpu_data[cpu_tbl_size.cols * cpu_tbl_size.rows]; + string *cpu_data = new string[cpu_tbl_size.cols * cpu_tbl_size.rows]; for (core = 0; core < _package->children.size(); core++) { cpu_data[idx3]="&nbsp;"; @@ -633,6 +633,9 @@ void report_display_cpu_cstates(void) init_cpu_table_attr(&std_table_css, title+1, cpu_tbl_size.rows, cpu_tbl_size.cols); report.add_table(cpu_data, &std_table_css); + delete [] pkg_data; + delete [] core_data; + delete [] cpu_data; } report.end_div(); } @@ -688,11 +691,11 @@ void report_display_cpu_pstates(void) /* Tables for PKG, CORE, CPU */ pkg_tbl_size.cols=2; pkg_tbl_size.rows=((pstates_num+1)-LEVEL_HEADER)+2; - string pkg_data[pkg_tbl_size.cols * pkg_tbl_size.rows]; + string *pkg_data = new string[pkg_tbl_size.cols * pkg_tbl_size.rows]; core_tbl_size.cols=2; core_tbl_size.rows=((pstates_num+2) *_package->children.size()); - string core_data[core_tbl_size.cols * core_tbl_size.rows]; + string *core_data = new string[core_tbl_size.cols * core_tbl_size.rows]; /* PKG */ num_cpus=0; @@ -717,7 +720,7 @@ void report_display_cpu_pstates(void) cpu_tbl_size.cols= (num_cpus/ num_cores) + 1; cpu_tbl_size.rows= (pstates_num+2) * _package->children.size() + _package->children.size(); - string cpu_data[cpu_tbl_size.cols * cpu_tbl_size.rows]; + string *cpu_data = new string[cpu_tbl_size.cols * cpu_tbl_size.rows]; /* Core */ for (core = 0; core < _package->children.size(); core++) { @@ -818,6 +821,9 @@ void report_display_cpu_pstates(void) init_cpu_table_attr(&std_table_css, title, cpu_tbl_size.rows, cpu_tbl_size.cols); report.add_table(cpu_data, &std_table_css); + delete [] pkg_data; + delete [] core_data; + delete [] cpu_data; } report.end_div(); } diff --git a/src/devices/ahci.cpp b/src/devices/ahci.cpp index 3b4627a..a0891ae 100644 --- a/src/devices/ahci.cpp +++ b/src/devices/ahci.cpp @@ -382,7 +382,7 @@ void ahci_create_device_stats_table(void) /* Set array of data in row Major order */ - string ahci_data[cols * rows]; + string *ahci_data = new string[cols * rows]; ahci_data[0]=__("Link"); ahci_data[1]=__("Active"); ahci_data[2]=__("Partial"); @@ -396,6 +396,7 @@ void ahci_create_device_stats_table(void) report.add_title(&title_attr, __("AHCI ALPM Residency Statistics")); report.add_table(ahci_data, &std_table_css); report.end_div(); + delete [] ahci_data; } void ahci::report_device_stats(string *ahci_data, int idx) diff --git a/src/devices/device.cpp b/src/devices/device.cpp index da595a8..b4765ef 100644 --- a/src/devices/device.cpp +++ b/src/devices/device.cpp @@ -247,7 +247,7 @@ void show_report_devices(void) /* Device Summary */ int summary_size=2; - string summary[summary_size]; + string *summary = new string[summary_size]; pw = global_joules_consumed(); char buf[32]; if (pw > 0.0001) { @@ -263,9 +263,10 @@ void show_report_devices(void) summary[1].append(" W"); report.add_summary_list(summary, summary_size); } + delete [] summary; /* Set array of data in row Major order */ - string device_data[cols * rows]; + string *device_data = new string[cols * rows]; device_data[0]= __("Usage"); device_data[1]= __("Device Name"); if (show_power) @@ -308,6 +309,7 @@ void show_report_devices(void) /* Report Output */ report.add_title(&title_attr, __("Device Power Report")); report.add_table(device_data, &std_table_css); + delete [] device_data; } diff --git a/src/devlist.cpp b/src/devlist.cpp index 21b4c1c..20fe5da 100644 --- a/src/devlist.cpp +++ b/src/devlist.cpp @@ -326,7 +326,7 @@ void report_show_open_devices(void) init_title_attr(&title_attr); /* Set array of data in row Major order */ - string process_data[cols * rows]; + string *process_data = new string[cols * rows]; sort(target->begin(), target->end(), devlist_sort); process_data[0]=__("Process"); @@ -348,5 +348,6 @@ void report_show_open_devices(void) /* No div attribute here inherits from device power report */ report.add_title(&title_attr, __("Process Device Activity")); report.add_table(process_data, &std_table_css); + delete [] process_data; report.end_div(); } diff --git a/src/process/do_process.cpp b/src/process/do_process.cpp index f7f9765..15115c3 100644 --- a/src/process/do_process.cpp +++ b/src/process/do_process.cpp @@ -918,7 +918,7 @@ void report_process_update_display(void) init_title_attr(&title_attr); /* Set array of data in row Major order */ - string software_data[cols * rows]; + string *software_data = new string[cols * rows]; software_data[0]=__("Usage"); software_data[1]=__("Wakeups/s"); software_data[2]=__("GPU ops/s"); @@ -1013,6 +1013,7 @@ void report_process_update_display(void) report.add_title(&title_attr, __("Overview of Software Power Consumers")); report.add_table(software_data, &std_table_css); report.end_div(); + delete [] software_data; } void report_summary(void) @@ -1048,7 +1049,7 @@ void report_summary(void) /* Set array for summary */ int summary_size =12; - string summary[summary_size]; + string *summary = new string [summary_size]; summary[0]=__("Target:"); summary[1]=__("1 units/s"); summary[2]=__("System: "); @@ -1068,7 +1069,7 @@ void report_summary(void) summary[11].append(__(" ops/s")); /* Set array of data in row Major order */ - string summary_data[cols * (rows+1)]; + string *summary_data = new string[cols * (rows+1)]; summary_data[0]=__("Usage"); summary_data[1]=__("Events/s"); summary_data[2]=__("Category"); @@ -1134,6 +1135,8 @@ void report_summary(void) report.add_title(&title_attr, __("Top 10 Power Consumers")); report.add_table(summary_data, &std_table_css); report.end_div(); + delete [] summary; + delete [] summary_data; } diff --git a/src/report/report.cpp b/src/report/report.cpp index d55531e..981e984 100644 --- a/src/report/report.cpp +++ b/src/report/report.cpp @@ -115,7 +115,7 @@ static void system_info(void) init_title_attr(&title_attr); /* Set array of data in row Major order */ - string system_data[sys_table.rows * sys_table.cols]; + string *system_data = new string[sys_table.rows * sys_table.cols]; system_data[0]=__("PowerTOP Version"); system_data[1]=POWERTOP_VERSION; @@ -159,6 +159,7 @@ static void system_info(void) report.end_div(); report.end_header(); report.add_navigation(); + delete [] system_data; } void init_report_output(char *filename_str, int iterations) diff --git a/src/tuning/tuning.cpp b/src/tuning/tuning.cpp index 6367a20..85b80ac 100644 --- a/src/tuning/tuning.cpp +++ b/src/tuning/tuning.cpp @@ -230,7 +230,7 @@ void report_show_tunables(void) init_tune_table_attr(&tune_table_css, rows, cols); /* Set array of data in row Major order */ - string tunable_data[cols * rows]; + string *tunable_data = new string[cols * rows]; tunable_data[0]=__("Description"); tunable_data[1]=__("Script"); @@ -249,6 +249,7 @@ void report_show_tunables(void) /* Report Output */ report.add_title(&title_attr,__("Software Settings in Need of Tuning")); report.add_table(tunable_data, &tune_table_css); + delete [] tunable_data; } /* Second Table */ @@ -258,7 +259,7 @@ void report_show_tunables(void) init_tune_table_attr(&tune_table_css, rows, cols); /* Set array of data in row Major order */ - string untunable_data[rows]; + string *untunable_data = new string[rows]; untunable_data[0]=__("Description"); for (i = 0; i < all_untunables.size(); i++) @@ -267,6 +268,7 @@ void report_show_tunables(void) /* Report Output */ report.add_title(&title_attr,__("Untunable Software Issues")); report.add_table(untunable_data, &tune_table_css); + delete [] untunable_data; /* Third Table */ /* Set Table attributes, rows, and cols */ @@ -275,7 +277,7 @@ void report_show_tunables(void) init_std_table_attr(&tune_table_css, rows, cols); /* Set array of data in row Major order */ - string tuned_data[rows]; + string *tuned_data = new string[rows]; tuned_data[0]=__("Description"); idx=cols; for (i = 0; i < all_tunables.size(); i++) { @@ -291,7 +293,7 @@ void report_show_tunables(void) report.add_title(&title_attr,__("Optimal Tuned Software Settings")); report.add_table(tuned_data, &tune_table_css); report.end_div(); - + delete [] tuned_data; } void clear_tuning() -- 2.0.3

Signed-off-by: Sami Kerola <kerolasa(a)iki.fi&gt; --- src/cpu/rapl/rapl_interface.cpp | 4 ++-- src/devices/alsa.cpp | 1 - src/display.cpp | 9 ++------- src/tuning/runtime.cpp | 4 ---- src/tuning/tuning.cpp | 1 - 5 files changed, 4 insertions(+), 15 deletions(-) diff --git a/src/cpu/rapl/rapl_interface.cpp b/src/cpu/rapl/rapl_interface.cpp index a19e0a9..ab8e8ce 100644 --- a/src/cpu/rapl/rapl_interface.cpp +++ b/src/cpu/rapl/rapl_interface.cpp @@ -647,9 +647,9 @@ void c_rapl_interface::rapl_measure_energy() double pp0_joules = 0; double pp1_joules = 0; - ret = get_pkg_power_info(&thermal_spec_power, &max_power, &min_power, &max_time_window); + get_pkg_power_info(&thermal_spec_power, &max_power, &min_power, &max_time_window); RAPL_DBG_PRINT("Pkg Power Info: Thermal spec %f watts, max %f watts, min %f watts, max time window %f seconds\n", thermal_spec_power, max_power, min_power, max_time_window); - ret = get_dram_power_info(&thermal_spec_power, &max_power, &min_power, &max_time_window); + get_dram_power_info(&thermal_spec_power, &max_power, &min_power, &max_time_window); RAPL_DBG_PRINT("DRAM Power Info: Thermal spec %f watts, max %f watts, min %f watts, max time window %f seconds\n", thermal_spec_power, max_power, min_power, max_time_window); for (;;) { diff --git a/src/devices/alsa.cpp b/src/devices/alsa.cpp index 5dee334..a1fca71 100644 --- a/src/devices/alsa.cpp +++ b/src/devices/alsa.cpp @@ -154,7 +154,6 @@ static void create_all_alsa_callback(const char *d_name) { char filename[4096]; class alsa *bl; - ofstream file; if (strncmp(d_name, "hwC", 3) != 0) return; diff --git a/src/display.cpp b/src/display.cpp index c76ba27..123620a 100644 --- a/src/display.cpp +++ b/src/display.cpp @@ -267,13 +267,8 @@ void cursor_up(void) if (w) { w->cursor_up(); if(w->ypad_pos > 0) { - if (tab_names[current_tab] == "Tunables") { - prefresh(w->win, --w->ypad_pos, w->xpad_pos, - 1, 0, LINES - 3, COLS - 1); - } else { - prefresh(w->win, --w->ypad_pos, w->xpad_pos, - 1, 0, LINES - 3, COLS - 1); - } + prefresh(w->win, --w->ypad_pos, w->xpad_pos, + 1, 0, LINES - 3, COLS - 1); } } diff --git a/src/tuning/runtime.cpp b/src/tuning/runtime.cpp index b57d53e..3201fdd 100644 --- a/src/tuning/runtime.cpp +++ b/src/tuning/runtime.cpp @@ -139,10 +139,6 @@ void add_runtime_tunables(const char *bus) if (entry->d_name[0] == '.') continue; - sprintf(filename, "/sys/bus/%s/devices/%s", bus, entry->d_name); - - - sprintf(filename, "/sys/bus/%s/devices/%s/power/control", bus, entry->d_name); if (access(filename, R_OK) != 0) diff --git a/src/tuning/tuning.cpp b/src/tuning/tuning.cpp index 85b80ac..7d64cad 100644 --- a/src/tuning/tuning.cpp +++ b/src/tuning/tuning.cpp @@ -198,7 +198,6 @@ void report_show_tunables(void) unsigned int i; /* three tables; bad, unfixable, good */ sort_tunables(); - string srt_tmp; int idx, rows = 0, cols; /* First Table */ -- 2.0.3

Signed-off-by: Sami Kerola <kerolasa(a)iki.fi&gt; --- src/main.cpp | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/main.cpp b/src/main.cpp index 910fe5c..98fee0a 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -459,7 +459,8 @@ int main(int argc, char **argv) end_pci_access(); exit(0); } - init_display(); + if (!auto_tune) + init_display(); initialize_tuning(); /* first one is short to not let the user wait too long */ one_measurement(1, NULL); @@ -472,11 +473,13 @@ int main(int argc, char **argv) } while (!leave_powertop) { - show_cur_tab(); + if (!auto_tune) + show_cur_tab(); one_measurement(time_out, NULL); learn_parameters(15, 0); } - endwin(); + if (!auto_tune) + endwin(); printf("%s\n", _("Leaving PowerTOP")); end_process_data(); -- 2.0.3

Found with misspell-check. Signed-off-by: Sami Kerola <kerolasa(a)iki.fi&gt; --- src/tuning/nl80211.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/tuning/nl80211.h b/src/tuning/nl80211.h index e4a8839..83b0514 100644 --- a/src/tuning/nl80211.h +++ b/src/tuning/nl80211.h @@ -828,7 +828,7 @@ enum nl80211_commands { * bit. Depending on which antennas are selected in the bitmap, 802.11n * drivers can derive which chainmasks to use (if all antennas belonging to * a particular chain are disabled this chain should be disabled) and if - * a chain has diversity antennas wether diversity should be used or not. + * a chain has diversity antennas whether diversity should be used or not. * HT capabilities (STBC, TX Beamforming, Antenna selection) can be * derived from the available chains after applying the antenna mask. * Non-802.11n drivers can derive wether to use diversity or not. @@ -855,7 +855,7 @@ enum nl80211_commands { * @__NL80211_ATTR_AFTER_LAST: internal use */ enum nl80211_attrs { -/* don't change the order or add anything inbetween, this is ABI! */ +/* don't change the order or add anything between, this is ABI! */ NL80211_ATTR_UNSPEC, NL80211_ATTR_WIPHY, -- 2.0.3

Keep the regular expressions, directories, and individual files separate understandable way. Signed-off-by: Sami Kerola <kerolasa(a)iki.fi&gt; --- .gitignore | 111 +++++++++++++++++++++++++++---------------------------------- 1 file changed, 49 insertions(+), 62 deletions(-) diff --git a/.gitignore b/.gitignore index d00973f..b9188a1 100644 --- a/.gitignore +++ b/.gitignore @@ -1,66 +1,53 @@ -*~ -*.o +# regular expressions *.a -*.html *.csv -*.powertop -ChangeLog -Makefile.in -aclocal.m4 -config.guess -config.h.in -config.rpath -config.sub -configure -depcomp -install-sh -ltmain.sh -missing -stamp-h1 -Makefile -config.h -config.log -config.status -libtool -pevent/.deps/ -pevent/Makefile -pevent/Makefile.in -po/Makefile -po/Makevars.template -po/POTFILES -po/Rules-quot -po/boldquot.sed -po/en(a)boldquot.header -po/en(a)quot.header -po/insert-header.sin -po/quot.sed -po/remove-potcdate.sin -po/*.gmo -po/stamp-po -src/powertop -src/css.h -src/Makefile.in -src/.deps/ -src/Makefile -src/calibrate/.deps/ -src/cpu/.deps/ -src/cpu/rapl/.deps -src/devices/.deps/ -src/measurement/.deps/ -src/parameters/.deps/ -src/perf/.deps/ -src/process/.deps/ -src/tuning/.deps/ -src/report/.deps/ -m4 *.dirstamp -*.lo +*.html *.la -autom4te.cache -remove-potcdate.sed -compile -stamp-po -ABOUT-NLS -ar-lib -traceevent/.deps/ -traceevents/.libs/ +*.lo +*.o +*.powertop +*~ +.deps +/po/*.gmo +Makefile +Makefile.in + +# directories +/m4/ + +# individual files +/ABOUT-NLS +/ChangeLog +/aclocal.m4 +/ar-lib +/autom4te.cache +/compile +/config.guess +/config.h +/config.h.in +/config.log +/config.rpath +/config.status +/config.sub +/configure +/depcomp +/install-sh +/libtool +/ltmain.sh +/missing +/po/Makevars.template +/po/POTFILES +/po/Rules-quot +/po/boldquot.sed +/po/en(a)boldquot.header +/po/en(a)quot.header +/po/insert-header.sin +/po/quot.sed +/po/remove-potcdate.sin +/po/stamp-po +/remove-potcdate.sed +/src/css.h +/src/powertop +/stamp-h1 +/stamp-po -- 2.0.3