Date: Wed, 19 Sep 2012 00:13:18 +0900 From: Namhyung Kim <namhyung(a)gmail.com&gt; To: powertop(a)lists.01.org Subject: [Powertop] [PATCH 2/2] devlist: NULL terminate struct devuser fields X-Mailer: git-send-email 1.7.9.2 As strncpy doesn't guarantee the destination buffer is NULL- terminated, do it explicitly.

Signed-off-by: Namhyung Kim <namhyung(a)gmail.com&gt; --- src/devlist.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/devlist.cpp b/src/devlist.cpp index 828f47f..71898af 100644 --- a/src/devlist.cpp +++ b/src/devlist.cpp @@ -147,7 +147,9 @@ void collect_open_devices(void) continue; dev->pid = strtoull(entry->d_name, NULL, 10); strncpy(dev->device, link, 251); + dev->device[251] = '\0'; strncpy(dev->comm, read_sysfs_string("/proc/%s/comm", entry->d_name).c_str(), 31); + dev->comm[31] = '\0'; target->push_back(dev); } -- 1.7.9.2 _______________________________________________ PowerTop mailing list PowerTop(a)lists.01.org https://lists.01.org/mailman/listinfo/powertop

As strncpy doesn't guarantee the destination buffer is NULL- terminated, do it explicitly. Signed-off-by: Namhyung Kim <namhyung(a)gmail.com&gt; --- src/devlist.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/devlist.cpp b/src/devlist.cpp index 828f47f..71898af 100644 --- a/src/devlist.cpp +++ b/src/devlist.cpp @@ -147,7 +147,9 @@ void collect_open_devices(void) continue; dev->pid = strtoull(entry->d_name, NULL, 10); strncpy(dev->device, link, 251); + dev->device[251] = '\0'; strncpy(dev->comm, read_sysfs_string("/proc/%s/comm", entry->d_name).c_str(), 31); + dev->comm[31] = '\0'; target->push_back(dev); }