[Warning fixes 2/6] Build with -Wno-unused-result for now, it seems at least some of these cases are intentional (see ml discussion)
2:53 a.m.
Note: Is this this flag supported on all compilers?
Signed-off-by: Joerg Mayer <jmpt(a)loplof.de>
diff --git a/src/Makefile.am b/src/Makefile.am
index d233d85..ec70bc4 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -33,8 +33,9 @@ powertop_SOURCES = parameters/persistent.cpp parameters/learn.cpp
parameters/par
main.cpp css.h powertop.css cpu/intel_gpu.cpp
-powertop_CXXFLAGS = -fno-omit-frame-pointer -fstack-protector -Wall -Wshadow -Wformat
$(NCURSES_CFLAGS) $(PCIUTILS_CFLAGS) $(LIBNL_CFLAGS) $(GLIB2_CFLAGS)
-
+powertop_CXXFLAGS = \
+ -fno-omit-frame-pointer -fstack-protector -Wall -Wshadow -Wformat -Wno-unused-result \
+ $(NCURSES_CFLAGS) $(PCIUTILS_CFLAGS) $(LIBNL_CFLAGS) $(GLIB2_CFLAGS)
powertop_CPPFLAGS = -D_FORTIFY_SOURCE=2 $(NCURSES_CFLAGS) $(PCIUTILS_CFLAGS)
$(LIBNL_CFLAGS) $(GLIB2_CFLAGS) $(LIBZ_CFLAGS) -DLOCALEDIR=\"$(localedir)\"
--
1.7.7
3:38 a.m.
New subject: [Powertop] [Warning fixes 2/6] Build with -Wno-unused-result for now, it seems at least some of these cases are intentional (see ml discussion)
On Fri, 2012-08-24 at 18:53 +0200, Joerg Mayer wrote:
Note: Is this this flag supported on all compilers?
Please don't.
If you really mean to ignore the result values then the canonical thing
to do is to cast them to (void)
/MF
3:54 a.m.
New subject: [Powertop] [Warning fixes 2/6] Build with -Wno-unused-result for now, it seems at least some of these cases are intentional (see ml discussion)
On 08/24/2012 10:38 AM, Magnus Fromreide wrote:
On Fri, 2012-08-24 at 18:53 +0200, Joerg Mayer wrote:
> Note: Is this this flag supported on all compilers?
Please don't.
If you really mean to ignore the result values then the canonical thing
to do is to cast them to (void)
Agreed. Also really don't want this as some of
the results that are
being ignored should really be fixed. Meaning wrapped in error handling.
/MF
_______________________________________________
PowerTop mailing list
PowerTop(a)lists.01.org
https://lists.01.org/mailman/listinfo/powertop
5:29 p.m.
New subject: [Powertop] [Warning fixes 2/6] Build with -Wno-unused-result for now, it seems at least some of these cases are intentional (see ml discussion)
On Fri, Aug 24, 2012 at 10:54:17AM -0700, Chris Ferron wrote:
On 08/24/2012 10:38 AM, Magnus Fromreide wrote:
>On Fri, 2012-08-24 at 18:53 +0200, Joerg Mayer wrote:
>>Note: Is this this flag supported on all compilers?
>Please don't.
>
>If you really mean to ignore the result values then the canonical thing
>to do is to cast them to (void)
Agreed. Also really don't want this as some of the results that are
being ignored should really be fixed. Meaning wrapped in error
handling.
OK, I expected this part of the patch series to be controversial - so just
skip it.
Thanks
Jörg
--
Joerg Mayer <jmayer(a)loplof.de>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
3676
days inactive
3677
days old
3 comments
3 participants
participants (3)
-
Chris Ferron -
Joerg Mayer -
Magnus Fromreide