On 18 November 2014 at 18:08, Alexandra Yates <alexandra.yates(a)linux.intel.com&gt; wrote: >> <alexandra.yates(a)linux.intel.com&gt; wrote: >>> When I run checkpatch.pl I get white spaces and over 80 char line >>> errors >>> on your patches. >> >> Hi Alexandra, >> >> You are right, I missed in the change 0004 'csstoh.sh: check every >> single return value' a white space error. That is now fixed in: >> >> https://github.com/kerolasa/powertop/commit/6d7e331488db1e142892557943124... >> >> 80 char line errors are strange. I do not see them. Are we using the >> same version of the checkpatch.pl? >> >> $ git describe >> v3.18-rc5 >> $ shasum scripts/checkpatch.pl >> a13cad76323e71c97ba279838feef9730509fc59 scripts/checkpatch.pl > > I'm using the tip of the branch from > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git Hii Alexandra, Congratulations on the new release. I suppose now after the release my patch set can be put back on track. Since I do not see the same errors as you could you run the checkpatch.pl against the 14 changes and send me the output. That would help me a lot. -- Sami Kerola http://www.iki.fi/kerolasa/