The strdup() can return NULL so that the result should be checked. Signed-off-by: Namhyung Kim <namhyung(a)gmail.com&gt; ---

src/perf/perf.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/perf/perf.cpp b/src/perf/perf.cpp index c8ba7a8..35b4017 100644 --- a/src/perf/perf.cpp +++ b/src/perf/perf.cpp @@ -145,6 +145,11 @@ void perf_event::set_event_name(const char *event_name) if (name) free(name); name = strdup(event_name); + if (!name) { + fprintf(stderr, "failed to allocate event name\n"); + return; + } + char *c; c = strchr(name, ':');

The third argument of PERF_EVENT_IOC_{ENABLE,DISABLE} ioctl is a flag to determine whether the command should be applied to group members. Since the powertop doesn't use the event grouping feature, it'd better passing 0 as a third argument explicitly. Signed-off-by: Namhyung Kim <namhyung(a)gmail.com&gt; --- src/perf/perf.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/perf/perf.cpp b/src/perf/perf.cpp index 69f1da3..c8ba7a8 100644 --- a/src/perf/perf.cpp +++ b/src/perf/perf.cpp @@ -128,7 +128,7 @@ void perf_event::create_perf_event(char *eventname, int _cpu) return; } - ret = ioctl(perf_fd, PERF_EVENT_IOC_ENABLE); + ret = ioctl(perf_fd, PERF_EVENT_IOC_ENABLE, 0); if (ret < 0) { fprintf(stderr, "failed to enable perf \n"); @@ -210,7 +210,7 @@ void perf_event::start(void) void perf_event::stop(void) { int ret; - ret = ioctl(perf_fd, PERF_EVENT_IOC_DISABLE); + ret = ioctl(perf_fd, PERF_EVENT_IOC_DISABLE, 0); if (ret) cout << "stop failing\n"; }