Hi David,
A big sigh about the lag between patch submission and a response.
Apologies for that. That lag is not indicative of your
submission's value. I appreciate your submissions very much. ^_^
There was a whitespace quirk, likely due to the MUA used to submit it,
so I had to pass --ignore-whitespace to git-am for a clean application.
That issue seems to specific to this submission and not subsequent
ones, so I'll use git-send-email to submit a 'v2' to maintain
a strict association between the mailing list and what ultimately
lands in the repository.
Style nit inlined below which will not hinder progress whatsoever...
On Mon, 23 May 2016 12:56:06 +1000
Daniel Black <daniel.black(a)au1.ibm.com> wrote:
Running autoreconf (autconf-2.69/automake-1.15/libtoolize-2.4.6)
without the m4 directory specified in the Makefile.am file generates
the following warning:
./autogen.sh
autoreconf: Entering directory `.'
autoreconf: running: autopoint
autoreconf: running: aclocal
autoreconf: configure.ac: tracing
autoreconf: running: libtoolize --copy
libtoolize: Consider adding '-I m4' to ACLOCAL_AMFLAGS in Makefile.am.
autoreconf: running: /usr/bin/autoconf
autoreconf: running: /usr/bin/autoheader
autoreconf: running: automake --add-missing --copy --no-force
configure.ac:26: warning: The 'AM_PROG_MKDIR_P' macro is deprecated,
and its use is discouraged.
configure.ac:26: You should use the Autoconf-provided
'AC_PROG_MKDIR_P' macro instead,
configure.ac:26: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your
Makefile.am files.
autoreconf: Leaving directory `.'
---
Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile.am b/Makefile.am
index c8d0ae2..a9cf9db 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,4 +1,5 @@
AUTOMAKE_OPTIONS = subdir-objects
+ACLOCAL_AMFLAGS=-I m4
v2 will have spaces surrounding '=' to maintain style consistency. (PS:
I'm aware of numerous style issues around the codebase).
SUBDIRS = \
traceevent \
--
2.7.4
Cheers, and thanks again for the submission