On (10/15/12 16:02), Paul Menzel wrote:
thank you for your patch.
Am Montag, den 15.10.2012, 02:25 -0700 schrieb Sergey Senozhatsky:
> [PATCH] fix typo and correct coding styles in report_formatter
Please do not repeat the summary in the commit message body.
I do like this line in git shortlog, the only thing with that line
is that *probably* [PATCH] should not be there, but I can't see any
problems with it anyway.
> Igor noted a typo and coding styles errors in previous patch,
correct them.
Two patches are better. If not only that you can make the commit summary
smaller. ;-)
why? two patches are good for bisecting, no one ever will bisect those
2 small changes.
-ss
report-formatter.h: Fix typo iget_resul → get_result()
report-formatter.h: Remove ; to adhere to coding style
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>
[…]
It would be great if you could resend.