Hi everyone! Viresh Kumar wrote: I agree with that. Also I think that report system with many places like: if (html) printf(something); else printf(nearly-the-same); that needs to be redesigned. I use something like CSV-generator in my yet to be merged MALI GPU support patch because generated CVS's doesn't conform to any CSV standards: there are no quotes for empty values, also quote symbols are not escaped inside the values. Commas are not escaped too. So it is impossible to parse generated CSV's with traditional parsers. I think that we could design generalized reporting system that could output data in any desired format (HTML, CSV and probably TXT). Since all results are contained inside the tables, that system could have interface like create_report(type); report.add_table(...); report.add_column_name(const char *name, bool last_in_line = false); report.add_column_val(const char *value, bool last_in_line = false); report.get_result(); Now there are a lots of code like that: if (reporttype) fprintf(reportout.http_report, "<tr class=\"%s\"><td class=\"process_power\">%s</td><td class=\"process_power\">%s</td><td class=\"process_power\">%s</td><td>%s</td><td>%s</td></tr>\n", process_class(lines), power, usage, events, name, pretty_print(all_power[i]->description(), descr, 128)); else fprintf(reportout.csv_report, "%s,%s,%s,%s,%s \n", power, usage, events, name, pretty_print(all_power[i]->description(), descr, 128)); I think that we could separate CSV/HTML generation code from processing logic. What you think? -- Best regards, Igor Zhbanov, Expert Software Engineer, phone: +7 (495) 797 25 00 ext 3806 e-mail: i.zhbanov(a)samsung.com ASWG, Moscow R&D center, Samsung Electronics 12 Dvintsev street, building 1 127018, Moscow, Russian Federation

On (08/29/12 10:59), Igor Zhbanov wrote: thanks a lot for reporting. no offense, but do we actually need that kind of flexibility? -ss

On (08/30/12 10:40), Igor Zhbanov wrote: Hello Igor, yes, good points. so, now we have two proposals for reworks: UI rework and generalization (scaling, scrolilng, etc.) and proposal for reporting system generalization and rework, and the latter one is priority (if we stick to it) -- it's rather hard to depend on UI and pretty easy on output file format, thus format changes should be done as soon as possible. -ss

Arjan van de Ven wrote: It is good. But it is bad-formatted, so no one standard parser could parse it. It contains unquoted empty values like , , , Also it doesn't escape double quote symbols inside the values. It doesn't escape commas inside the values. This is especially important for some locales where comma is used as decimal separator in floating-point numbers. So I prefer to run PowerTOP like this: LC_NUMERIC=en ./powertop ... It doesn't escape space characters inside the values. It lefts hanging commas in the end of the string. Etc. So the CSV-report of the PowerTOP doesn't conform to any CSV standards. -- Best regards, Igor Zhbanov, Expert Software Engineer, phone: +7 (495) 797 25 00 ext 3806 e-mail: i.zhbanov(a)samsung.com ASWG, Moscow R&D center, Samsung Electronics 12 Dvintsev street, building 1 127018, Moscow, Russian Federation