Hi Sergey I tested in powertop tool and find that there is no cpu_id filed in some perf events. such as sched_switch, hrtimer_expire_exit and so on. so we can't modify this change in src/perf/perf_bundle (perf_sample's perf_event_header). And we didn't find any bugs on other perf events. So we only modified it in src/cpu/cpu.cpp.

On Tue, Oct 8, 2013 at 4:17 PM, Jon Medhurst (Tixy) <tixy(a)linaro.org&gt; wrote: > On Mon, 2013-10-07 at 22:54 +0800, Shaojie Sun wrote: >> add jon.medhurst(a)linaro.org >> >> On Mon, Oct 7, 2013 at 7:40 PM, Sergey Senozhatsky >> <sergey.senozhatsky(a)gmail.com&gt; wrote: >> > On (10/07/13 19:31), Shaojie Sun wrote: >> >> Date: Mon, 7 Oct 2013 19:31:54 +0800 >> >> From: Shaojie Sun <shaojie.sun(a)linaro.org&gt; >> >> To: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com&gt; >> >> Cc: Sanjay Rawat <sanjay.rawat(a)linaro.org&gt;, Jon Medhurst <tixy(a)linaro.org&gt;, >> >> SunShaoJie <sunshaojie(a)huawei.com&gt;, "Private-PMWG@Linaro" >> >> <private-pmwg(a)linaro.org&gt; >> >> Subject: Re: [Powertop] [PATCH POWERTOP V3] resolve the bug that powertop >> >> doesn't show correct frequency stats >> >> >> >> Goog question. >> >> Could Tixy answer it? >> > >> > /** Removed Private-PMWG (no permissions), Cc'd powertop list. */ >> > >> > >> > >> > the thing is that we tend to trust passed cpunr in many handle_trace_point()-s. >> > so it would be better to fix all sample->trace.cpu users, because the >> > problme may be a bit bigger than that (e.g. src/process/do_process.cpp >> > perf_process_bundle::handle_trace_point()). > > That's what I thought too and said so when I commented on the Linaro's > bug tracking system [1]. I was hoping that someone more familiar with > powertop would investigate further as I had never looked at powertop or > any perf related code before. > > [1] https://bugs.launchpad.net/linaro-android/+bug/1042755/comments/14 > > -- > Tixy > >> > >> > -ss >> > >> >> On Mon, Oct 7, 2013 at 6:03 PM, Sergey Senozhatsky >> >> <sergey.senozhatsky(a)gmail.com&gt; wrote: >> >> > On (10/07/13 17:26), Shaojie Sun wrote: >> >> >> From: Jon Medhurst <tixy(a)linaro.org&gt; >> >> >> >> >> >> For cpu_frequency events, perf_power_bundle::handle_trace_point() >> >> >> is always being called with the same cpunr. so the parameter of >> >> >> cpunr is not equal to the cpu which cpu_frequency events happened. >> >> >> Lucky the trace event themselves have a cpu_id field to say to which >> >> >> CPU event it relates, we should use this cpu_id field. >> >> >> >> >> >> Signed-off-by: Jon Medhurst <tixy(a)linaro.org&gt; >> >> >> Shaojie Sun <shaojie.sun(a)linaro.com&gt; >> >> >> --- >> >> >> src/cpu/cpu.cpp | 9 +++++++-- >> >> >> 1 file changed, 7 insertions(+), 2 deletions(-) >> >> >> >> >> >> diff --git a/src/cpu/cpu.cpp b/src/cpu/cpu.cpp >> >> >> index 7f3af69..e304bbe 100644 >> >> >> --- a/src/cpu/cpu.cpp >> >> >> +++ b/src/cpu/cpu.cpp >> >> >> @@ -781,10 +781,15 @@ void perf_power_bundle::handle_trace_point(void *trace, int cpunr, uint64_t time >> >> >> >> >> >> if (strcmp(event->name, "power_frequency") == 0 >> >> >> || strcmp(event->name, "cpu_frequency") == 0){ >> >> >> - >> >> >> + ret = pevent_get_field_val(NULL, event, "cpu_id", &rec, &val, 0); >> >> >> + if (ret < 0) { >> >> >> + fprintf(stderr, _("power or cpu_frequency event returned no cpu?\n")); >> >> >> + exit(-1); >> >> >> + } >> >> >> + cpu = all_cpus[val]; >> >> >> ret = pevent_get_field_val(NULL, event, "state", &rec, &val, 0); >> >> >> if (ret < 0) { >> >> >> - fprintf(stderr, _("power or cpu_frequecny event returned no state?\n")); >> >> >> + fprintf(stderr, _("power or cpu_frequency event returned no state?\n")); >> >> >> exit(-1); >> >> >> } >> >> > >> >> > Hello, >> >> > why not fixing it in src/perf/perf_bundle (perf_sample's perf_event_header), >> >> > where we create data for handle_trace_point() ? >> >> > >> >> > -ss >> >> > >> >> >> -- >> >> >> 1.7.9.5 >> >> >> >> >> >> _______________________________________________ >> >> >> PowerTop mailing list >> >> >> PowerTop(a)lists.01.org >> >> >> https://lists.01.org/mailman/listinfo/powertop >> >> >> >> >> > >

perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 175798456, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 27164, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 1, cpu 6, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 0, cpu 27164, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu 6, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 3, cpu 13, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 1, cpu 13, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 0, cpu 8, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 27164, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 3, cpu 0, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu 17, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 1, cpu 13, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 0, cpu 27164, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu 0, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 3, cpu 13, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 1, cpu 13, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 0, cpu 27164, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 3, cpu 6, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu 17, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 1, cpu 13, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 3, cpu 27164, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu 17, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 1, cpu 13, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 0, cpu 8, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu 0, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 3, cpu 27164, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is softirq_entry. perf cpnnr 3, cpu 6, event name softirq_entry. perf find a event not support cpu_id, event name is softirq_entry. perf cpnnr 2, cpu 1, event name softirq_entry. perf find a event not support cpu_id, event name is softirq_entry. perf cpnnr 0, cpu 1, event name softirq_entry. perf find a event not support cpu_id, event name is softirq_entry. perf find a event not support cpu_id, event name is softirq_exit. perf cpnnr 0, cpu 1, event name softirq_exit. perf find a event not support cpu_id, event name is softirq_entry. perf cpnnr 3, cpu 1, event name softirq_entry. perf find a event not support cpu_id, event name is softirq_entry. perf cpnnr 2, cpu 9, event name softirq_entry. perf find a event not support cpu_id, event name is softirq_entry. perf cpnnr 1, cpu 9, event name softirq_entry. perf find a event not support cpu_id, event name is softirq_entry. perf cpnnr 0, cpu 9, event name softirq_entry. perf find a event not support cpu_id, event name is softirq_exit. perf cpnnr 0, cpu 9, event name softirq_exit. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 1, cpu 9, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu 27164, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 0, cpu 13, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 3, cpu 6, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 1, cpu 6, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu 27164, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 0, cpu 13, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 3, cpu 6, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 1, cpu 6, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu 27164, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 0, cpu 13, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 3, cpu 6, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 1, cpu 6, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu 27164, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 3, cpu 6, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 1, cpu 6, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 0, cpu 8, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu 6, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 3, cpu 27164, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 1, cpu 8, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 0, cpu 8, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 27164, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu 0, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 3, cpu 13, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 1, cpu 17, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 0, cpu 8, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 27164, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu 0, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 3, cpu 13, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 1, cpu 17, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 0, cpu 8, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu 27164, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 3, cpu 13, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 1, cpu 8, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 0, cpu 8, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 27164, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu 0, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 3, cpu 13, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 1, cpu 17, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 0, cpu 8, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 27164, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu 0, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 3, cpu 13, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 1, cpu 6, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 0, cpu 8, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu 27164, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 3, cpu 0, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 1, cpu 6, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 0, cpu 8, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu 27164, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 3, cpu 0, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 0, cpu 8, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu -1, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 3, cpu 13, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 27164, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu -1, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 0, cpu 8, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu -1, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 3, cpu 27164, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu -1, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu -1, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 0, cpu 8, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu -1, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 3, cpu 27164, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu -1, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 0, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 0, cpu 8, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 3, cpu -1, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 17, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 0, cpu 27164, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu -1, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu 0, event name sched_wakeup. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu -1, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 1, cpu 6, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu 8, event name sched_switch. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 3, cpu 13, event name sched_switch. perf find a event not support cpu_id, event name is hrtimer_expire_entry. perf cpnnr 0, cpu 1, event name hrtimer_expire_entry. perf find a event not support cpu_id, event name is hrtimer_expire_entry. perf cpnnr 2, cpu 773908736, event name hrtimer_expire_entry. perf find a event not support cpu_id, event name is hrtimer_expire_entry. perf cpnnr 3, cpu 774957312, event name hrtimer_expire_entry. perf find a event not support cpu_id, event name is hrtimer_expire_entry. perf cpnnr 1, cpu 775481600, event name hrtimer_expire_entry. perf find a event not support cpu_id, event name is hrtimer_expire_exit. perf cpnnr 3, cpu 774433024, event name hrtimer_expire_exit. perf find a event not support cpu_id, event name is hrtimer_expire_exit. perf cpnnr 2, cpu 775481600, event name hrtimer_expire_exit. perf find a event not support cpu_id, event name is hrtimer_expire_exit. perf cpnnr 0, cpu 774957312, event name hrtimer_expire_exit. perf find a event not support cpu_id, event name is hrtimer_expire_exit. perf cpnnr 1, cpu 773908736, event name hrtimer_expire_exit. perf find a event not support cpu_id, event name is softirq_entry. perf cpnnr 0, cpu 774433024, event name softirq_entry. perf find a event not support cpu_id, event name is softirq_entry. perf cpnnr 2, cpu 1, event name softirq_entry. perf find a event not support cpu_id, event name is softirq_entry. perf cpnnr 3, cpu 1, event name softirq_entry. perf find a event not support cpu_id, event name is softirq_entry. perf find a event not support cpu_id, event name is softirq_exit. perf cpnnr 0, cpu 1, event name softirq_exit. perf find a event not support cpu_id, event name is softirq_exit. perf find a event not support cpu_id, event name is softirq_exit. perf cpnnr 2, cpu 1, event name softirq_exit. perf find a event not support cpu_id, event name is softirq_exit. perf cpnnr 3, cpu 1, event name softirq_exit. perf find a event not support cpu_id, event name is softirq_entry. perf find a event not support cpu_id, event name is softirq_entry. perf cpnnr 2, cpu 9, event name softirq_entry. perf find a event not support cpu_id, event name is softirq_entry. perf cpnnr 0, cpu 9, event name softirq_entry. perf find a event not support cpu_id, event name is softirq_entry. perf cpnnr 3, cpu 9, event name softirq_entry. perf find a event not support cpu_id, event name is softirq_exit. perf cpnnr 2, cpu 9, event name softirq_exit. perf find a event not support cpu_id, event name is softirq_exit. perf cpnnr 0, cpu 9, event name softirq_exit. perf find a event not support cpu_id, event name is softirq_exit. perf cpnnr 1, cpu 9, event name softirq_exit. perf find a event not support cpu_id, event name is softirq_exit. perf cpnnr 3, cpu 9, event name softirq_exit. perf find a event not support cpu_id, event name is sched_switch. perf find a event not support cpu_id, event name is hrtimer_expire_entry. perf find a event not support cpu_id, event name is sched_wakeup. perf cpnnr 2, cpu -1898111448, event name sched_wakeup. perf find a event not support cpu_id, event name is hrtimer_expire_exit. perf cpnnr 2, cpu 17533, event name hrtimer_expire_exit. perf find a event not support cpu_id, event name is sched_switch. perf cpnnr 2, cpu -1, event name sched_switch. perf find a event not support cpu_id, event name is sched_wakeup.

Hi Sergey I tested the patch running in our system. Next is the test result.

fixed [cpu_frequency] cpuid from 2 to 3 fixed [cpu_frequency] cpuid from 2 to 4 fixed [cpu_frequency] cpuid from 2 to 3 fixed [cpu_frequency] cpuid from 2 to 4 fixed [cpu_frequency] cpuid from 2 to 3 fixed [cpu_frequency] cpuid from 2 to 4 fixed [cpu_frequency] cpuid from 2 to 0 fixed [cpu_frequency] cpuid from 2 to 1 fixed [cpu_frequency] cpuid from 2 to 0 fixed [cpu_frequency] cpuid from 2 to 1 fixed [cpu_frequency] cpuid from 2 to 0 fixed [cpu_frequency] cpuid from 2 to 1 fixed [cpu_frequency] cpuid from 2 to 0 fixed [cpu_frequency] cpuid from 2 to 1 fixed [cpu_frequency] cpuid from 2 to 0 fixed [cpu_frequency] cpuid from 2 to 1 fixed [cpu_frequency] cpuid from 2 to 0 fixed [cpu_frequency] cpuid from 2 to 1 fixed [cpu_frequency] cpuid from 2 to 0 fixed [cpu_frequency] cpuid from 2 to 1 fixed [cpu_frequency] cpuid from 2 to 0 fixed [cpu_frequency] cpuid from 2 to 1 fixed [cpu_frequency] cpuid from 2 to 3 fixed [cpu_frequency] cpuid from 2 to 4 fixed [cpu_frequency] cpuid from 2 to 3 fixed [cpu_frequency] cpuid from 2 to 4 fixed [cpu_frequency] cpuid from 2 to 3 fixed [cpu_frequency] cpuid from 2 to 4 fixed [cpu_frequency] cpuid from 2 to 0 fixed [cpu_frequency] cpuid from 2 to 1 fixed [cpu_frequency] cpuid from 2 to 0 On Tue, Oct 8, 2013 at 10:55 PM, Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com&gt; wrote: > Could you please test this patch? > > > struct perf_sample's trace cpu is a raw_smp_processor_id() > (as requsted by PERF_SAMPLE_CPU) by the time of perf_event_output() > call, which may differ from original struct perf_event's cpu. > thus we need to fix sample->trace.cpu via fixup_sample_trace_cpu() > call. > > debugging output has demonstrated that some events (namely cpu_frequency) > were routed incorrectly (sample->trace.cpu != pevent_get_field_val("cpu_id")): > fix [cpu_frequency] cpu_nr from 1 to 0 > fix [cpu_frequency] cpu_nr from 1 to 0 > fix [cpu_frequency] cpu_nr from 1 to 2 > fix [cpu_frequency] cpu_nr from 1 to 2 > fix [cpu_frequency] cpu_nr from 1 to 3 > fix [cpu_frequency] cpu_nr from 1 to 3 > fix [cpu_frequency] cpu_nr from 1 to 0 > fix [cpu_frequency] cpu_nr from 1 to 0 > fix [cpu_frequency] cpu_nr from 1 to 2 > fix [cpu_frequency] cpu_nr from 1 to 2 > fix [cpu_frequency] cpu_nr from 1 to 0 > fix [cpu_frequency] cpu_nr from 1 to 0 > fix [cpu_frequency] cpu_nr from 1 to 0 > > Thanks for reporting and tracking this down to (not in any particular > order): Shaojie Sun, Jon Medhurst, Sanjay Rawat, SunShaoJie. > > Cc: Shaojie Sun <shaojie.sun(a)linaro.org&gt; > Cc: Jon Medhurst <jon.medhurst(a)linaro.org&gt; > Cc: Sanjay Rawat <sanjay.rawat(a)linaro.org&gt; > Cc: SunShaoJie <sunshaojie(a)huawei.com&gt; > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com&gt; > > --- > > diff --git a/src/perf/perf_bundle.cpp b/src/perf/perf_bundle.cpp > index 8d480e8..b0e982b 100644 > --- a/src/perf/perf_bundle.cpp > +++ b/src/perf/perf_bundle.cpp > @@ -285,6 +285,31 @@ static bool event_sort_function (void *i, void *j) > return (timestamp(I)<timestamp(J)); > } > > +/* > + * sample's PERF_SAMPLE_CPU cpu nr is a raw_smp_processor_id() by the > + * time of perf_event_output(), which may differ from struct perf_event > + * cpu, thus we need to fix sample->trace.cpu. > + */ > +static void fixup_sample_trace_cpu(struct perf_sample *sample) > +{ > + struct event_format *event; > + struct pevent_record rec; > + unsigned long long cpu_nr; > + int type; > + int ret; > + > + rec.data = &sample->data; > + type = pevent_data_type(perf_event::pevent, &rec); > + event = pevent_find_event(perf_event::pevent, type); > + if (!event) > + return; > + /** don't touch trace if event does not contain cpu_id field*/ > + ret = pevent_get_field_val(NULL, event, "cpu_id", &rec, &cpu_nr, 0); > + if (ret < 0) > + return; > + sample->trace.cpu = cpu_nr; > +} > + > void perf_bundle::process(void) > { > unsigned int i; > @@ -309,6 +334,7 @@ void perf_bundle::process(void) > if (sample->header.type != PERF_RECORD_SAMPLE) > continue; > > + fixup_sample_trace_cpu(sample); > handle_trace_point(&sample->data, sample->trace.cpu, sample->trace.time); > } > } >