Date: Sun, 13 Oct 2013 12:45:05 +0200 From: David Rosca <nowrep(a)gmail.com&gt; To: powertop(a)lists.01.org Subject: [Powertop] [PATCH] Fixed cpu_core::has_c1_res initialization. This is regression from 8d6e716 cpu_core::has_c1_res is left uninitialized for anything other than BYT-M, resulting in error at startup:   unknown op '{'                 read_msr cpu0 0x660 : Argument list too long. Signed-off-by: David Rosca <[1]nowrep(a)gmail.com&gt; ---  src/cpu/intel_cpus.cpp | 4 +++-  1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/cpu/intel_cpus.cpp b/src/cpu/intel_cpus.cpp index 3348dba..6330b6f 100644 --- a/src/cpu/intel_cpus.cpp +++ b/src/cpu/intel_cpus.cpp @@ -101,8 +101,10 @@ nhm_core::nhm_core(int model)      if (model == 0x37) {          has_c3_res = 0;          has_c1_res = 1; -    } else +    } else {          has_c3_res = 1; +                has_c1_res = 0;

+        }

 }

   void nhm_core::measurement_start(void) -- 1.8.4.rc3 References Visible links 1. mailto:nowrep@gmail.com

_______________________________________________ PowerTop mailing list PowerTop(a)lists.01.org https://lists.01.org/mailman/listinfo/powertop

Oops, gmail screw it ... Hope it will be ok this time: PS: Sorry, I sent the first reply only to Sergey. Signed-off-by: David Rosca <[1]nowrep(a)gmail.com&gt;

---  src/cpu/intel_cpus.cpp | 4 +++-  1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/cpu/intel_cpus.cpp b/src/cpu/intel_cpus.cpp index 3348dba..6330b6f 100644 --- a/src/cpu/intel_cpus.cpp +++ b/src/cpu/intel_cpus.cpp @@ -101,8 +101,10 @@ nhm_core::nhm_core(int model)      if (model == 0x37) {          has_c3_res = 0;          has_c1_res = 1; -    } else +    } else {          has_c3_res = 1; +        has_c1_res = 0; +    }  }    void nhm_core::measurement_start( void) -- 1.8.4.rc3 2013/10/13 Sergey Senozhatsky <[2]sergey.senozhatsky(a)gmail.com&gt; On (10/13/13 12:45), David Rosca wrote: > Date: Sun, 13 Oct 2013 12:45:05 +0200 > From: David Rosca <[3]nowrep(a)gmail.com&gt; > To: [4]powertop(a)lists.01.org > Subject: [Powertop] [PATCH] Fixed cpu_core::has_c1_res initialization. > >    This is regression from 8d6e716 > >    cpu_core::has_c1_res is left uninitialized for anything other than BYT-M, >    resulting in error at startup: > >      unknown op '{' >                    read_msr cpu0 0x660 : Argument list too long. > >    Signed-off-by: David Rosca <[1][5]nowrep(a)gmail.com&gt; > >    --- >     src/cpu/intel_cpus.cpp | 4 +++- >     1 file changed, 3 insertions(+), 1 deletion(-) > >    diff --git a/src/cpu/intel_cpus.cpp b/src/cpu/intel_cpus.cpp >    index 3348dba..6330b6f 100644 >    --- a/src/cpu/intel_cpus.cpp >    +++ b/src/cpu/intel_cpus.cpp >    @@ -101,8 +101,10 @@ nhm_core::nhm_core(int model) >         if (model == 0x37) { >             has_c3_res = 0; >             has_c1_res = 1; >    -    } else >    +    } else { >             has_c3_res = 1; >    +                has_c1_res = 0;         ^^^^^^^^^^^^^^^^ >    +        }         ^^^^^^ >     } good catch. could you please use original code indentation?         -ss >      >     void nhm_core::measurement_start(void) >    -- >    1.8.4.rc3 > > References > >    Visible links >    1. mailto:[6]nowrep@gmail.com > _______________________________________________ > PowerTop mailing list > [7]PowerTop(a)lists.01.org > [8]https://lists.01.org/mailman/listinfo/powertop References Visible links 1. mailto:nowrep@gmail.com 2. mailto:sergey.senozhatsky@gmail.com 3. mailto:nowrep@gmail.com 4. mailto:powertop@lists.01.org 5. mailto:nowrep@gmail.com 6. mailto:nowrep@gmail.com 7. mailto:PowerTop@lists.01.org 8. https://lists.01.org/mailman/listinfo/powertop

_______________________________________________ PowerTop mailing list PowerTop(a)lists.01.org https://lists.01.org/mailman/listinfo/powertop