2:52 p.m.
Hi Wenhua,
Thanks for the report. Can you file a github issue for this? There's no review link
required - it's easily reproducible by just running "./configure --enable-werror;
make CC=clang CXX=clang++". It's possible this has been fixed with more recent
DPDK, or there is some flag we can pass to the DPDK build to disable this warning.
Regards,
-Jim
On 5/1/20, 5:45 AM, "Luse, Paul E" <paul.e.luse(a)intel.com> wrote:
Hi Wenhua,
Can you provide a link to the actual review?
Thanks
Paul
-----Original Message-----
From: Wenhua Liu [mailto:liuw@vmware.com]
Sent: Thursday, April 30, 2020 8:05 PM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: [SPDK] Unit test failure for review submission
Hi,
I tried to submit a change for review, some unit test was run and failed, but I did
not touch any of these files. I’m on top of the master branch.
warning: redirecting to https://review.spdk.io/gerrit/spdk/spdk/
Running make with clang ...
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/vmware/spdk/spdk/dpdk/build/include/rte_memcpy.h:359:23: error: cast from
'uint8_t *' (aka 'unsigned char *') to '__m256i *' increases
required alignment from 1 to 32 [-Werror,-Wcast-align]
_mm256_storeu_si256((__m256i *)((uint8_t *)dst + 1 * 32), ymm1);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/vmware/spdk/spdk/dpdk/build/include/rte_memcpy.h:360:23: error: cast from
'uint8_t *' (aka 'unsigned char *') to '__m256i *' increases
required alignment from 1 to 32 [-Werror,-Wcast-align]
_mm256_storeu_si256((__m256i *)((uint8_t *)dst + 2 * 32), ymm2);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/vmware/spdk/spdk/dpdk/build/include/rte_memcpy.h:361:23: error: cast from
'uint8_t *' (aka 'unsigned char *') to '__m256i *' increases
required alignment from 1 to 32 [-Werror,-Wcast-align]
_mm256_storeu_si256((__m256i *)((uint8_t *)dst + 3 * 32), ymm3);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
12 errors generated.
make[8]: *** [/home/vmware/spdk/spdk/dpdk/mk/internal/rte.compile-pre.mk:114:
malloc_heap.o] Error 1
make[7]: *** [/home/vmware/spdk/spdk/dpdk/mk/rte.subdir.mk:37: eal] Error 2
make[6]: *** [/home/vmware/spdk/spdk/dpdk/mk/rte.subdir.mk:37: linux] Error 2
make[5]: *** [/home/vmware/spdk/spdk/dpdk/mk/rte.subdir.mk:37: librte_eal] Error 2
make[4]: *** [/home/vmware/spdk/spdk/dpdk/mk/rte.sdkbuild.mk:48: lib] Error 2
make[3]: *** [/home/vmware/spdk/spdk/dpdk/mk/rte.sdkroot.mk:99: all] Error 2
make[2]: *** [Makefile:12: all] Error 2
make[1]: *** [Makefile:150: all] Error 2
make: *** [/home/vmware/spdk/spdk/mk/spdk.subdirs.mk:44: dpdkbuild] Error 2
ERROR make CC=clang CXX=clang++ returned errors!
ERROR Fix the problem and use 'git commit' to update your changes.
ERROR See /home/vmware/spdk/spdk/make.log for more information.
error: failed to push some refs to 'https://review.spdk.io/spdk/spdk'
Checking make.log, I did not see any test failed.
What could be wrong?
Thanks,
-Wenhua Liu
_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org
_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org
3:06 p.m.
New subject: Unit test failure for review submission
Hi Wenhua,
Could you try:
CC=clang CXX=clang++ ./configure
make
There is a bug in our dpdkbuild/Makefile, so please still file an issue for it. But the
above works on my system and should unblock you.
The problem is that DPDK gets configured and built based on the compiler specified when
SPDK's configure script was called, not the one specified on the make file.
That's a bug. We need to fix how CC_TYPE is evaluated in dpdkbuild/Makefile.
-Jim
On 5/1/20, 7:52 AM, "Harris, James R" <james.r.harris(a)intel.com> wrote:
Hi Wenhua,
Thanks for the report. Can you file a github issue for this? There's no review
link required - it's easily reproducible by just running "./configure
--enable-werror; make CC=clang CXX=clang++". It's possible this has been fixed
with more recent DPDK, or there is some flag we can pass to the DPDK build to disable this
warning.
Regards,
-Jim
On 5/1/20, 5:45 AM, "Luse, Paul E" <paul.e.luse(a)intel.com> wrote:
Hi Wenhua,
Can you provide a link to the actual review?
Thanks
Paul
-----Original Message-----
From: Wenhua Liu [mailto:liuw@vmware.com]
Sent: Thursday, April 30, 2020 8:05 PM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: [SPDK] Unit test failure for review submission
Hi,
I tried to submit a change for review, some unit test was run and failed, but I
did not touch any of these files. I’m on top of the master branch.
warning: redirecting to https://review.spdk.io/gerrit/spdk/spdk/
Running make with clang ...
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/vmware/spdk/spdk/dpdk/build/include/rte_memcpy.h:359:23: error: cast from
'uint8_t *' (aka 'unsigned char *') to '__m256i *' increases
required alignment from 1 to 32 [-Werror,-Wcast-align]
_mm256_storeu_si256((__m256i *)((uint8_t *)dst + 1 * 32), ymm1);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/vmware/spdk/spdk/dpdk/build/include/rte_memcpy.h:360:23: error: cast from
'uint8_t *' (aka 'unsigned char *') to '__m256i *' increases
required alignment from 1 to 32 [-Werror,-Wcast-align]
_mm256_storeu_si256((__m256i *)((uint8_t *)dst + 2 * 32), ymm2);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/vmware/spdk/spdk/dpdk/build/include/rte_memcpy.h:361:23: error: cast from
'uint8_t *' (aka 'unsigned char *') to '__m256i *' increases
required alignment from 1 to 32 [-Werror,-Wcast-align]
_mm256_storeu_si256((__m256i *)((uint8_t *)dst + 3 * 32), ymm3);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
12 errors generated.
make[8]: *** [/home/vmware/spdk/spdk/dpdk/mk/internal/rte.compile-pre.mk:114:
malloc_heap.o] Error 1
make[7]: *** [/home/vmware/spdk/spdk/dpdk/mk/rte.subdir.mk:37: eal] Error 2
make[6]: *** [/home/vmware/spdk/spdk/dpdk/mk/rte.subdir.mk:37: linux] Error 2
make[5]: *** [/home/vmware/spdk/spdk/dpdk/mk/rte.subdir.mk:37: librte_eal] Error
2
make[4]: *** [/home/vmware/spdk/spdk/dpdk/mk/rte.sdkbuild.mk:48: lib] Error 2
make[3]: *** [/home/vmware/spdk/spdk/dpdk/mk/rte.sdkroot.mk:99: all] Error 2
make[2]: *** [Makefile:12: all] Error 2
make[1]: *** [Makefile:150: all] Error 2
make: *** [/home/vmware/spdk/spdk/mk/spdk.subdirs.mk:44: dpdkbuild] Error 2
ERROR make CC=clang CXX=clang++ returned errors!
ERROR Fix the problem and use 'git commit' to update your changes.
ERROR See /home/vmware/spdk/spdk/make.log for more information.
error: failed to push some refs to 'https://review.spdk.io/spdk/spdk'
Checking make.log, I did not see any test failed.
What could be wrong?
Thanks,
-Wenhua Liu
_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org
_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org
4:58 p.m.
New subject: Unit test failure for review submission
Hi Jim,
Thank you for answering my question. I don't have problem running configure and make.
My problem is when running "git push review" which triggers some unit testing
which does make with clang. Even I added CC and CXX definitions to the git command (see
below) as you suggested, the problem still happens.
vmware@ionerds-nvme4t:~/spdk/spdk$ CC=clang CXX=clang++; git push review
Username for 'https://review.spdk.io': liu-wenhua
Password for 'https://liu-wenhua@review.spdk.io':
warning: redirecting to https://review.spdk.io/gerrit/spdk/spdk/
Running make with gcc ...
Running unittest.sh ...
[sudo] password for vmware:
Running make with clang ...
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/vmware/spdk/spdk/dpdk/build/include/rte_memcpy.h:359:23: error: cast from
'uint8_t *' (aka 'unsigned char *') to '__m256i *' increases
required alignment from 1 to 32 [-Werror,-Wcast-align]
_mm256_storeu_si256((__m256i *)((uint8_t *)dst + 1 * 32), ymm1);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/vmware/spdk/spdk/dpdk/build/include/rte_memcpy.h:360:23: error: cast from
'uint8_t *' (aka 'unsigned char *') to '__m256i *' increases
required alignment from 1 to 32 [-Werror,-Wcast-align]
_mm256_storeu_si256((__m256i *)((uint8_t *)dst + 2 * 32), ymm2);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/vmware/spdk/spdk/dpdk/build/include/rte_memcpy.h:361:23: error: cast from
'uint8_t *' (aka 'unsigned char *') to '__m256i *' increases
required alignment from 1 to 32 [-Werror,-Wcast-align]
_mm256_storeu_si256((__m256i *)((uint8_t *)dst + 3 * 32), ymm3);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
12 errors generated.
make[8]: *** [/home/vmware/spdk/spdk/dpdk/mk/internal/rte.compile-pre.mk:114:
malloc_heap.o] Error 1
make[7]: *** [/home/vmware/spdk/spdk/dpdk/mk/rte.subdir.mk:37: eal] Error 2
make[6]: *** [/home/vmware/spdk/spdk/dpdk/mk/rte.subdir.mk:37: linux] Error 2
make[5]: *** [/home/vmware/spdk/spdk/dpdk/mk/rte.subdir.mk:37: librte_eal] Error 2
make[4]: *** [/home/vmware/spdk/spdk/dpdk/mk/rte.sdkbuild.mk:48: lib] Error 2
make[3]: *** [/home/vmware/spdk/spdk/dpdk/mk/rte.sdkroot.mk:99: all] Error 2
make[2]: *** [Makefile:12: all] Error 2
make[1]: *** [Makefile:150: all] Error 2
make: *** [/home/vmware/spdk/spdk/mk/spdk.subdirs.mk:44: dpdkbuild] Error 2
ERROR make CC=clang CXX=clang++ returned errors!
ERROR Fix the problem and use 'git commit' to update your changes.
ERROR See /home/vmware/spdk/spdk/make.log for more information.
error: failed to push some refs to 'https://review.spdk.io/spdk/spdk'
vmware@ionerds-nvme4t:~/spdk/spdk$
Thanks,
-Wenhua
On 5/1/20, 8:07 AM, "Harris, James R" <james.r.harris(a)intel.com> wrote:
Hi Wenhua,
Could you try:
CC=clang CXX=clang++ ./configure
make
There is a bug in our dpdkbuild/Makefile, so please still file an issue for it. But
the above works on my system and should unblock you.
The problem is that DPDK gets configured and built based on the compiler specified
when SPDK's configure script was called, not the one specified on the make file.
That's a bug. We need to fix how CC_TYPE is evaluated in dpdkbuild/Makefile.
-Jim
On 5/1/20, 7:52 AM, "Harris, James R" <james.r.harris(a)intel.com>
wrote:
Hi Wenhua,
Thanks for the report. Can you file a github issue for this? There's no
review link required - it's easily reproducible by just running "./configure
--enable-werror; make CC=clang CXX=clang++". It's possible this has been fixed
with more recent DPDK, or there is some flag we can pass to the DPDK build to disable this
warning.
Regards,
-Jim
On 5/1/20, 5:45 AM, "Luse, Paul E" <paul.e.luse(a)intel.com>
wrote:
Hi Wenhua,
Can you provide a link to the actual review?
Thanks
Paul
-----Original Message-----
From: Wenhua Liu [mailto:liuw@vmware.com]
Sent: Thursday, April 30, 2020 8:05 PM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: [SPDK] Unit test failure for review submission
Hi,
I tried to submit a change for review, some unit test was run and failed, but
I did not touch any of these files. I’m on top of the master branch.
warning: redirecting to
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview....
Running make with clang ...
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/vmware/spdk/spdk/dpdk/build/include/rte_memcpy.h:359:23: error: cast
from 'uint8_t *' (aka 'unsigned char *') to '__m256i *' increases
required alignment from 1 to 32 [-Werror,-Wcast-align]
_mm256_storeu_si256((__m256i *)((uint8_t *)dst + 1 * 32),
ymm1);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/vmware/spdk/spdk/dpdk/build/include/rte_memcpy.h:360:23: error: cast
from 'uint8_t *' (aka 'unsigned char *') to '__m256i *' increases
required alignment from 1 to 32 [-Werror,-Wcast-align]
_mm256_storeu_si256((__m256i *)((uint8_t *)dst + 2 * 32),
ymm2);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/vmware/spdk/spdk/dpdk/build/include/rte_memcpy.h:361:23: error: cast
from 'uint8_t *' (aka 'unsigned char *') to '__m256i *' increases
required alignment from 1 to 32 [-Werror,-Wcast-align]
_mm256_storeu_si256((__m256i *)((uint8_t *)dst + 3 * 32),
ymm3);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
12 errors generated.
make[8]: *** [/home/vmware/spdk/spdk/dpdk/mk/internal/rte.compile-pre.mk:114:
malloc_heap.o] Error 1
make[7]: *** [/home/vmware/spdk/spdk/dpdk/mk/rte.subdir.mk:37: eal] Error 2
make[6]: *** [/home/vmware/spdk/spdk/dpdk/mk/rte.subdir.mk:37: linux] Error
2
make[5]: *** [/home/vmware/spdk/spdk/dpdk/mk/rte.subdir.mk:37: librte_eal]
Error 2
make[4]: *** [/home/vmware/spdk/spdk/dpdk/mk/rte.sdkbuild.mk:48: lib] Error
2
make[3]: *** [/home/vmware/spdk/spdk/dpdk/mk/rte.sdkroot.mk:99: all] Error 2
make[2]: *** [Makefile:12: all] Error 2
make[1]: *** [Makefile:150: all] Error 2
make: *** [/home/vmware/spdk/spdk/mk/spdk.subdirs.mk:44: dpdkbuild] Error 2
ERROR make CC=clang CXX=clang++ returned errors!
ERROR Fix the problem and use 'git commit' to update your changes.
ERROR See /home/vmware/spdk/spdk/make.log for more information.
error: failed to push some refs to
'https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.spdk.io%2Fspdk%2Fspdk&data=02%7C01%7Cliuw%40vmware.com%7C888fe40b80a74f69f5b108d7ede15092%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637239424287600257&sdata=GK5sIncc9ZvflYFdkkHGo06ASAExQw9dq6E9fQ5fm3k%3D&reserved=0'
Checking make.log, I did not see any test failed.
What could be wrong?
Thanks,
-Wenhua Liu
_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org
_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org
_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org
752
days inactive
752
days old
2 comments
2 participants
participants (2)
-
Harris, James R -
Wenhua Liu