[Bug 2229] D-Bus and sync-UI: progress spinner
by bugzilla＠moblin.org
http://bugzilla.moblin.org/show_bug.cgi?id=2229
--- Comment #29 from yongsheng zhu <yongsheng.zhu(a)intel.com> 2009-12-07 18:43:14 PST ---
> | 1) 'processing' means the engine is generating messages and sending
> | messages to peers. Once the sending is completed, it turns to
> | 'waiting' to wait for peers' response.
>
> I disagree with this definition of "waiting". The whole point of the spinner
> was to tell the user when we are blocked by something which is not under our
> control, and that includes *sending* the message.
>
> We cannot reliably distinguish between "sending" and "receiving" of data with
> our current transports anyway, so the code which pretends that we are in
> STEPCMD_SENTDATA is lying to some extend.
>
> Your code should:
> - call reportStepCmd() directly after m_engine.SessionStep()
> *and* after handling its result
> - treat STEPCMD_SENTDATA, STEPCMD_NEEDDATA, STEPCMD_RESENDDATA as steps
> which set "waiting"
> - everything else sets "processing"
reasonable. 'STEPCMD_SENTDATA' should be 'STEPCMD_SENDDATA'?
> In the later case we should never send "processing" at all, because it became
> redundant. I prefer that approach. It'll require changes to the if() clause
> above: instead of checking m_syncStatus, we would check the content on
> m_stepInfo.
I also like this idea. Then I just check whether m_stepInfo is 'waiting', if
yes, append it in the status.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
12 years, 9 months
[Bug 3477] local timezone
by bugzilla＠moblin.org
http://bugzilla.moblin.org/show_bug.cgi?id=3477
--- Comment #3 from Chen Congwu <congwu.chen(a)intel.com> 2009-12-07 18:07:11 PST ---
(In reply to comment #2)
> Congwu, you ran into this when testing with a phone, right? So it seems that is
> a bit more important than originally anticipated, raising priority and pulling
> it into 1.0.
>
Yes, but detecting local timezone does not have direct effect on phone
syncing..
1) If the phone does not support UTC time, the engine needs to use
'UserTimezone' (That is the timezone for the phone) when syncing not
'SystemTimeZone'.
2) If the phone supports UTC time, the engine can send UTC time.
In my case, the N7210c did not declare support 'UTC' in devinf and
'UserTimeZone' defaults to 'SystemTimeZone', this then triggered the problem.
After Lukas pointed out some phones just forget to declare 'UTC', I tries and
it solved my problem now.
Considering this is a bug need to be fixed but not very high priority. I will
come up with this later when ready.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
12 years, 9 months
[Bug 2229] D-Bus and sync-UI: progress spinner
by bugzilla＠moblin.org
http://bugzilla.moblin.org/show_bug.cgi?id=2229
--- Comment #28 from pohly <patrick.ohly(a)intel.com> 2009-12-07 05:14:50 PST ---
(In reply to comment #27)
> The fix is on the branch 'mb2229' according to the above description. please
> review.
>From the commit message (thanks for writing it in that level of detail, that is
useful!):
| 1) 'processing' means the engine is generating messages and sending
| messages to peers. Once the sending is completed, it turns to
| 'waiting' to wait for peers' response.
I disagree with this definition of "waiting". The whole point of the spinner
was to tell the user when we are blocked by something which is not under our
control, and that includes *sending* the message.
We cannot reliably distinguish between "sending" and "receiving" of data with
our current transports anyway, so the code which pretends that we are in
STEPCMD_SENTDATA is lying to some extend.
Your code should:
- call reportStepCmd() directly after m_engine.SessionStep()
*and* after handling its result
- treat STEPCMD_SENTDATA, STEPCMD_NEEDDATA, STEPCMD_RESENDDATA as steps
which set "waiting"
- everything else sets "processing"
I'm not sure about your explicit check here:
// only make sense with 'running' and 'suspending'
if (m_syncStatus == SYNC_RUNNING || m_syncStatus == SYNC_SUSPEND) {
status += ";";
status += m_stepInfo;
}
The only situation where showing a spinner makes sense is in those states, but
does that mean that we should suppress the appending of "processing/waiting" in
the other states?
What if we send "running;waiting" and then go to "aborting"? How does the
frontend know whether it should keep the spinner spinning?
Not sending "aborting;processing" implies that the frontend must have either a
builtin rule like "disable spinner in all states except running/suspending"
(which puts logic into the frontend, where it doesn't belong) or we define that
the semantic of the D-Bus API is "disable spinner unless waiting is given
explicitly".
In the later case we should never send "processing" at all, because it became
redundant. I prefer that approach. It'll require changes to the if() clause
above: instead of checking m_syncStatus, we would check the content on
m_stepInfo.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
12 years, 9 months
[Bug 3602] add gnome-keyring support to syncevo-dbus-server
by bugzilla＠moblin.org
http://bugzilla.moblin.org/show_bug.cgi?id=3602
--- Comment #10 from pohly <patrick.ohly(a)intel.com> 2009-12-07 01:19:23 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > > 2) if has keyring library, enable keyring to store passwords by default.
> >
> > Agreed.
> >
> > > dbus
> > > clients could disable it if wanted.
> >
> > So you want to provide a mechanism for this right away? How?
> do you think it is necessary?
No. As Jussi said, this is an implementation detail or system configuration
issue.
I was only asking because you mentioned it. I wanted to check whether you
wanted to implement something.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
12 years, 9 months
[Bug 3602] add gnome-keyring support to syncevo-dbus-server
by bugzilla＠moblin.org
http://bugzilla.moblin.org/show_bug.cgi?id=3602
--- Comment #9 from jku <jku(a)linux.intel.com> 2009-12-07 01:12:01 PST ---
(In reply to comment #6)
> > We should add this. In contrast to the command line, where access to the
> > keyring is optional and off by default, I think in the syncevo-dbus-server it
> > should be enabled unconditionally, at least at the moment.
> Yes, the default is on for dbus server. But I think we might give an oppotunity
> to let dbus clients disable it. so behaviors of keyring in dbus-server are
> 1) if no keyring library, then ignore keyring support or raise an error?
> I prefer ignoring keyring support.
This sounds sensible.
> 2) if has keyring library, enable keyring to store passwords by default. dbus
> clients could disable it if wanted.
Why would clients have any say on this? This sounds like an implementation
detail or a system admin choice at best. Clients picking different password
stores would just lead to confusion, I think.
I guess it's understandable that clients could change this setting if the idea
is that absolutely all configuration is available via the D-Bus api, but on
it's own it sounds like solution looking for a problem. Especially Adding new
API calls definitely doesn't sound like a good idea to me.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
12 years, 9 months
[Bug 8460] New: syncevo-dbus-server crashes easily after configuring a service
by bugzilla＠moblin.org
http://bugzilla.moblin.org/show_bug.cgi?id=8460
Summary: syncevo-dbus-server crashes easily after configuring a
service
Classification: Moblin Projects
Product: SyncEvolution
Version: upstream
Platform: Netbook
OS/Version: Moblin Linux
Status: NEW
Severity: critical
Priority: Undecided
Component: GTK UI
AssignedTo: jku(a)linux.intel.com
ReportedBy: yanshuang.zheng(a)intel.com
QAContact: yanshuang.zheng(a)intel.com
CC: patrick.ohly(a)intel.com, syncevolution(a)lists.intel.com
pkg: syncevolution-0.9.2+1.0alpha1.tar.gz
After configuring a service from sync-ui, corewatcher detect
syncevo-dbus-server crash. Then we will often get corewatcher when launching
sync-ui or running sync from ui.
Steps:
1. launch sync-ui
2. configure a service and click "set and use"
3. wait about 5 seconds or launch sync-ui again
===> Application failure message 1:
Program: /usr/libexec/syncevo-dbus-server
Type: Aborted.
[New process 923]
#0 0x008fabf6 in raise () from /lib/libc.so.6
#0 0x008fabf6 in raise () from /lib/libc.so.6
#1 0x008fc908 in abort () from /lib/libc.so.6
#2 0x00ac8f4e in g_assertion_message () from /lib/libglib-2.0.so.0
#3 0x00ac9337 in g_assertion_message_expr () from /lib/libglib-2.0.so.0
#4 0x0012a4f2 in ?? () from /usr/lib/libdbus-glib-1.so.2
#5 0x0012a50b in ?? () from /usr/lib/libdbus-glib-1.so.2
#6 0x00ba648f in ?? () from /lib/libdbus-1.so.3
#7 0x00b929f0 in dbus_connection_set_watch_functions () from
/lib/libdbus-1.so.3
#8 0x0012ace0 in dbus_connection_setup_with_g_main () from
/usr/lib/libdbus-glib-1.so.2
#9 0x0012adab in dbus_g_bus_get () from /usr/lib/libdbus-glib-1.so.2
#10 0x0064006a in e_cal_new () from /usr/lib/libecal-1.2.so.7
#11 0x00640535 in e_cal_new_from_uri () from /usr/lib/libecal-1.2.so.7
#12 0x00640655 in e_cal_new_system_calendar () from /usr/lib/libecal-1.2.so.7
#13 0x080ccac3 in SyncEvo::EvolutionCalendarSource::open (this=0x8646568) at
EvolutionCalendarSource.cpp:184
#14 0x080a6d6d in ReadOperations::checkSource (this=0xbfc70d1c,
sourceName=@0xbfc70d94) at syncevo-dbus-server.cpp:1326
#15 0x080bf738 in DBusServer::checkSource (this=0xbfc710d4,
configName=@0xbfc70d98, sourceName=@0xbfc70d94) at syncevo-dbus-server.cpp:340
#16 0x080ad9b3 in boost::function2<void, std::string const&, std::string
const&>::operator() () at /usr/include/boost/function/function_template.hpp:989
#17 MakeMethodEntry<boost::function<void ()(std::string const&, std::string
const&)> >::methodFunction (conn=0x8638478, msg=0x8638928, data=0x863a760) at
./gdbus/gdbus-cxx-bridge.h:3569
#18 0x080c384a in handle_message (connection=0x8638478, message=0x8638928,
user_data=0x863a9c0) at object.c:617
#19 0x00b9ecca in ?? () from /lib/libdbus-1.so.3
#20 0x00b93b3b in dbus_connection_dispatch () from /lib/libdbus-1.so.3
#21 0x080c1e0d in queue_dispatch (source=0x8638a58, callback=0, user_data=0x0)
at mainloop.c:90
#22 0x00aac68f in g_main_context_dispatch () from /lib/libglib-2.0.so.0
#23 0x00aae63c in ?? () from /lib/libglib-2.0.so.0
#24 0x00aaf4c8 in g_main_loop_run () from /lib/libglib-2.0.so.0
#25 0x0809bae3 in DBusServer::run (this=0xbfc710d4) at
syncevo-dbus-server.cpp:2783
#26 0x080a6930 in main (argc=) at syncevo-dbus-server.cpp:2996
Application failure message 2:
Program: /usr/libexec/syncevo-dbus-server
Type: Aborted.
[New process 891]
#0 0x008fabf6 in raise () from /lib/libc.so.6
#0 0x008fabf6 in raise () from /lib/libc.so.6
#1 0x008fc908 in abort () from /lib/libc.so.6
#2 0x00ac8f4e in g_assertion_message () from /lib/libglib-2.0.so.0
#3 0x00ac9337 in g_assertion_message_expr () from /lib/libglib-2.0.so.0
#4 0x0012a4f2 in ?? () from /usr/lib/libdbus-glib-1.so.2
#5 0x0012a50b in ?? () from /usr/lib/libdbus-glib-1.so.2
#6 0x00ba648f in ?? () from /lib/libdbus-1.so.3
#7 0x00b929f0 in dbus_connection_set_watch_functions () from
/lib/libdbus-1.so.3
#8 0x0012ace0 in dbus_connection_setup_with_g_main () from
/usr/lib/libdbus-glib-1.so.2
#9 0x0012adab in dbus_g_bus_get () from /usr/lib/libdbus-glib-1.so.2
#10 0x0337e4bc in e_book_new () from /usr/lib/libebook-1.2.so.9
#11 0x0337e832 in e_book_new_from_uri () from /usr/lib/libebook-1.2.so.9
#12 0x0337e98a in e_book_new_system_addressbook () from
/usr/lib/libebook-1.2.so.9
#13 0x080c5be0 in SyncEvo::EvolutionContactSource::open (this=0xa144378) at
EvolutionContactSource.cpp:162
#14 0x080a6d6d in ReadOperations::checkSource (this=0xbfd5e93c,
sourceName=@0xbfd5e9b4) at syncevo-dbus-server.cpp:1326
#15 0x080bf738 in DBusServer::checkSource (this=0xbfd5ecf4,
configName=@0xbfd5e9b8, sourceName=@0xbfd5e9b4) at syncevo-dbus-server.cpp:340
#16 0x080ad9b3 in boost::function2<void, std::string const&, std::string
const&>::operator() () at /usr/include/boost/function/function_template.hpp:989
#17 MakeMethodEntry<boost::function<void ()(std::string const&, std::string
const&)> >::methodFunction (conn=0xa136478, msg=0xa137c90, data=0xa138760) at
./gdbus/gdbus-cxx-bridge.h:3569
#18 0x080c384a in handle_message (connection=0xa136478, message=0xa137c90,
user_data=0xa1389c0) at object.c:617
#19 0x00b9ecca in ?? () from /lib/libdbus-1.so.3
#20 0x00b93b3b in dbus_connection_dispatch () from /lib/libdbus-1.so.3
#21 0x080c1e0d in queue_dispatch (source=0xa136a58, callback=0, user_data=0x0)
at mainloop.c:90
#22 0x00aac68f in g_main_context_dispatch () from /lib/libglib-2.0.so.0
#23 0x00aae63c in ?? () from /lib/libglib-2.0.so.0
#24 0x00aaf4c8 in g_main_loop_run () from /lib/libglib-2.0.so.0
#25 0x0809bae3 in DBusServer::run (this=0xbfd5ecf4) at
syncevo-dbus-server.cpp:2783
#26 0x080a6930 in main (argc=) at syncevo-dbus-server.cpp:2996
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
12 years, 9 months