[Bug 3314] refresh-from-server: statistics for deleted items
by bugzilla@moblin.org
http://bugzilla.moblin.org/show_bug.cgi?id=3314
--- Comment #2 from pohly <patrick.ohly(a)intel.com> 2009-07-28 04:32:48 ---
(In reply to comment #0)
> When doing a refresh-from-server sync the local items are deleted by
> SyncEvolution. I think this has the effect that they don't appear in the sync
> statistics (need to check).
>
> The reason for doing the delete in SyncEvolution instead of via the Synthesis
> engine is that it allows potentially more efficient methods of deleting all
> items. On the other hand, this currently doesn't have any positive effect,
> given how the existing backends work.
>
> Perhaps it is easier to remove this special case in SyncEvolution.
It was already removed...
But the Synthesis engine contains a similar "delete all" code path and that
doesn't seem to count the deleted items:
#0 EvolutionContactSource::deleteItem (this=0xe0d510, uid=@0x7fffa9ee6710)
at
/mnt/eeepc/syncevolution/syncevolution/src/backends/evolution/EvolutionContactSource.cpp:664
#1 0x00000000005dcc5a in TrackingSyncSource::deleteItemThrow (this=0xe0d510,
item=@0x7fffa9ee6860)
at
/mnt/eeepc/syncevolution/syncevolution/src/core/TrackingSyncSource.cpp:302
#2 0x00000000005d752b in EvolutionSyncSource::processItem (this=0xe0d510,
action=0x728b24 "delete", func=&virtual
EvolutionSyncSource::deleteItemThrow(SyncItem&),
item=@0x7fffa9ee6860, needData=false) at
/mnt/eeepc/syncevolution/syncevolution/src/core/EvolutionSyncSource.cpp:546
#3 0x00000000005d7625 in EvolutionSyncSource::deleteItem (this=0xe0d510,
item=@0x7fffa9ee6860)
at
/mnt/eeepc/syncevolution/syncevolution/src/core/EvolutionSyncSource.cpp:508
#4 0x000000000055cb11 in SyncEvolution_DeleteItem (aContext=0xe0d510,
aID=0x7fffa9ee68d8)
at
/mnt/eeepc/syncevolution/syncevolution/src/core/SynthesisDBPlugin.cpp:807
#5 0x000000000068e3c5 in sysync::TDB_Api::DeleteItem (this=0xe571b8, aID={item
= 0xe897a8 "pas-id-4A6EDED400000001", parent = 0x7445b8 ""})
at
/mnt/eeepc/syncevolution/libsynthesis/src/DB_interfaces/api_db/dbapi.cpp:1993
#6 0x000000000068e3fd in sysync::TDB_Api::DeleteItem (this=0xe571b8,
aItemID=0xe897a8 "pas-id-4A6EDED400000001", aParentID=0x7445b8 "")
at
/mnt/eeepc/syncevolution/libsynthesis/src/DB_interfaces/api_db/dbapi.cpp:2002
#7 0x0000000000688063 in sysync::TPluginApiDS::apiDeleteItem (this=0xe56680,
aItem=Reading in symbols for
/mnt/eeepc/syncevolution/libsynthesis/src/sysync/multifielditem.cpp...done.
@0xe905f0) at
/mnt/eeepc/syncevolution/libsynthesis/src/DB_interfaces/api_db/pluginapids.cpp:1628
#8 0x00000000006d705f in sysync::TCustomImplDS::zapSyncSet (this=0xe56680) at
/mnt/eeepc/syncevolution/libsynthesis/src/sysync/customimplds.cpp:2998
#9 0x0000000000687a7b in sysync::TPluginApiDS::apiZapSyncSet (this=0xe56680)
at
/mnt/eeepc/syncevolution/libsynthesis/src/DB_interfaces/api_db/pluginapids.cpp:1339
Note the sysync::TPluginApiDS::apiZapSyncSet. It falls back to iterating over
all items and deleting them one-by-one.
We could optimize this by routing the Synthesis DB DeleteAllItems() call into
our own EvolutionSyncSource::removeAllItems(), but then we still wouldn't would
count the deleted items.
This would require an API change for DeleteAllItems(): instead of just a
success code, it also needs to return the number of deleted items so that the
statistics can be updated.
I think this is too intrusive right now and should be discussed with Synthesis
first. I'll send them an email. Let's keep it for 0.9.1, with no guarantees
that it really gets in there.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
11 years, 5 months
[Bug 4273] [i18n] "your SyncML server account name" should be translated in manual adding service applet
by bugzilla@moblin.org
http://bugzilla.moblin.org/show_bug.cgi?id=4273
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |FIXED
--- Comment #13 from pohly <patrick.ohly(a)intel.com> 2009-07-28 04:14:44 ---
(In reply to comment #11)
> (In reply to comment #9)
> > The string should no longer be displayed. See comment #2. I'm not sure why the
> > bug was reopened.
>
> I can still see this message by
>
> run sync-ui -> Setup sync service -> Setup and use -> there is such string in
> Username.
I see. That's a code path that wasn't covered by Jussi's earlier fix. I've
changed that code, the next update should hide the string.
Later we can properly translate it.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
11 years, 5 months
[Bug 2423] test and support Google Sync
by bugzilla@moblin.org
http://bugzilla.moblin.org/show_bug.cgi?id=2423
shuangeeer <yanshuang.zheng(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
CC| |yanshuang.zheng(a)intel.com
--- Comment #43 from shuangeeer <yanshuang.zheng(a)intel.com> 2009-07-28 02:39:36 ---
Yeah, we can load the google template and do contacts synchronization.
So verify it.
(In reply to comment #42)
> The Google config template already was in beta 3.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
11 years, 5 months
[Bug 4598] Funambol: Company phone property will lost in syncing addressbook with funambol
by bugzilla@moblin.org
http://bugzilla.moblin.org/show_bug.cgi?id=4598
--- Comment #6 from yongsheng zhu <yongsheng.zhu(a)intel.com> 2009-07-28 02:33:04 ---
> However, there are 2 remaining issues:
> 1) Funambol declares only to support vcard2.1, so parameter profile should be
> like this:
> TEL;TYPE=X-EVOLUTION-COMPANY:13523456789
> TEL;X-EVOLUTION-COMPANY:13523456789
> But it sends below to us. This causes synthesis parsing errors
> TEL;TYPE="X-EVOLUTION-COMPANY":13523456789
This issue can be fixed by a workaround easily.
> 2) If syncevolution sends a 'TEL' with 'X-EVOLUTION-COMPANY' to funambol,
> funambol doesn't process this type information correctly. So strange.
> TEL;TYPE=X-EVOLUTION-COMPANY:13523456789
> TEL;X-EVOLUTION-COMPANY:13523456789
> for these two formats, funambol ignores type information.
>
> TEL;TYPE="X-EVOLUTION-COMPANY":13523456789
> for this format, funambol ignores all information of this property. That means
> TEL value and type information are all lost. interesting.
This should be the limitation of myFunambol. For server doesn't process this
parameter, we have no choice to fix this issue.
so, IMHO, we could fix the first issue together with adding
'X-EVOLUTION-COMPANY' into the config xml file.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
11 years, 5 months
[Bug 4598] Funambol: Company phone property will lost in syncing addressbook with funambol
by bugzilla@moblin.org
http://bugzilla.moblin.org/show_bug.cgi?id=4598
--- Comment #5 from yongsheng zhu <yongsheng.zhu(a)intel.com> 2009-07-28 01:42:42 ---
Actually, 'X-EVOLUTION-COMPANY' can be generated by Evolution. It is not the
same as 'work' type in evolution and funambol. The former is interpreted as
'company phone' and the latter is interpreted as 'business phone'.
The solution of adding a enum value for TEL_FLAGS is possible. see below
<value field="TEL_FLAGS" conversion="multimix" combine=",">
<enum name="HOME" value="B0"/>
<enum name="WORK" value="B1"/>
<enum mode="ignore" value="B2"/> <!-- OTHER -->
<enum name="VOICE" value="B3"/>
...
=> <enum name="X-EVOLUTION-COMPANY" value="B13"/>
However, there are 2 remaining issues:
1) Funambol declares only to support vcard2.1, so parameter profile should be
like this:
TEL;TYPE=X-EVOLUTION-COMPANY:13523456789
TEL;X-EVOLUTION-COMPANY:13523456789
But it sends below to us. This causes synthesis parsing errors
TEL;TYPE="X-EVOLUTION-COMPANY":13523456789
2) If syncevolution sends a 'TEL' with 'X-EVOLUTION-COMPANY' to funambol,
funambol doesn't process this type information correctly. So strange.
TEL;TYPE=X-EVOLUTION-COMPANY:13523456789
TEL;X-EVOLUTION-COMPANY:13523456789
for these two formats, funambol ignores type information.
TEL;TYPE="X-EVOLUTION-COMPANY":13523456789
for this format, funambol ignores all information of this property. That means
TEL value and type information are all lost. interesting.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
11 years, 5 months
[Bug 2431] SSL certificate checking with libsoup
by bugzilla@moblin.org
http://bugzilla.moblin.org/show_bug.cgi?id=2431
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|patrick.ohly(a)intel.com |anas.nashif(a)intel.com
--- Comment #20 from pohly <patrick.ohly(a)intel.com> 2009-07-28 00:36:17 ---
(In reply to comment #19)
> Patrick has contribute the patch to fix this problem,
> http://bugzilla.gnome.org/attachment.cgi?id=139078&action=view
>
> Change owner to Patrick to decide to integrate the patch or wait for upstream
> (2.27.5) http://download.gnome.org/sources/libsoup/2.27/
>From a technical perspective, I think the patch is simple, does the right thing
for libsoup, and should be included in Moblin. Dan Winship agrees, or he
wouldn't have included the patch. But if and when this gets backported to
Moblin is a decision that must be made by the libsoup maintainers in Moblin,
not the author of the patch.
I don't know who those maintainers are - Anas, can you help and reassign as
appropriate?
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
11 years, 5 months