Comment on attachment 114929 [details] [review]
Patch to handle google calendar error 403.

Review of attachment 114929 [details] [review]:
-----------------------------------------------------------------

The commit message needs a full description of the problem and an explanation
why the chosen approach is a suitable (or at least evil) solution. Also include
an analysis of the side effects, like "what happens in future syncs".

::: src/backends/webdav/WebDAVSource.cpp
@@ +2252,5 @@
>          //
>          // req.addHeader("If-Match", etag);
> +        std::set<int> expected;
> +        if (m_contextSettings->googleUpdateHack()) {
> +            expected = boost::assign::list_of(403);

This is unnecessarily complex. Just use expected.push_back(403).