[Syncevolution-issues] [Bug 24619] dumpData + printChanges logic broken
https://bugs.meego.com/show_bug.cgi?id=24619
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|syncevolution-bugs(a)meego.bu |patrick.ohly(a)intel.com
|gs |
--- Comment #1 from pohly <patrick.ohly(a)intel.com> 2012-01-09 17:36:39 UTC ---
Fix for master branch (still to be tested in the nightly test run):
commit d5830efbd7761e2d2d01ba9ab2a30eefaeb91a46
Author: Patrick Ohly <patrick.ohly(a)intel.com>
Date: Mon Jan 9 18:33:39 2012 +0100
sync logic: dumpData + printChanges logic was broken (BMC #24619)
The logic for dumpData and printChanges wasn't implemented correctly.
- run sync with dumpData=0 printChanges=0 => writes database dumps
("before/after" in logdir) although it shouldn't
- run status check (--status) with dumpData=1 printChanges=0 => dumps and
prints changes although it should do neither
The fix is to check the "print changes" setting in addition to (and
not instead of) m_doLogging. m_doLogging is merely an override used in
testing. If false, then the logdir handling and thus data dumps are
disabled.
For --status only check printChanges. This used to print changes and
thus dump data when either dumpData or printChanges were set. It makes
more sense to only produce the output when exactly that is asked for.
--------
Product: SyncEvolution
Component: SyncEvolution
MeeGo Release: unspecified
Severity: normal
Priority: Undecided
Keywords:
Status: ASSIGNED
Who: patrick.ohly(a)intel.com
Assigned To: patrick.ohly(a)intel.com
Target Build: ---
Flags:
Changed: Status AssignedTo
--------
https://bugs.meego.com/show_bug.cgi?id=24619
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.