[Syncevolution-issues] [Bug 6376] sync-ui + D-Bus server: implement interactive password requests
http://bugzilla.moblin.org/show_bug.cgi?id=6376
--- Comment #10 from pohly <patrick.ohly(a)intel.com> 2009-12-17 00:10:21 PST ---
(In reply to comment #9)
After reviewing the code, I have a concern. In my opinion, when doing
sync, the
events from dbus clients dispatched mostly are depending on m_agent->wait() in
the SyncContext->doSync(), which is, of course, an implicit side-affect.
That's true, but...
I'm
afraid that we should give a regular callback provided by cmdline or dbus
server and call them regularly in our Sync main loop.
... the alternative would require regular polling, which either drains power
(when using no delays) or introduces latencies (when using a large delay
between checking).
I'd prefer to keep the "block in g_main_loop_run()" approach working as much
as
possible.
BTW, after discussion with Congwu, we found a potential issue for
glib main
loop on transporting agents.
If aborting happens by dbus clients, obex transporting agent has to wait for at
least one response of obexd and then aborting will be handled but for http
agent, it would be handled without this kind of blocking.
"obex transporting agent" = DBusTransportAgent? There is a "TODO: setup
regular
callback" in DBusTransportAgent::wait() about that - not filed in Bugzilla yet,
though.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.