[Syncevolution-issues] [Bug 5753] New: nightly testing: double testing of Client::Source?

http://bugs.meego.com/show_bug.cgi?id=5753 Summary: nightly testing: double testing of Client::Source? Classification: MeeGo Projects Product: SyncEvolution Version: unspecified Platform: All Architecture: --- Status: NEW Severity: major Priority: High Component: SyncEvolution AssignedTo: yongsheng.zhu(a)intel.com ReportedBy: patrick.ohly(a)intel.com QAContact: jingke.zhang(a)intel.com CC: syncevolution-bugs(a)meego.bugs, syncevolution-default-bugs(a)meego.bugs Estimated Hours: 0.0 It seems that invoking Client::Source without CLIENT_TEST_SOURCES invokes certain tests multiple times. See for example: http://runtests.syncevolution.org/2010-08-23-21-41/head-evolution-testing... Client::Source::ical20::testOpen is done multiple times. This did not show up in the HTML summary as long as all instances of the tests succeeded and therefore wasn't noticed. I noticed it after updating Debian testing to use Evolution 2.30. Suddenly the second run of Client::Source::ical20 fails: http://runtests.syncevolution.org/2010-08-25-00-08/head-evolution-testing... I suspect that Congwu broke this end of last year when adding some code for testing virtual sources: client-test-app.cpp: /* Local Test SyncSource : remove all virtual datastores, inserting the * sub datastores*/ ClientTest::Config conf; BOOST_FOREACH (string source, sources) { getSourceConfig (source, conf); if (conf.subConfigs) { vector<string> subs; boost::split (subs, conf.subConfigs, boost::is_any_of(",")); BOOST_FOREACH (string sub, subs) { m_localSource2Config.push_back (sub); } } else { m_localSource2Config.push_back (source); } } I do not fully understand what he is doing here. Perhaps that patch simply needs to be reverted. Yongsheng, can you tackle this problem? Also of interest is why the second run with these tests fails. -- Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching someone on the CC list of the bug.