Priority medium
Bug ID 72576
Summary src/dbus/server/server.cpp:495: possible bad if test ?
Severity normal
Classification Unclassified
OS All
Hardware All
Status NEW
Component SyncEvolution
Product SyncEvolution

I just ran the static analyser over syncevolution-

It said many things, including

[src/dbus/server/server.cpp:495] -> [src/dbus/server/server.cpp:495]: (style)
Same expression on both sides of '<='.

Source code is

       if (session && session->getPriority() <= session->getPriority()) {

Suggest code rework. I notice there is a parameter of the routine
called session and a local variable with the same name. Odd.

I also checked the newest source code and the bug appears there too.

You are receiving this mail because: