10:36 a.m.
http://bugzilla.moblin.org/show_bug.cgi?id=6378
--- Comment #28 from pohly <patrick.ohly(a)intel.com> 2010-02-26 02:36:00 PST ---
I propose the following language improvements for the new config options:
"autoSync"
Controls automatic synchronization. Currently,
automatic synchronization is done by running
a synchronization at regular intervals. This
may drain the battery, in particular when
using Bluetooth!
Because a peer might be reachable via different
transports at some point, this option provides
detailed control over which transports may
be used for automatic synchronization:
0 - don't do auto sync
1 - do automatic sync, using whatever transport
is available
http - only via HTTP transport
obex-bt - only via Bluetooth transport
http,obex-bt - pick one of these
"autoSyncInterval"
This is the minimum number of minutes between two
synchronizations that has to pass before starting
an automatic synchronization.
Before reducing this interval, consider that it will
increase resource consumption on the local and remote
side. Some SyncML server operators only allow a
certain number of sessions per day.
The value 0 has the effect of only running automatic
synchronization when changes are detected (not
implemented yet, therefore it basically disables
automatic synchronization).
"autoSyncDelay" (change of name!)
An automatic sync will not be started unless the peer
has been available for this number of minutes. This
prevents running a sync when network connectivity
is unreliable or was recently established for some
other purpose. It is also a heuristic that attempts
to predict how long connectivity be available in the
future, because it should better be available long
enough to complete the synchronization.
Comments on the patch:
+ /** the 'syncURL' used by synchronization */
+ string m_url;
Wouldn't it be easier to use the vector<string> returned by getSyncURL()? Then
you don't have to do your own parsing. Or is this not a copy of the complete
"syncURL" property, as the comment implies?
+#ifdef HAVE_EDS
+ /**
+ * Listen changes from evolution-data-server
+ */
+ class EDSListener
...
Doesn't belong into the second patch.
+ /** a map to contain all auto sync tasks. All initialized tasks are stored
here */
+ typedef std::map<unsigned int, boost::shared_ptr<AutoSyncTaskList> >
PeerMap;
+ PeerMap m_peerMap;
It is still not clear what the "unsigned int" key in this map is. The
autoSyncInterval?
+ // TODO: add 'lastSyncTime' property and check time when server starts
I don't think we need this, assuming that we start counting time since last
sync at zero when starting the server.
DBusServer: add notification for auto sync (MB#6378)
We cannot call libnotify directly from syncevo-dbus-server, not unless we start
localizing user visible strings like the "SyncEvolution: automatic
synchronization for '%s' has been done." here.
Jussi, does the autoSync option as described above work for the sync-ui?
Do you know how we should handle notifications in Moblin?
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.