[Syncevolution-issues] [MeeGo Projects - Bug 10453] patch for libnotify 0.7
http://bugs.meego.com/show_bug.cgi?id=10453
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |patrick.ohly(a)intel.com
Resolution| |FIXED
--- Comment #3 from pohly <patrick.ohly(a)intel.com> 2010-12-06 02:15:53 PST ---
(In reply to comment #0)
this probably won't be accepted yet but Fedora process requires
me to upstream
it. syncevolution doesn't build against libnotify 0.7 because of a small API
change - one parameter is gone from notify_notification_new .
Thanks for the advance warning.
the patch is
attached. obviously, anything still shipping libnotify <= 0.7 is not going to
want this patch. it could probably be made more sophisticated, to detect the
libnotify version that's being built against and use the appropriate number of
parameters, but that's beyond my scope.
It sure would have been nice if the people introducing the API change had been
a bit more pro-active about suggesting a suitable way of dealing with the
issue. Googling for it I found all kinds of solutions that people came up with.
Does the one below work? I have no (easy) way of checking it with libnotify
0.7, but will include it anyway in the syncevolution-1-1-branch.
diff --git a/src/syncevo-dbus-server.cpp b/src/syncevo-dbus-server.cpp
index 7ecb9f0..d32a2d3 100644
--- a/src/syncevo-dbus-server.cpp
+++ b/src/syncevo-dbus-server.cpp
@@ -6108,7 +6108,11 @@ void AutoSyncManager::Notification::send(const char
*summary,
notify_notification_clear_actions(m_notification);
notify_notification_close(m_notification, NULL);
}
+#if !defined(NOTIFY_CHECK_VERSION)
m_notification = notify_notification_new(summary, body, NULL, NULL);
+#else // NOTIFY_CHECK_VERSION(0,7,0) is redundant, because 0.7.0 introduced
NOTIFY_CHECK_VERSION
+ m_notification = notify_notification_new(summary, body, NULL);
+#endif
//if actions are not supported, don't add actions
//An example is Ubuntu Notify OSD. It uses an alert box
//instead of a bubble when a notification is appended with actions.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.