--- Comment #13 from pohly <patrick.ohly(a)intel.com> 2010-09-16 01:10:27 PDT ---
(In reply to comment #12)
Updated dbus-testing branch.
(In reply to comment #7)
> I disagree. I want the testing to cover the bits and bytes that we ship, not
> something else, *in particular* if it gets compiled with different configure
> options. Different options always come with the risk of hiding bugs that occur
> with the ones used for release.
We don't need to get source code and compile it for dbus-testing, just use the
same as client-testing. Right?
Yes, but more precisely, dbus-testing should use the binaries built as part of
the head-evolution-hardy-2.22.1-amd64/ia32 environments, because those are the
binaries that we release.
By now, dbus-testing and client-testing scripts
have some differences in build path, install path, result path. Do we need to
align dbus-testing with client-testing?
Another approach is that we can build client-testing and
separately with the same configure options.
That would just duplicate the work of compiling the source code. It also does
not catch the (unlikely) situation of a cosmic ray toggling a bit in the
binaries that we release, breaking the syncevo-dbus-server in that release.
> Regarding the keyring, how about this: make the usage of the
> configurable via ~/.config/syncevolution/config.ini (similar to the "current
> config" setting), turn the "--keyring" parameter into an alias for
> property (similar to "--sync"). Then turn off the keyring in the chroot.
A new property "GnomeKeyring" has been added to enable or disable gnomekeyring
at runtime. Help to review code in dbus-testing branch.
Let's not make this specific to GNOME. We might have a similar situation with
KDE Wallet soon. Here's what I would like to see implemented:
property name: "keyring"
sharing: setSharing(ConfigProperty::GLOBAL_SHARING), just like "default peer"
value: several options: yes/on/1, no/off/0, GNOME (case insensitive)
command line: --keyring[=xxx] as alias for --sync-property keyring=xxx (like
--sync, with --keyring equal to --sync-property keyring=on)
default for keyring=yes: GNOME, can be made more intelligent later on
Check that "client-test SyncEvolution" (configure --enable-integration-tests)
still works. It tests configuration layout pretty thoroughly.
Also, please split your patch into independent pieces. One patch should add the
new property and have BMC #6368 in the summary, the other the changes for D-Bus
testing with BMC #5609.
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.