[Syncevolution-issues] [Bug 72576] src/dbus/server/server.cpp:495: possible bad if test ?

https://bugs.freedesktop.org/show_bug.cgi?id=72576 Patrick Ohly <patrick.ohly(a)gmx.de&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|syncevolution-issues@syncev |patrick.ohly(a)gmx.de |olution.org | --- Comment #1 from Patrick Ohly <patrick.ohly(a)gmx.de&gt; --- Which code analyzer found that? I run Klocwork occasionally and analyzed all problems in SyncEvolution code itself that Klocwork reported. In libsynthesis the code triggered more warnings. The false negative rate was higher than in SyncEvolution due to the different coding style, so I only checked some issues there. Anyway, I don't remember this one. The code is the result of an invalid rewrite: - if (it->lock()->getPriority() <= session->getPriority()) { + // skip over dead sessions, they will get cleaned up elsewhere + boost::shared_ptr<Session> session = it->lock(); + if (session && session->getPriority() <= session->getPriority()) { The session variable here shadows the session parameter, which clearly isn't right. It's not that important, though, because session priorities aren't used much (not at all?). I'll fix it. Thanks for reporting this. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.