[Syncevolution-issues] [Bug 7089] pairing with Bluetooth devices

http://bugzilla.moblin.org/show_bug.cgi?id=7089 pohly <patrick.ohly(a)intel.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #37 from pohly <patrick.ohly(a)intel.com&gt; 2010-02-04 05:34:24 PST --- (In reply to comment #36) I think this is reasonable. A configure check for it would have been nice, but isn't essential. Agreed, but I guess it is the best that we can do. The D-Bus service file has a similar problem. I merged the code, but pretty much rewrote the autotools integration. Let me explain: - src/gnome-bluetooth must be included in DIST_SUBDIRS, otherwise it won't be included in "make dist" when GNOME Bluetooth panel support is off. This was redundant, because the Makefile itself also checked whether the plugin is active (which is the better solution). - Splitting out the configure fragment into src/gnome-bluetooth did not work when "make" rebuilds the autotools stuff. Getting this right for backends required extra work which we shouldn't do unless we have to. Moved the checks into the main configure-pre.in. - "GNOME Bluetooth" is the right spelling, not all lower case. - The help text didn't mention what the default is. I agree that it should be off by default, because it always installs into /usr. - The summary of optional features didn't mention the plugin. - --enable-btpairing is too unspecific. What if we have multiple such plugins? I changed it into --enable-gnome-bluetooth-panel. - READMEs were not updated. - src/gnome-bluetooth/syncevolution.c must be mentioned in po/POTFILES.in because it contains translations. Yes, I know this is complicated. I wish it wasn't :-/ -- Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching someone on the CC list of the bug.