11:16 p.m.
http://bugs.meego.com/show_bug.cgi?id=11241
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |WAITING FOR UPSTREAM
URL| |http://bugs.meego.com/show_
| |bug.cgi?id=11233
Depends on|11233 |
AssignedTo|syncevolution-bugs(a)meego.bu |patrick.ohly(a)intel.com
|gs |
Target Milestone|--- |1.1.1
--- Comment #2 from pohly <patrick.ohly(a)intel.com> 2010-12-13 04:16:29 PST ---
I have a patch for libsynthesis:
commit 400b471a43d02dbcdf2c6affdde7ac1b1d7171a8
Author: Patrick Ohly <patrick.ohly(a)intel.com>
Date: Mon Dec 13 13:08:40 2010 +0100
vCalendar 1.0: avoid RRULE end date without time
When parsing an iCalendar 2.0 event, it is possible to arrive at
an rrule "until" date/time which contains no time value. vCalendar 1.0
requires such a time. Not sending it, as the engine did before, causes
Nokia phones to ignore the recurrence rule (bugs.meego.com #11241).
This patch avoids this case by looking at the time of the event start
and adds that time to the recurrence until date. The comment in the
default config says:
<!-- recurrence rule block, fields must be in that order, including
DTSTART as last field !! -->
But it doesn't seem like DTSTART was really used before. Therefore this
patch tries to deal with not finding a timestamp after the recurrence rule
block by clearing the TCTX_DATEONLY, without actually setting a time.
Probably
not quite correct, but perhaps better than not changing anything.
Another problematic aspect is to match the time zone context of the
"until" clause with the "start" date/time of the event. Currently
the patch
assumes that the start time is going to be encoded as UTC.
For an event in German time zone:
BEGIN:VCALENDAR
VERSION:1.0
TZ:+01:00
DAYLIGHT;ENCODING=QUOTED-PRINTABLE:TRUE;+02;20110327T010000Z;20111=
030T010000Z;CET;CEST
BEGIN:VEVENT
LAST-MODIFIED:20101213T120136Z
CLASS:PRIVATE
PRIORITY:2
SUMMARY:Phone mod
DESCRIPTION:Phone
DTSTART:20101212T090000Z
RRULE:D1 20101231T090000Z
DTEND:20101212T090000Z
END:VEVENT
END:VCALENDAR
In UTC:
BEGIN:VCALENDAR
VERSION:1.0
TZ:+00:00
DAYLIGHT:FALSE
BEGIN:VEVENT
LAST-MODIFIED:20101213T120600Z
CLASS:PRIVATE
PRIORITY:2
SUMMARY:Phone mod
DESCRIPTION:Phone
DTSTART:20101212T100000Z
RRULE:D1 20101231T100000Z
DTEND:20101212T100000Z
END:VEVENT
END:VCALENDAR
Further work might be needed when talking to a phone which does not support
UTC. Currently the code which composes the modified end date is hard-coded to
UTC time context.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.