Comment # 9 on bug 86824 from
(In reply to Patrick Ohly from comment #8)
> Comment on attachment 110787 [details] [review] [review]
> Pass the AgAuthData to the SignonAuthProvider
> 
> Review of attachment 110787 [details] [review] [review]:
> -----------------------------------------------------------------
> 
> ::: src/backends/signon/signon-accounts.cpp
> @@ +96,2 @@
> >          }
> > +        GVariant *extraOptions = g_variant_builder_end(&builder);
> 
> Who ensures that the created GVariant gets freed?
> 
> I suspect that this needs to be:
> GVarianteCXX extraOptions(g_variant_take_ref(g_variant_build_end(&builder)),
> TRANSFER_REF);

There are two such constructs in the code.


You are receiving this mail because: