[Syncevolution-issues] [Bug 19394] CalDAV sync with syncevo-dbus-server will hang if keyring is used
https://bugs.meego.com/show_bug.cgi?id=19394
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #3 from pohly <patrick.ohly(a)intel.com> 2011-06-17 13:29:55 UTC ---
commit 792d6bc99adb59093dec8d67ffad63977e1de9ce
Author: Patrick Ohly <patrick.ohly(a)intel.com>
Date: Thu Jun 16 15:32:22 2011 +0200
local sync: fixed password handling
There still was a TODO in the code for handling "-" as password value.
No surprise, not having that implemented broke CalDAV sync in
syncevo-dbus-server because it would try to read the password from
stdin (the default in SyncContext).
Probably SyncContext shouldn't provide such an unsafe fallback, but
that's something for another patch.
This patch addresses the immediate problem by moving the
initialization of the SyncContext used by the child process into the
master process and adding the password checking directly afterwards
(LocalTransportAgent::start()). It runs in the main process
(syncevolution or syncevo-dbus-server) and uses the "request password"
method of the main sync context. Passwords are then stored
temporarily, so the same check doesn't have to ask for passwords again
in the child process.
Long term we'll need to rewrite the complete password handling...
--------
Product: SyncEvolution
Component: SyncEvolution
MeeGo Release: unspecified
Severity: critical
Priority: High
Keywords:
Status: RESOLVED
Who: patrick.ohly(a)intel.com
Assigned To: patrick.ohly(a)intel.com
Target Build: 1.2
Flags:
Changed: Status Resolution
--------
https://bugs.meego.com/show_bug.cgi?id=19394
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.