Comment # 2 on bug 83396 from
Comment on attachment 105605 [details] [review]
Proposed patch

Instead of copying GVariantCXX from signon.cpp, move it and related helper
functions into a new src/syncevo/GVariant.[h|cpp] pair.

Feel free to remove the commented code in src/syncevo/SyncConfig.cpp.

Instead of repeating the boost::function<void (const std::string &newPassword)>
type, better add a typedef for it in IdentityProvider.h.

Last but not least, please add a src/backends/oauth2/README describing how to
use the new provider. Of particular interest to users will be how they can
extract the necessary refresh token from gSSO and GNOME Online Accounts.


You are receiving this mail because: