[Syncevolution-issues] [Bug 6500] [Neg] Invalid RetryInterval leads to never retry
http://bugzilla.moblin.org/show_bug.cgi?id=6500
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #1 from pohly <patrick.ohly(a)intel.com> 2009-10-05 09:11:48 ---
commit 0d9f0efe98f200a5cef3bc0d64c39659d39f0c3d
Author: Patrick Ohly <patrick.ohly(a)intel.com>
Date: Mon Oct 5 18:06:13 2009 +0200
RetryInterval/Delay: only accept unsigned integers (MB #6500)
Negative values silently disabled message resending. This was
not documented and thus unexpected, so trigger an error for
this kind of values now (using the new type checking for
integer values).
To disable the feature users would have to use very large
integer numbers (not documented, but kind of obvious I hope).
commit c094b76659284d4554fceaac734e975c108762cc
Author: Patrick Ohly <patrick.ohly(a)intel.com>
Date: Mon Oct 5 18:00:38 2009 +0200
config value checking: be more strict for integer values
The old check used istringstream >> type as check, which
happened to accept invalid input like -1 for an unsigned
type. Now strol() strtoul() are used to do the conversion,
with the full range of error checking possible with those
functions:
for unsigned: "-1" => range error
for int: "10000000000" => range error
"", "x" => decimal value expected
"10x" => unexpected trailing non-whitespace characters: x
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.