http://bugzilla.moblin.org/show_bug.cgi?id=6181 --- Comment #2 from Chen Congwu <congwu.chen(a)intel.com&gt; 2009-09-17 00:09:05 --- Without splitting the library into the api and implementation part, maybe we can distribute only api related header files; other header files (CurlTransport Impl, SoupTransport Impl, ObexTransportImpl, EvolutionSyncClient, SynthesisEngine related). This reduces the dependency as well as keep it clean. If we later decides to distribute more functionality,change the make rule to distribute more corresponding library headers. Is is useful? -- Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching someone on the CC list of the bug.

http://bugzilla.moblin.org/show_bug.cgi?id=6181 pohly <patrick.ohly(a)intel.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.ohly(a)intel.com --- Comment #4 from pohly <patrick.ohly(a)intel.com&gt; 2009-09-17 04:42:37 --- (In reply to comment #0) Which add-ons is important, because it determines the public API and helps us decide question like "do users of the library need to know whether we support and/or use glib". IMHO this is the only use case that we need to support, at least at the moment. UI developers should either use the D-Bus API (generic SyncEvolution in Moblin and normal Linux desktops) or compile their own SyncEvolution binary (Mac OS X, phone, Palm?). In the later case, they have full control over the compilation and can enable and disable features as needed. (In reply to comment #1) The library user must not make any assumptions beyond what is documented in the API. If glib usage of the core engine is neither visible in the API (datatypes, struct members) nor documented (with a comment that describes some internal implementation detail), then it doesn't matter whether libsyncevolution.so was compiled with or without glib support. [finding backends] Looks good. Please add it to the recommended options in the HACKING document. Also beware of the typo: it should be --enable-maintenance-mode. I always have trouble spelling that word. Perhaps better use --enable-developer-mode? (In reply to comment #3) Exactly. Perfect. The problem will be to ensure that these headers remain self-contained and meet some quality requirements: with just the CFLAGS from syncevolution.pc (-I<syncevo include dir>) and synthesis.pc (-I<synthesis include dir>) on the command line, can g++ parse every header file? I really mean invoking it once on each file separately. A common bug is to not include relevant header files, which is not found when some other header file included them first. Then we have namespace issues (bug #3472). I wonder whether we can integrate checks for these kind of issues into "make distcheck". -- Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching someone on the CC list of the bug.

http://bugzilla.moblin.org/show_bug.cgi?id=6181 --- Comment #6 from Chen Congwu <congwu.chen(a)intel.com&gt; 2009-09-22 00:07:00 --- Now we still have dependency on synthesisSDK and boost. Both have effect on the size of the SyncSource/TrackingSyncSource base class, which we cannot simply bypass. The SyncSourceLogging also has dependency over synthesis SDK. So the pc file includes dependencies: synthesis and libboost. I noticed syncevolution did not use pkgconfig to check boost library but use a m4 macro, does this have impact on libsyncevo? -- Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching someone on the CC list of the bug.

http://bugzilla.moblin.org/show_bug.cgi?id=6181 --- Comment #8 from Chen Congwu <congwu.chen(a)intel.com&gt; 2009-09-22 18:54:24 --- (In reply to comment #7) Ah, done. The only dependency is synthesis which I think is quite reasonable. Regarding the portable client-test, I am thinking it works anyway. There is no additional dependencies if the backend user decides to register their own test case. Currently backend implementations has a requirement on test.h which provides the skip test feature. Patrick, maybe you can have a review now. -- Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching someone on the CC list of the bug.

http://bugzilla.moblin.org/show_bug.cgi?id=6181 --- Comment #10 from pohly <patrick.ohly(a)intel.com&gt; 2009-09-24 08:00:04 --- I made two changes and committed them to master. Please review and let me know whether you agree with them: commit c2e01886a2c56903f0562a3ec3a311a750a79260 Author: Patrick Ohly <patrick.ohly(a)intel.com&gt; Date: Thu Sep 24 16:54:48 2009 +0200 libsyncevolution.so installation: must go into libdir libsyncevolution.so is now a first-class system library and therefore should be installed in the normal libdir. This is also where it was expected by syncevolution.pc. commit e7d1fa3cdbc1f30e6981c9f854ea00ef4d4ff551 Author: Patrick Ohly <patrick.ohly(a)intel.com&gt; Date: Thu Sep 24 16:52:57 2009 +0200 --enable-developer-mode: use absolute search path for backends The path compiled into libsyncevolution.so when developer mode was active was "backends/", so backends were only found when running SyncEvolution inside that directory. This is a bit too limiting. Now the absolute path is compiled in. -- Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching someone on the CC list of the bug.

http://bugzilla.moblin.org/show_bug.cgi?id=6181 --- Comment #12 from pohly <patrick.ohly(a)intel.com&gt; 2009-09-24 23:25:35 --- (In reply to comment #11) Pushed now. Merged. I fixed one minor issue in ReadDir: if throwError=false and an error occurred, closedir() would have been called twice. - if(throwError) { + if (throwError) { throw; + } else { + return; } -- Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching someone on the CC list of the bug.

http://bugzilla.moblin.org/show_bug.cgi?id=6181 pohly <patrick.ohly(a)intel.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |INTEGRATED --- Comment #14 from pohly <patrick.ohly(a)intel.com&gt; 2009-10-07 13:38:03 --- Integrated into Moblin 2.1 as 0.99.0.99.3 aka 0.9 beta 1. -- Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching someone on the CC list of the bug.