http://bugs.meego.com/show_bug.cgi?id=1007
--- Comment #16 from yongsheng <yongsheng.zhu(a)intel.com> 2010-05-27 01:00:21 PDT
---
(In reply to comment #15)
(In reply to comment #13)
> > No, GetTZInfo() gets dBias as reference and initializes it. It seems that you
> > have found a case where it returns "true" without initializing dBias.
That case
> > needs to be fixed inside GetTZInfo(), it should return false if it cannot find
> > dBias.
> correct, you're right. Is it possible to assign 'dBias' as a default
value
> (such as '0') in the beginning of 'GetTZInfo'?
That depends - is 0 the right answer for the case where GetTZInfo() currently
returns true without setting dBias? It might be that returning false is the
better solution.
Patrick, it's because your newly committed code causes this
problem, so I think
you could help identify my change:
In synthesis code commit 58f19738bdde67f2a216f4a817deb6a35f731d52,
249 static bool GetTZInfo( cAppCharP aText,
250 cAppCharP aIdent,
251 tChange &c,
252 short &cBias,
253 string &cName,
254 sInt32 aNth, // take nth occurance, -1: take
last
255 TDebugLogger* aLogP )
256 {
+
+ a= VStr( aText, aIdent, aNth );
+ if ( a.empty() ) {
+ // Happens for VTIMEZONEs without summer saving time when this
+ // function is called to extract changes for DAYLIGHT. Don't
+ // treat this as failure and continue with clean change rules, as
+ // before.
+ c = tChange();
+ return success;
+ }
+
when returning 'success' here, cBias isn't set. So my patch is to set
'cBias'
as 0 here. Is it correct?
--
Configure bugmail:
http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.