2:37 a.m.
http://bugzilla.moblin.org/show_bug.cgi?id=7707
Summary: revised configuration layout: multiple peers per
config
Classification: Moblin Projects
Product: SyncEvolution
Version: upstream
Platform: Netbook
OS/Version: Moblin Linux
Status: ASSIGNED
Severity: normal
Priority: P1
Component: *Feature Request
AssignedTo: patrick.ohly(a)intel.com
ReportedBy: patrick.ohly(a)intel.com
CC: syncevolution(a)lists.intel.com
Multiple peers should be able to share the same set of local data sources. The
current scheme has the following disadvantages:
* Settings for sources and logging are duplicated and might become
intentionally or unintentionally inconsistent between peers.
* Finding all old sessions involving a certain local data source is hard: one
has to check multiple different peer configurations and cannot be sure that
source "addressbook" of peer A really is the same "addressbook" as in
peer B.
* When we are contacted for the first time by a peer, it is unclear which local
source and logging configuration we are supposed to use.
The intention is to replace the current scheme with the following layout:
.config/syncevolution/
config.ini global sync properties
default/
config.ini source set config
.synthesis shared (!) Synthesis binfiles
sources/
addressbook|calendar|.../
config.ini source config
peers/
scheduleworld/
config.ini peer configuration
sources/
addressbook|calendar|.../
config.ini per peer source config
.other.ini per peer and per source storage for backend
phone_xyz/
...
alternate/
.... a complete set of configuration files as above
See http://syncevolution.org/development/configuration-handling for details.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
2:38 a.m.
New subject: [Bug 7707] revised configuration layout: multiple peers per config
http://bugzilla.moblin.org/show_bug.cgi?id=7707
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |7214
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
2:39 a.m.
New subject: [Bug 7707] revised configuration layout: multiple peers per config
http://bugzilla.moblin.org/show_bug.cgi?id=7707
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |7708
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
2:56 a.m.
New subject: [Bug 7707] revised configuration layout: multiple peers per config
http://bugzilla.moblin.org/show_bug.cgi?id=7707
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |7710
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
11:39 p.m.
New subject: [Bug 7707] revised configuration layout: multiple peers per config
http://bugzilla.moblin.org/show_bug.cgi?id=7707
--- Comment #1 from pohly <patrick.ohly(a)intel.com> 2009-11-06 04:39:40 ---
At the moment, when SyncContext is instantiated with "", writes of properties
go into ~/.config/syncevolution/config.ini|.internal.ini. One example is the
(unintentional!) writing of admin data and remoteDeviceID in
SyncContext::analyzeSyncMLMessage.
The "view" should prevent or suppress writing of properties which don't
exist
in the view. TBD.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
7:22 a.m.
New subject: [Bug 7707] revised configuration layout: multiple peers per config
http://bugzilla.moblin.org/show_bug.cgi?id=7707
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |8049
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
7:23 a.m.
New subject: [Bug 7707] revised configuration layout: multiple peers per config
http://bugzilla.moblin.org/show_bug.cgi?id=7707
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |8048
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
2:37 a.m.
New subject: [Bug 7707] revised configuration layout: multiple peers per config
http://bugzilla.moblin.org/show_bug.cgi?id=7707
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |8059
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
5:55 a.m.
New subject: [Bug 7707] revised configuration layout: multiple peers per config
http://bugzilla.moblin.org/show_bug.cgi?id=7707
--- Comment #2 from pohly <patrick.ohly(a)intel.com> 2009-11-17 10:55:35 PST ---
(In reply to comment #1)
At the moment, when SyncContext is instantiated with "",
writes of properties
go into ~/.config/syncevolution/config.ini|.internal.ini. One example is the
(unintentional!) writing of admin data and remoteDeviceID in
SyncContext::analyzeSyncMLMessage.
The problem above is solved in the "server-config" branch by not instantiating
that SyncContext with access to file config nodes.
The "view" should prevent or suppress writing of properties
which don't exist
in the view.
This is also done, via DevNullConfigNode for non-existant parts of the view.
Overall the code in the "server-config" branch implements enough of this
feature to be useful. Let's review and merge.
The missing aspect is automatic migration of old configs.
In addition, several new issues were created which should be resolved once this
code gets merged, see the list of blocked issues.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
12:58 a.m.
New subject: [Bug 7707] revised configuration layout: multiple peers per config
http://bugzilla.moblin.org/show_bug.cgi?id=7707
--- Comment #3 from pohly <patrick.ohly(a)intel.com> 2009-11-19 05:58:16 PST ---
(In reply to comment #2)
The missing aspect is automatic migration of old configs.
And populating templates with existing properties when adding peers. This one
is actually more important.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
4:29 p.m.
New subject: [Bug 7707] revised configuration layout: multiple peers per config
http://bugzilla.moblin.org/show_bug.cgi?id=7707
yongsheng zhu <yongsheng.zhu(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |yongsheng.zhu(a)intel.com
--- Comment #4 from yongsheng zhu <yongsheng.zhu(a)intel.com> 2009-11-22 21:29:27 PST
---
Comments:
1. In the commit message of 'config: reorganized for shared config layout
(MB#7707)', there is a typo(./config).
"~/.config/syncevolution" instead of
"./config/syncevolution/scheduleworld") and then config files include
2. A suggestion:
new FileConfigTree(templateConfig, "", false)
there are many places using above statement, default parameter values might be
applied
3. I don't find any place in dbus API document to declare what 'configuration
name is empty' means.
Questions:
1. what's the difference between {"" : {}} and {}?
2. If, the empty configuration name means 'all peers', I don't quite
understand
CheckSource() and GetDatabases() behaviors. Use default config?
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
6:44 p.m.
New subject: [Bug 7707] revised configuration layout: multiple peers per config
http://bugzilla.moblin.org/show_bug.cgi?id=7707
--- Comment #5 from pohly <patrick.ohly(a)intel.com> 2009-11-22 23:44:58 PST ---
(In reply to comment #4)
Comments:
1. In the commit message of 'config: reorganized for shared config layout
(MB#7707)', there is a typo(./config).
"~/.config/syncevolution" instead of
"./config/syncevolution/scheduleworld") and then config files include
Ack.
2. A suggestion:
new FileConfigTree(templateConfig, "", false)
there are many places using above statement, default parameter values might be
applied
Okay.
3. I don't find any place in dbus API document to declare what
'configuration
name is empty' means.
Questions:
1. what's the difference between {"" : {}} and {}?
The first one is a config with no sources configured and no sync properties.
But it is not completely empty, at least the node for sync properties exists.
2. If, the empty configuration name means 'all peers', I
don't quite understand
CheckSource() and GetDatabases() behaviors. Use default config?
"empty configuration name" doesn't mean "all peers". It means
"ignore peers and
use only the peer-independent properties". Local database access and source
nodes are independent of peers, therefore the two calls above can be executed
without having any peer selected and/or configured.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
9:25 p.m.
New subject: [Bug 7707] revised configuration layout: multiple peers per config
http://bugzilla.moblin.org/show_bug.cgi?id=7707
--- Comment #6 from pohly <patrick.ohly(a)intel.com> 2009-11-23 02:25:35 PST ---
(In reply to comment #5)
(In reply to comment #4)
> Comments:
> 1. In the commit message of 'config: reorganized for shared config layout
> (MB#7707)', there is a typo(./config).
> "~/.config/syncevolution" instead of
> "./config/syncevolution/scheduleworld") and then config files include
Ack.
I thought I had found the place that you meant, but I'm no longer sure:
void SyncConfig::addPeers(const string &root,
const std::string &configname,
SyncConfig::ServerList &res) {
FileConfigTree tree(root, "", false);
list<string> servers = tree.getChildren("");
BOOST_FOREACH(const string &server, servers) {
// sanity check: only list server directories which actually
// contain a configuration. To distinguish between a context
// (~/.config/syncevolution/default) and an HTTP server config
// (~/.config/syncevolution/scheduleworld), we check for the
// "peer" subdirectory that is only in the former.
These paths are correct.
Can you clarify which code you mean?
> 2. A suggestion:
> new FileConfigTree(templateConfig, "", false)
> there are many places using above statement, default parameter values might be
> applied
Okay.
I only found two places:
$ grep -r -i "FileConfigTree(" src
...
src/syncevo/SyncConfig.cpp: boost::shared_ptr<FileConfigTree> tree(new
FileConfigTree(templateConfig, "", false));
src/syncevo/VolatileConfigTree.h: FileConfigTree("/dev/null", "",
false)
Did I miss other places?
The reason for not making the new parameters default values was to catch code
which hadn't been adapted to the new semantic of FileConfigTree (root is one
level up, paths have to be longer to match the same nodes). I still think this
is worthwhile.
> 3. I don't find any place in dbus API document to declare
what 'configuration
> name is empty' means.
>
> Questions:
> 1. what's the difference between {"" : {}} and {}?
The first one is a config with no sources configured and no sync properties.
But it is not completely empty, at least the node for sync properties exists.
I've added a clarification to the Session API spec.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
1:34 p.m.
New subject: [Bug 7707] revised configuration layout: multiple peers per config
http://bugzilla.moblin.org/show_bug.cgi?id=7707
--- Comment #7 from yongsheng zhu <yongsheng.zhu(a)intel.com> 2009-11-24 18:34:29 PST
---
Can you clarify which code you mean?
For this commit "config: reorganized for
shared config layout (MB#7707)", you
can see the second paragraph of commit log,
The FileConfigTree is instantiated with a root which is one level high up
compare to before this patch (for example, "~/.config/syncevolution" instead of
"./config/syncevolution/scheduleworld") and then config files include that
dropped level in their relative path name
Is './config/syncevolution/scheduleworld' your expected description?
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
7:30 p.m.
New subject: [Bug 7707] revised configuration layout: multiple peers per config
http://bugzilla.moblin.org/show_bug.cgi?id=7707
--- Comment #8 from pohly <patrick.ohly(a)intel.com> 2009-11-25 00:30:22 PST ---
(In reply to comment #7)
>
> Can you clarify which code you mean?
For this commit "config: reorganized for shared config layout (MB#7707)", you
can see the second paragraph of commit log,
The FileConfigTree is instantiated with a root which is one level high up
compare to before this patch (for example, "~/.config/syncevolution" instead
of
"./config/syncevolution/scheduleworld") and then config files include that
dropped level in their relative path name
Is './config/syncevolution/scheduleworld' your expected description?
Yes. That was the root path in old-style HTTP server configurations.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
2:25 a.m.
New subject: [Bug 7707] revised configuration layout: multiple peers per config
http://bugzilla.moblin.org/show_bug.cgi?id=7707
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #9 from pohly <patrick.ohly(a)intel.com> 2010-02-19 07:25:41 PST ---
I can't think of anything that might be missing to implement this feature.
Considering it resolved.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
3:24 a.m.
New subject: [Bug 7707] revised configuration layout: multiple peers per config
http://bugzilla.moblin.org/show_bug.cgi?id=7707
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |INTEGRATED
--- Comment #10 from pohly <patrick.ohly(a)intel.com> 2010-02-24 08:24:49 PST ---
Integrated in 1.0 beta 2 = 0.99.11.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
8:32 p.m.
New subject: [Bug 7707] revised configuration layout: multiple peers per config
http://bugzilla.moblin.org/show_bug.cgi?id=7707
ZhangJingke <jingke.zhang(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
CC| |jingke.zhang(a)intel.com
--- Comment #11 from ZhangJingke <jingke.zhang(a)intel.com> 2010-03-03 01:32:09 PST
---
Verify this issue with syncevolution-0.9.99.11, the layout has already been
there.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
4582
days inactive
4703
days old
syncevolution-issues@syncevolution.org
17 comments
1 participants
participants (1)
-
bugzilla＠moblin.org