1:31 a.m.
http://bugzilla.moblin.org/show_bug.cgi?id=6127
Summary: workaround for 200 vs 201 status codes
Classification: Moblin Projects
Product: SyncEvolution
Version: upstream
Platform: Netbook
OS/Version: Moblin Linux
Status: ASSIGNED
Severity: normal
Priority: P2
Component: * Feature Request
AssignedTo: congwu.chen(a)intel.com
ReportedBy: patrick.ohly(a)intel.com
CC: syncevolution(a)lists.intel.com
Release Milestone: Undecided
In combination with Google (to pick just one example) we don't get correct
statistics for items added on the server. Because the server replies with 200
(OK) instead of 201 (Added), new items are counted as "updated" instead of
"added".
We had a workaround for this in the libsynthesis used in 0.9, but now it got
implemented differently upstream. Need to retest that the new code works as
desired.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
1:35 a.m.
New subject: [Bug 6127] workaround for 200 vs 201 status codes + Replace instead of Add
http://bugzilla.moblin.org/show_bug.cgi?id=6127
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|workaround for 200 vs 201 |workaround for 200 vs 201
|status codes |status codes + Replace
| |instead of Add
--- Comment #1 from pohly <patrick.ohly(a)intel.com> 2009-09-15 08:35:37 ---
Now libsynthesis uses a normal "Add" command to create new items on the server,
which avoids the need to second guess what the server's response status means.
If we find that "Replace" is more compatible, then Lukas would add a
configuration option for it.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
5:53 p.m.
New subject: [Bug 6127] workaround for 200 vs 201 status codes + Replace instead of Add
http://bugzilla.moblin.org/show_bug.cgi?id=6127
--- Comment #2 from Chen Congwu <congwu.chen(a)intel.com> 2009-09-21 00:53:36 ---
(In reply to comment #1)
The test shows google still needs a workaround options for it.
http://runtests.syncevolution.org/2009-09-19-22-00/head-evolution-testing...
For Zyb server, since all cases are blocked by another issue, I am not sure
whether the sending Add as Add helps the statistics options.
Lastly, this client side behavior change does not have negative effect for
other servers.
So we still need synthesis to help add a workaround options for us?
Now libsynthesis uses a normal "Add" command to create new
items on the server,
which avoids the need to second guess what the server's response status means.
If we find that "Replace" is more compatible, then Lukas would add a
configuration option for it.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
9:22 p.m.
New subject: [Bug 6127] workaround for 200 vs 201 status codes + Replace instead of Add
http://bugzilla.moblin.org/show_bug.cgi?id=6127
--- Comment #3 from pohly <patrick.ohly(a)intel.com> 2009-09-21 04:22:20 ---
(In reply to comment #2)
(In reply to comment #1)
The test shows google still needs a workaround options for it.
http://runtests.syncevolution.org/2009-09-19-22-00/head-evolution-testing...
So we send an "Add" and get a status 200 = "OK" back, right? I think
the
Synthesis engine should be able to handle this. Can you bring this up with
Synthesis, with or without a patch?
So we still need synthesis to help add a workaround options for us?
Is it really a workaround or a fix? I'm not sure whether the server is required
to return "201".
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
11:21 p.m.
New subject: [Bug 6127] workaround for 200 vs 201 status codes + Replace instead of Add
http://bugzilla.moblin.org/show_bug.cgi?id=6127
--- Comment #4 from Chen Congwu <congwu.chen(a)intel.com> 2009-09-21 06:21:41 ---
(In reply to comment #3)
The server is still required to return status code 201. Therefore we still need
a workaround for this wrong server side behavior.
This is part 2 of the resend related discussion we had with synthesis, I will
bring this up.
(In reply to comment #2)
> (In reply to comment #1)
Is it really a workaround or a fix? I'm not sure whether the server is required
to return "201".
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
11:12 a.m.
New subject: [Bug 6127] workaround for 200 vs 201 status codes + Replace instead of Add
http://bugzilla.moblin.org/show_bug.cgi?id=6127
--- Comment #5 from Chen Congwu <congwu.chen(a)intel.com> 2009-09-22 18:12:33 ---
(In reply to comment #4)
Lukas has pushed the fix on this issue.
> I have checked the spec and not found such case. So can we just
> workaround this as counting 200 as Add for a sop_add?
[Lukas]
Yes, I think that's a perfectly safe assumption. I added the
change to
localengineds.cpp right now, see branch luz on synthesis indefero git.
(In reply to comment #3)
The server is still required to return status code 201. Therefore we still need
a workaround for this wrong server side behavior.
This is part 2 of the resend related discussion we had with synthesis, I will
bring this up.
> (In reply to comment #2)
> > (In reply to comment #1)
> Is it really a workaround or a fix? I'm not sure whether the server is required
> to return "201".
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
3:17 p.m.
New subject: [Bug 6127] workaround for 200 vs 201 status codes + Replace instead of Add
http://bugzilla.moblin.org/show_bug.cgi?id=6127
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #6 from pohly <patrick.ohly(a)intel.com> 2009-09-22 22:17:22 ---
(In reply to comment #5)
(In reply to comment #4)
Lukas has pushed the fix on this issue.
>> I have checked the spec and not found such case. So can we just
>> workaround this as counting 200 as Add for a sop_add?
>
[Lukas]
>Yes, I think that's a perfectly safe assumption. I added the change to
>localengineds.cpp right now, see branch luz on synthesis indefero git.
Merged into our "master" branch. Let's consider this fixed unless nightly
testing tells us otherwise.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
12:05 a.m.
New subject: [Bug 6127] workaround for 200 vs 201 status codes + Replace instead of Add
http://bugzilla.moblin.org/show_bug.cgi?id=6127
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |INTEGRATED
--- Comment #7 from pohly <patrick.ohly(a)intel.com> 2009-09-28 07:05:03 ---
Integrated into Moblin 2.1 in syncevolution-0.9.0.99.2.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
5:55 p.m.
New subject: [Bug 6127] workaround for 200 vs 201 status codes + Replace instead of Add
http://bugzilla.moblin.org/show_bug.cgi?id=6127
shuangeeer <yanshuang.zheng(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
CC| |yanshuang.zheng(a)intel.com
--- Comment #8 from shuangeeer <yanshuang.zheng(a)intel.com> 2009-10-08 23:55:34 ---
verify it by running data sync with google. When contacts are added on server,
the statistic is corrected by showing how many items are added.
pkg 0.9.0.99.3 in moblin-2.1-preview-20091008-001
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
4727
days inactive
4751
days old
syncevolution-issues@syncevolution.org
8 comments
1 participants
participants (1)
-
bugzilla＠moblin.org