http://bugzilla.moblin.org/show_bug.cgi?id=2425
Chen Congwu <congwu.chen(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |congwu.chen(a)intel.com
--- Comment #7 from Chen Congwu <congwu.chen(a)intel.com> 2010-03-08 17:51:19 PST
---
(In reply to comment #6)
I noticed that our implementation of storing the servers map was
faulty. It
didn't handle the case that the remote ID was an empty string.[...]
The patch below fixes the problem, while preserving backwards compatibility to
existing map files. While looking at the two functions, I noticed that
mapid2entry() escapes the ID before adding it to the key, whereas entry2mapid()
unescapes the key, then extracts the ID. That doesn't look right. It should
first split at "-", then unescape the parts.
Congwu, you touched that code last. Do you agree that there is something to be
fixed here?
Yes, I think you are right.
Also, any comments on the patch below?
Looks OK.
--
Configure bugmail:
http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.