9:20 a.m.
https://bugs.freedesktop.org/show_bug.cgi?id=56667
Priority: medium
Bug ID: 56667
CC: syncevolution-issues(a)syncevolution.org
Assignee: syncevolution-issues(a)syncevolution.org
Summary: auto sync runs only once
Severity: normal
Classification: Unclassified
OS: All
Reporter: dbet1(a)gmx.net
Hardware: Other
Status: NEW
Version: 1.3
Component: SyncEvolution
Product: SyncEvolution
Until version 1.2 auto sync happens every 30 minutes. Since 1.3 it happens only
once after login. This is also the case in 1.3.1.
The process syncevo-dbus-server is started, but after the first sync it does
not do any more. I have to sync manually.
Ubuntu 10.04 32-Bit.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
9:21 a.m.
New subject: [Bug 56667] auto sync runs only once
https://bugs.freedesktop.org/show_bug.cgi?id=56667
Daniel <dbet1(a)gmx.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Hardware|Other |x86 (IA32)
OS|All |Linux (All)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
4:17 p.m.
New subject: [Bug 56667] auto sync runs only once
https://bugs.freedesktop.org/show_bug.cgi?id=56667
Patrick Ohly <patrick.ohly(a)gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|syncevolution-issues@syncev |patrick.ohly(a)gmx.de
|olution.org |
--- Comment #1 from Patrick Ohly <patrick.ohly(a)gmx.de> ---
I can reproduce this and wrote an automated test for it. I had tests for
corner-cases, but not the key aspect of automated sycning :-/
The fix is a trivial one-line change, but requires a recompilation. I'll see
when I can release 1.3.2.
commit 44fbf546456a0ca26d59b09e122ef8162263f4a8
Author: Patrick Ohly <patrick.ohly(a)intel.com>
Date: Sun Nov 4 17:08:22 2012 +0100
auto sync: only synced once (FDO #56667)
A successful sync was incorrectly treated like a sync with a permanent
failure, which prevents further automatic syncing.
Adding a check for "status okay" fixes that problem. A unit test for
this case will be comitted separately.
diff --git a/src/dbus/server/auto-sync-manager.cpp
b/src/dbus/server/auto-sync-manager.cpp
index b409c1e..0cb3c9a 100644
--- a/src/dbus/server/auto-sync-manager.cpp
+++ b/src/dbus/server/auto-sync-manager.cpp
@@ -507,7 +507,7 @@ void AutoSyncManager::autoSyncDone(AutoSyncTask *task,
SyncMLStatus status)
void AutoSyncManager::anySyncDone(AutoSyncTask *task, SyncMLStatus status)
{
// set "permanently failed" flag according to most recent result
- task->m_permanentFailure = !ErrorIsTemporary(status);
+ task->m_permanentFailure = status != STATUS_OK &&
!ErrorIsTemporary(status);
SE_LOG_DEBUG(NULL, NULL, "auto sync: sync session %s done, result %d %s",
task->m_configName.c_str(),
status,
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
2:48 p.m.
New subject: [Bug 56667] auto sync runs only once
https://bugs.freedesktop.org/show_bug.cgi?id=56667
--- Comment #2 from Daniel <dbet1(a)gmx.net> ---
Thank you for the fix. I can apply it and compile it for me.
--
You are receiving this mail because:
You are on the CC list for the bug.
8:34 a.m.
New subject: [Bug 56667] auto sync runs only once
https://bugs.freedesktop.org/show_bug.cgi?id=56667
Patrick Ohly <patrick.ohly(a)gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Whiteboard| |13x
Resolution|--- |FIXED
--- Comment #3 from Patrick Ohly <patrick.ohly(a)gmx.de> ---
Will be in 1.3.2.
--
You are receiving this mail because:
You are on the CC list for the bug.
3023
days inactive
3040
days old
syncevolution-issues@syncevolution.org
4 comments
1 participants
participants (1)
-
bugzilla-daemon＠freedesktop.org