3:45 a.m.
https://bugs.meego.com/show_bug.cgi?id=19464
Summary: defaultPeer has changed somehow
Classification: MeeGo Projects
Product: SyncEvolution
Platform: ---
Version: unspecified
Platform: Common
Architecture: ---
Status: NEW
Severity: normal
Priority: Undecided
Component: SyncEvolution
AssignedTo: syncevolution-bugs(a)meego.bugs
ReportedBy: jku(a)linux.intel.com
QAContact: jingke.zhang(a)intel.com
CC: syncevolution-bugs(a)meego.bugs,
syncevolution-default-bugs(a)meego.bugs
Estimated Hours: 0.0
defaultPeer used to work as a "global" configuration variable: setting it in
any configuration would mean sync-ui could do GetConfig("", False) at startup
to figure out which config to show.
Now this seems to no longer work: I'm saving a configuration and setting
"defaultPeer" in it. When I next query GetConfig("", False) it
doesn't give me
a defaultpeer.
In the long term we may want to question if the idea of "defaultPeer" is viable
(or if multiple active configs should be exepcted), but for now the sync-ui
relies on it.
--------
Product: SyncEvolution
Component: SyncEvolution
MeeGo Release: unspecified
Severity: normal
Priority: Undecided
Keywords:
Status: NEW
Who: jku(a)linux.intel.com
Assigned To: syncevolution-bugs(a)meego.bugs
Target Build: ---
Flags:
Changed:
--------
https://bugs.meego.com/show_bug.cgi?id=19464
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
6:44 a.m.
New subject: [Bug 19464] defaultPeer has changed somehow
https://bugs.meego.com/show_bug.cgi?id=19464
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|Undecided |Medium
Status|NEW |NEEDINFO
CC| |patrick.ohly(a)intel.com
AssignedTo|syncevolution-bugs(a)meego.bu |jku(a)linux.intel.com
|gs |
Severity|normal |major
--- Comment #1 from pohly <patrick.ohly(a)intel.com> 2011-06-17 10:44:09 UTC ---
I can't reproduce this.
Can you include a dbus-monitor log demonstrating the problem?
--------
Product: SyncEvolution
Component: SyncEvolution
MeeGo Release: unspecified
Severity: major
Priority: Medium
Keywords:
Status: NEEDINFO
Who: patrick.ohly(a)intel.com
Assigned To: jku(a)linux.intel.com
Target Build: ---
Flags:
Changed: Priority Status CC AssignedTo Severity
--------
https://bugs.meego.com/show_bug.cgi?id=19464
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
7:08 a.m.
New subject: [Bug 19464] defaultPeer has changed somehow
https://bugs.meego.com/show_bug.cgi?id=19464
Jussi Kukkonen <jku(a)linux.intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
--- Comment #2 from Jussi Kukkonen <jku(a)linux.intel.com> 2011-06-20 11:08:37 UTC
---
This result is from my jku branch, but it is up-to-date with master and all
changes are in the UI so .
Result from executing GetConfig ("", False) in d-feet:
---
method call sender=:1.725 -> dest=:1.717 serial=158
path=/org/syncevolution/Server; interface=org.syncevolution.Server;
member=GetConfig
string ""
boolean false
method return sender=:1.717 -> dest=:1.725 reply_serial=158
array [
dict entry(
string ""
array [
dict entry(
string "ConsumerReady"
string "1"
)
dict entry(
string "configName"
string "@default"
)
]
)
dict entry(
string "source/calendar"
array [
dict entry(
string "backend"
string "calendar"
)
]
)
]
---
If I ask for an actual existing configuration "google_calendar", I do get
defaultPeer included in the hash.
--------
Product: SyncEvolution
Component: SyncEvolution
MeeGo Release: unspecified
Severity: major
Priority: Medium
Keywords:
Status: NEW
Who: jku(a)linux.intel.com
Assigned To: jku(a)linux.intel.com
Target Build: ---
Flags:
Changed: Status
--------
https://bugs.meego.com/show_bug.cgi?id=19464
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
11:29 a.m.
New subject: [Bug 19464] defaultPeer has changed somehow
https://bugs.meego.com/show_bug.cgi?id=19464
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #3 from pohly <patrick.ohly(a)intel.com> 2011-06-21 15:29:40 UTC ---
(In reply to comment #2)
This result is from my jku branch, but it is up-to-date with master
and all
changes are in the UI so .
Result from executing GetConfig ("", False) in d-feet:
---
method call sender=:1.725 -> dest=:1.717 serial=158
path=/org/syncevolution/Server; interface=org.syncevolution.Server;
member=GetConfig
string ""
boolean false
method return sender=:1.717 -> dest=:1.725 reply_serial=158
array [
dict entry(
string ""
array [
dict entry(
string "ConsumerReady"
string "1"
)
dict entry(
string "configName"
string "@default"
)
]
)
dict entry(
string "source/calendar"
array [
dict entry(
string "backend"
string "calendar"
)
]
)
]
---
I get a different result:
$ dbus-send --print-reply --dest=org.syncevolution /org/syncevolution/Server
org.syncevolution.Server.GetConfig string:'' boolean:true
Error org.syncevolution.NoSuchConfig: No template '' found
With a valid template name I get:
$ dbus-send --print-reply --dest=org.syncevolution /org/syncevolution/Server
org.syncevolution.Server.GetConfig string:'memotoo' boolean:true
method return sender=:1.1078 -> dest=:1.1091 reply_serial=2
array [
dict entry(
string ""
array [
dict entry(
string "ConsumerReady"
string "1"
)
dict entry(
string "WebURL"
string "http://www.memotoo.com"
)
dict entry(
string "configName"
string "memotoo"
)
dict entry(
string "defaultPeer"
string "scheduleworld_1@client-test-1"
)
...
So I still can't reproduce the problem. Does it work when asking for a valid
template?
--------
Product: SyncEvolution
Component: SyncEvolution
MeeGo Release: unspecified
Severity: major
Priority: Medium
Keywords:
Status: NEEDINFO
Who: patrick.ohly(a)intel.com
Assigned To: jku(a)linux.intel.com
Target Build: ---
Flags:
Changed: Status
--------
https://bugs.meego.com/show_bug.cgi?id=19464
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
6:19 a.m.
New subject: [Bug 19464] defaultPeer has changed somehow
https://bugs.meego.com/show_bug.cgi?id=19464
--- Comment #4 from Jussi Kukkonen <jku(a)linux.intel.com> 2011-06-22 10:19:00 UTC
---
(In reply to comment #3)
I get a different result:
$ dbus-send --print-reply --dest=org.syncevolution /org/syncevolution/Server
org.syncevolution.Server.GetConfig string:'' boolean:true
Error org.syncevolution.NoSuchConfig: No template '' found
Interesting... The reason I'm calling it like this is that it happens on
startup and I don't yet have a configuration (I'm trying to find out which one
to load).
With a valid template name I get:
$ dbus-send --print-reply --dest=org.syncevolution /org/syncevolution/Server
org.syncevolution.Server.GetConfig string:'memotoo' boolean:true
...
So I still can't reproduce the problem. Does it work when asking for a valid
template?
No. I set a defaultPeer with SetConfig (saving a local configuration) and it
gets written in the config file. If I ask for the template with
GetConfig("Google_Calendar",True) I get no defaultPeer, but if I ask for the
configuration I saved I do get a defaultPeer.
--------
Product: SyncEvolution
Component: SyncEvolution
MeeGo Release: unspecified
Severity: major
Priority: Medium
Keywords:
Status: NEEDINFO
Who: jku(a)linux.intel.com
Assigned To: jku(a)linux.intel.com
Target Build: ---
Flags:
Changed:
--------
https://bugs.meego.com/show_bug.cgi?id=19464
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
8:53 a.m.
New subject: [Bug 19464] defaultPeer has changed somehow
https://bugs.meego.com/show_bug.cgi?id=19464
Jussi Kukkonen <jku(a)linux.intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
--- Comment #5 from Jussi Kukkonen <jku(a)linux.intel.com> 2011-06-22 12:53:55 UTC
---
(In reply to comment #3)
I get a different result:
$ dbus-send --print-reply --dest=org.syncevolution /org/syncevolution/Server
org.syncevolution.Server.GetConfig string:'' boolean:true
Error org.syncevolution.NoSuchConfig: No template '' found
Ah, just noticed we're doing slightly different things here:
I'm calling GetConfig("", False) in the code -- don't ask me why, I
couldn't
remember. The same call with "True" does fail with the same error as yours.
In any case, that has worked before but changing it is not a problem if it's
wrong.
So I still can't reproduce the problem. Does it work when asking
for a valid
template?
This is still a negative: Template does not include defaultPeer.
--------
Product: SyncEvolution
Component: SyncEvolution
MeeGo Release: unspecified
Severity: major
Priority: Medium
Keywords:
Status: NEW
Who: jku(a)linux.intel.com
Assigned To: jku(a)linux.intel.com
Target Build: ---
Flags:
Changed: Status
--------
https://bugs.meego.com/show_bug.cgi?id=19464
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
10:46 a.m.
New subject: [Bug 19464] defaultPeer has changed somehow
https://bugs.meego.com/show_bug.cgi?id=19464
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|jku(a)linux.intel.com |patrick.ohly(a)intel.com
--- Comment #6 from pohly <patrick.ohly(a)intel.com> 2011-06-22 14:46:33 UTC ---
(In reply to comment #5)
(In reply to comment #3)
> I get a different result:
>
> $ dbus-send --print-reply --dest=org.syncevolution /org/syncevolution/Server
> org.syncevolution.Server.GetConfig string:'' boolean:true
>
> Error org.syncevolution.NoSuchConfig: No template '' found
Ah, just noticed we're doing slightly different things here:
I'm calling GetConfig("", False) in the code -- don't ask me why, I
couldn't
remember. The same call with "True" does fail with the same error as yours.
Good catch. My bad, I can reproduce it now and will fix it.
--------
Product: SyncEvolution
Component: SyncEvolution
MeeGo Release: unspecified
Severity: major
Priority: Medium
Keywords:
Status: ASSIGNED
Who: patrick.ohly(a)intel.com
Assigned To: patrick.ohly(a)intel.com
Target Build: ---
Flags:
Changed: Status AssignedTo
--------
https://bugs.meego.com/show_bug.cgi?id=19464
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
4:55 p.m.
New subject: [Bug 19464] defaultPeer has changed somehow
https://bugs.meego.com/show_bug.cgi?id=19464
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |NEEDINFO
AssignedTo|patrick.ohly(a)intel.com |jku(a)linux.intel.com
--- Comment #7 from pohly <patrick.ohly(a)intel.com> 2011-06-22 20:55:00 UTC ---
(In reply to comment #6)
Good catch. My bad, I can reproduce it now and will fix it.
Argh. Ignore that. I didn't get "defaultPeer" because it wasn't set in
my test
account. Once I set it, it works for me as expected. Full log below:
bash-3.2$ for i in `find ~/.config/syncevolution -type f`; do echo $i:; cat $i;
done
/home/meego/.config/syncevolution/config.ini:
defaultPeer = foo
bash-3.2$ rpm -q syncevolution
syncevolution-1.1.99.4-21.3.i586
That happens to be commit 55540e2, which is a bit older than master. But
nothing in the more recent commits touches defaultPeer or the
syncevo-dbus-server.
bash-3.2$ /usr/libexec/syncevo-dbus-server &
[3] 25022
[2] Done /usr/libexec/syncevo-dbus-server
bash-3.2$ [INFO] /usr/libexec/syncevo-dbus-server: ready to run
bash-3.2$ dbus-send --print-reply --dest=org.syncevolution
/org/syncevolution/Server org.syncevolution.Server.GetConfig
string:'scheduleworld' boolean:true
method return sender=:1.12 -> dest=:1.14 reply_serial=2
array [
dict entry(
string ""
array [
dict entry(
string "ConsumerReady"
string "1"
)
dict entry(
string "WebURL"
string "http://www.scheduleworld.com"
)
dict entry(
string "configName"
string "scheduleworld"
)
dict entry(
string "defaultPeer"
string "foo"
)
dict entry(
string "deviceId"
string "syncevolution-0870dd58-6dba-4ef3-bda2-5a42de08131a"
)
dict entry(
string "syncURL"
string "http://sync.scheduleworld.com/funambol/ds"
)
]
)
[...]
bash-3.2$ syncevolution --configure scheduleworld
bash-3.2$ dbus-send --print-reply --dest=org.syncevolution
/org/syncevolution/Server org.syncevolution.Server.GetConfig
string:'scheduleworld' boolean:false
method return sender=:1.12 -> dest=:1.21 reply_serial=2
array [
dict entry(
string ""
array [
dict entry(
string "WebURL"
string "http://www.scheduleworld.com"
)
dict entry(
string "configName"
string "scheduleworld"
)
dict entry(
string "defaultPeer"
string "foo"
)
dict entry(
string "deviceId"
string "syncevolution-7676f0ea-b7fe-43bc-adad-54f421285678"
)
dict entry(
string "syncURL"
string "http://sync.scheduleworld.com/funambol/ds"
)
]
)
[...]
bash-3.2$ syncevolution --configure source-config@yahoo
bash-3.2$ dbus-send --print-reply --dest=org.syncevolution
/org/syncevolution/Server org.syncevolution.Server.GetConfig
string:'source-config@yahoo' boolean:false
method return sender=:1.12 -> dest=:1.23 reply_serial=2
array [
dict entry(
string ""
array [
dict entry(
string "ConsumerReady"
string "1"
)
dict entry(
string "configName"
string "source-config@yahoo"
)
dict entry(
string "defaultPeer"
string "foo"
)
dict entry(
string "deviceId"
string "syncevolution-17d847ff-7dec-483f-8763-79346686da45"
)
dict entry(
string "peerType"
string "WebDAV"
)
]
)
[...]
bash-3.2$ dbus-send --print-reply --dest=org.syncevolution
/org/syncevolution/Server org.syncevolution.Server.GetConfig string:''
boolean:false
method return sender=:1.12 -> dest=:1.24 reply_serial=2
array [
dict entry(
string ""
array [
dict entry(
string "ConsumerReady"
string "1"
)
dict entry(
string "configName"
string "@default"
)
dict entry(
string "defaultPeer"
string "foo"
)
dict entry(
string "deviceId"
string "syncevolution-7676f0ea-b7fe-43bc-adad-54f421285678"
)
]
)
[...]
In other words, I still cannot reproduce it.
--------
Product: SyncEvolution
Component: SyncEvolution
MeeGo Release: unspecified
Severity: major
Priority: Medium
Keywords:
Status: NEEDINFO
Who: patrick.ohly(a)intel.com
Assigned To: jku(a)linux.intel.com
Target Build: ---
Flags:
Changed: Status AssignedTo
--------
https://bugs.meego.com/show_bug.cgi?id=19464
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
12:21 p.m.
New subject: [Bug 19464] defaultPeer has changed somehow
https://bugs.meego.com/show_bug.cgi?id=19464
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |ASSIGNED
AssignedTo|jku(a)linux.intel.com |patrick.ohly(a)intel.com
--- Comment #8 from pohly <patrick.ohly(a)intel.com> 2011-06-29 16:21:54 UTC ---
Chris Kühl found that the TestMultipleConfigs.testSharing test fails. Probably
the same root cause. I'll check.
--------
Product: SyncEvolution
Component: SyncEvolution
MeeGo Release: unspecified
Severity: major
Priority: Medium
Keywords:
Status: ASSIGNED
Who: patrick.ohly(a)intel.com
Assigned To: patrick.ohly(a)intel.com
Target Build: ---
Flags:
Changed: Status AssignedTo
--------
https://bugs.meego.com/show_bug.cgi?id=19464
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
9:12 a.m.
New subject: [Bug 19464] defaultPeer has changed somehow
https://bugs.meego.com/show_bug.cgi?id=19464
blixtra <blixtra(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |blixtra(a)gmail.com
--- Comment #9 from blixtra <blixtra(a)gmail.com> 2011-07-07 13:12:54 UTC ---
Jussi, what distro are you on?
I've not been able to hit this bug on Ubuntu (Maverick, Natty). I only hit it
on my Fedora 15 install.
--------
Product: SyncEvolution
Component: SyncEvolution
MeeGo Release: unspecified
Severity: major
Priority: Medium
Keywords:
Status: ASSIGNED
Who: blixtra(a)gmail.com
Assigned To: patrick.ohly(a)intel.com
Target Build: ---
Flags:
Changed: CC
--------
https://bugs.meego.com/show_bug.cgi?id=19464
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
3:52 a.m.
New subject: [Bug 19464] defaultPeer has changed somehow
https://bugs.meego.com/show_bug.cgi?id=19464
--- Comment #10 from Jussi Kukkonen <jku(a)linux.intel.com> 2011-07-08 07:52:52 UTC
---
(In reply to comment #9)
Jussi, what distro are you on?
Debian Unstable.
--------
Product: SyncEvolution
Component: SyncEvolution
MeeGo Release: unspecified
Severity: major
Priority: Medium
Keywords:
Status: ASSIGNED
Who: jku(a)linux.intel.com
Assigned To: patrick.ohly(a)intel.com
Target Build: ---
Flags:
Changed:
--------
https://bugs.meego.com/show_bug.cgi?id=19464
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
2:37 p.m.
New subject: [Bug 19464] defaultPeer has changed somehow
https://bugs.meego.com/show_bug.cgi?id=19464
--- Comment #11 from pohly <patrick.ohly(a)intel.com> 2011-07-08 18:37:02 UTC ---
(In reply to comment #10)
(In reply to comment #9)
> Jussi, what distro are you on?
Debian Unstable.
Time to set up a chroot... hurray, I can reproduce it. Now I just need to
pin-point the root-cause.
--------
Product: SyncEvolution
Component: SyncEvolution
MeeGo Release: unspecified
Severity: major
Priority: Medium
Keywords:
Status: ASSIGNED
Who: patrick.ohly(a)intel.com
Assigned To: patrick.ohly(a)intel.com
Target Build: ---
Flags:
Changed:
--------
https://bugs.meego.com/show_bug.cgi?id=19464
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
3:27 p.m.
New subject: [Bug 19464] defaultPeer has changed somehow
https://bugs.meego.com/show_bug.cgi?id=19464
--- Comment #12 from pohly <patrick.ohly(a)intel.com> 2011-07-08 19:27:34 UTC ---
Okay, got it. Now I just need some C++ expert who can tell me whether it is a
bug in the code or in my understanding of the language.
The problem is that syncPropDefaultPeer, the property description of
"defaultPeer", doesn't get initialized in the order in which it should be
initialized.
What happens is this:
Breakpoint 17, SyncEvo::SyncConfig::getRegistry ()
at /home/pohly/syncevolution/syncevolution/src/syncevo/SyncConfig.cpp:1549
1549 syncPropDefaultPeer.setSharing(ConfigProperty::GLOBAL_SHARING);
(gdb) where
#0 SyncEvo::SyncConfig::getRegistry () at
/home/pohly/syncevolution/syncevolution/src/syncevo/SyncConfig.cpp:1549
#1 0x0000000000673402 in
SyncEvo::RegisterWebDAVSyncSource::RegisterWebDAVSyncSource (this=0xc96f60)
at
/home/pohly/syncevolution/syncevolution/src/backends/webdav/WebDAVSourceRegister.cpp:80
#2 0x00000000006731fb in __static_initialization_and_destruction_0
(__initialize_p=1, __priority=65535)
at
/home/pohly/syncevolution/syncevolution/src/backends/webdav/WebDAVSourceRegister.cpp:82
#3 0x0000000000673227 in _GLOBAL__sub_I_WebDAVSourceRegister.cpp(void) ()
at
/home/pohly/syncevolution/syncevolution/src/backends/webdav/WebDAVSourceRegister.cpp:302
#4 0x00000000009376ad in __libc_csu_init ()
#5 0x00007ffff548de40 in __libc_start_main (main=<value optimized out>,
argc=<value optimized out>,
ubp_av=<value optimized out>, init=0x937650 <__libc_csu_init>,
fini=0x7ffff57eeec8 <main_arena+104>,
rtld_fini=0x7fffffffe280, stack_end=0x7fffffffe418) at libc-start.c:187
#6 0x0000000000647b59 in _start ()
^^^^^^^^^^^^^^
getRegistry() in SyncConfig.cpp gets called and sets the non-default
GLOBAL_SHARING in the static syncPropDefaultPeer instance.
(gdb) watch syncPropDefaultPeer.m_sharing
Hardware watchpoint 19: syncPropDefaultPeer.m_sharing
^^^^^^^^^^^^^^^
Let's see where that gets reset.
(gdb) c
Continuing.
Hardware watchpoint 19: syncPropDefaultPeer.m_sharing
Old value = SyncEvo::ConfigProperty::GLOBAL_SHARING
New value = SyncEvo::ConfigProperty::NO_SHARING
0x0000000000680383 in SyncEvo::ConfigProperty::ConfigProperty (this=0xc98200,
name=..., comment=..., def=...,
descr=...) at
/home/pohly/syncevolution/syncevolution/src/syncevo/SyncConfig.h:247
247 m_descr(descr)
(gdb) where
#0 0x0000000000680383 in SyncEvo::ConfigProperty::ConfigProperty
(this=0xc98200, name=..., comment=..., def=...,
descr=...) at
/home/pohly/syncevolution/syncevolution/src/syncevo/SyncConfig.h:247
#1 0x00000000007963ac in SyncEvo::SafeConfigProperty::SafeConfigProperty
(this=0xc98200, name=..., comment=...)
at /home/pohly/syncevolution/syncevolution/src/syncevo/SyncConfig.h:880
#2 0x0000000000791128 in __static_initialization_and_destruction_0
(__initialize_p=1, __priority=65535)
at /home/pohly/syncevolution/syncevolution/src/syncevo/SyncConfig.cpp:1372
#3 0x0000000000795ad7 in _GLOBAL__sub_I__ZN7SyncEvo19SourceAdminDataNameE ()
at /home/pohly/syncevolution/syncevolution/src/syncevo/SyncConfig.cpp:2899
#4 0x00000000009376ad in __libc_csu_init ()
#5 0x00007ffff548de40 in __libc_start_main (main=<value optimized out>,
argc=<value optimized out>,
ubp_av=<value optimized out>, init=0x937650 <__libc_csu_init>,
fini=0x7fffffffd1c0,
rtld_fini=0x7ffff558b390 <__memcpy_ssse3+8192>, stack_end=0x7fffffffe418)
at libc-start.c:187
#6 0x0000000000647b59 in _start ()
^^^^^^^^^^
The constructor of syncPropDefaultPeer is called and sets the default sharing
mode.
My expectation is that all constructors of instances in a compilation unit get
called before any method in that compilation unit executes.
However, I am no longer sure whether that is really guaranteed. Stroustrup C++
10.4.9 only mentions that static instances inside a function are initialized
when that function gets called, but doesn't say anything about instances inside
the compilation unit. Obviously, that is the solution to the problem here.
I'd still like to know whether it is required by the C++ standard. Any
opinions?
--------
Product: SyncEvolution
Component: SyncEvolution
MeeGo Release: unspecified
Severity: major
Priority: Medium
Keywords:
Status: ASSIGNED
Who: patrick.ohly(a)intel.com
Assigned To: patrick.ohly(a)intel.com
Target Build: ---
Flags:
Changed:
--------
https://bugs.meego.com/show_bug.cgi?id=19464
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
6:09 a.m.
New subject: [Bug 19464] defaultPeer has changed somehow
https://bugs.meego.com/show_bug.cgi?id=19464
murrayc <murrayc(a)murrayc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |murrayc(a)murrayc.com
--- Comment #13 from murrayc <murrayc(a)murrayc.com> 2011-07-11 10:09:52 UTC ---
This seems to be about initialization of static instances. It's generally
considered that there is absolutely no way to know when static instances will
be initialized, and no way to control it. This causes problems as soon as you
have one that's dependent on another.
If it works at any one time, it will likely break with another compiler or
platform.
It's best to just avoid static instances. Singletons are less awkward.
--------
Product: SyncEvolution
Component: SyncEvolution
MeeGo Release: unspecified
Severity: major
Priority: Medium
Keywords:
Status: ASSIGNED
Who: murrayc(a)murrayc.com
Assigned To: patrick.ohly(a)intel.com
Target Build: ---
Flags:
Changed: CC
--------
https://bugs.meego.com/show_bug.cgi?id=19464
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
6:26 a.m.
New subject: [Bug 19464] defaultPeer has changed somehow
https://bugs.meego.com/show_bug.cgi?id=19464
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #14 from pohly <patrick.ohly(a)intel.com> 2011-07-11 10:26:14 UTC ---
(In reply to comment #13)
This seems to be about initialization of static instances. It's
generally
considered that there is absolutely no way to know when static instances will
be initialized, and no way to control it.
Stroustrup makes two statements that can be relied upon:
10.4.8 Local Static Store
"The constructor for a local static object is called the first time the thread
of control passes through the object's definition."
10.4.9 Nonlocal Store
"Constructors for nonlocal objects in a translation unit are executed in the
order their definitions occur."
It's best to just avoid static instances. Singletons are less
awkward.
Singletons themselves depend on the first of these statements. I agree that
nonlocal storage is awkward. But in the case of SyncEvolution it is convenient
in a few places. Therefore I fixed the problem like this:
commit e0883e4c9230afeb40b497bb877853c0ae1bdb68
Author: Patrick Ohly <patrick.ohly(a)intel.com>
Date: Mon Jul 11 11:37:09 2011 +0200
SyncConfig: fixed compiler problem with C++ initialization order (BMC
#19464)
g++ 4.6 and ld 2.21.52.20110707 (Debian Unstable) led to a different
order of global instance construction:
1. WebDAV constructor calls SyncConfig::getRegistry()
2. getRegistry() adds the (uninitialized!) property instances
and modifies them
3. SyncConfig.cpp instances are initializes, which resets
some of the values modified by getRegistry()
The result was that, for example, the "defaultPeer" property was
treated like an unshared property and written into the wrong config
file.
The assumption that variables in a compilation unit are initialized
before methods in that unit can be called is not based on anything in
the C++ standard. Therefore this commit rewrites the code so that
properties are not added/updated inside the getRegistry()
methods. Instead this is done in separate classes which (and that is
guaranteed by the C++ standard) are constructed after the properties
defined earlier in the compilation unit.
--------
Product: SyncEvolution
Component: SyncEvolution
MeeGo Release: unspecified
Severity: major
Priority: Medium
Keywords:
Status: RESOLVED
Who: patrick.ohly(a)intel.com
Assigned To: patrick.ohly(a)intel.com
Target Build: ---
Flags:
Changed: Status Resolution
--------
https://bugs.meego.com/show_bug.cgi?id=19464
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
6:38 a.m.
New subject: [Bug 19464] defaultPeer has changed somehow
https://bugs.meego.com/show_bug.cgi?id=19464
--- Comment #15 from murrayc <murrayc(a)murrayc.com> 2011-07-11 10:38:14 UTC ---
OK. Thanks. It's great if that works. I just prefer to use get_*_instance()
methods everywhere to absolutely avoid the problem and not have to get things
right implicitly.
--------
Product: SyncEvolution
Component: SyncEvolution
MeeGo Release: unspecified
Severity: major
Priority: Medium
Keywords:
Status: RESOLVED
Who: murrayc(a)murrayc.com
Assigned To: patrick.ohly(a)intel.com
Target Build: ---
Flags:
Changed:
--------
https://bugs.meego.com/show_bug.cgi?id=19464
--
Configure bugmail: https://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
3524
days inactive
3548
days old
syncevolution-issues@syncevolution.org
15 comments
1 participants
participants (1)
-
bugzilla＠meego.com