4:10 a.m.
http://bugzilla.moblin.org/show_bug.cgi?id=9338
Summary: --configure and non-standard context: wrong shared
properties written
Classification: Moblin Projects
Product: SyncEvolution
Version: upstream
Platform: Netbook
OS/Version: Moblin Linux
Status: ASSIGNED
Severity: major
Priority: P1
Component: SyncEvolution
AssignedTo: patrick.ohly(a)intel.com
ReportedBy: patrick.ohly(a)intel.com
QAContact: yanshuang.zheng(a)intel.com
CC: syncevolution(a)lists.intel.com
When running a command like "syncevolution --configure ... foo" where foo is
stored in a non-default context (i.e., foo@bar), then properties from the
@default context seem to get inserted into foo@bar.
I suspect that this is caused by letting SyncConfig find the "foo" peer in
@bar, but then at some other place only parsing the "foo" string to find the
context.
Move normalize function into SyncConfig and implement the search functionality
there to prevent more errors of this kind?
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
7:25 a.m.
New subject: [Bug 9338] --configure and non-standard context: wrong shared properties written
http://bugzilla.moblin.org/show_bug.cgi?id=9338
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #1 from pohly <patrick.ohly(a)intel.com> 2010-01-29 12:25:04 PST ---
(In reply to comment #0)
When running a command like "syncevolution --configure ...
foo" where foo is
stored in a non-default context (i.e., foo@bar), then properties from the
@default context seem to get inserted into foo@bar.
I suspect that this is caused by letting SyncConfig find the "foo" peer in
@bar, but then at some other place only parsing the "foo" string to find the
context.
Move normalize function into SyncConfig and implement the search functionality
there to prevent more errors of this kind?
Doing that solved the problem. It also simplified the code because the more
complex version of SyncConfig::normalizeConfigString() could be removed *and*
remembering the context became obsolete.
Code in mb9338. Yongsheng, can you review this?
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
12:34 p.m.
New subject: [Bug 9338] --configure and non-standard context: wrong shared properties written
http://bugzilla.moblin.org/show_bug.cgi?id=9338
yongsheng zhu <yongsheng.zhu(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |yongsheng.zhu(a)intel.com
--- Comment #2 from yongsheng zhu <yongsheng.zhu(a)intel.com> 2010-01-31 17:34:01 PST
---
so now suppose we have 'foo@default' and 'foo@bar', If i want to use
'foo@default' implicitly by 'foo', it seems to me that it's
impossible, is it
expected?
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
6:33 p.m.
New subject: [Bug 9338] --configure and non-standard context: wrong shared properties written
http://bugzilla.moblin.org/show_bug.cgi?id=9338
--- Comment #3 from pohly <patrick.ohly(a)intel.com> 2010-01-31 23:33:03 PST ---
(In reply to comment #2)
so now suppose we have 'foo@default' and 'foo@bar',
If i want to use
'foo@default' implicitly by 'foo', it seems to me that it's
impossible,
It should be possible. The normalized name of "foo@default" is "foo",
therefore
it will be matched against "foo" first.
Do you have reason to believe that this doesn't work?
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
7:16 p.m.
New subject: [Bug 9338] --configure and non-standard context: wrong shared properties written
http://bugzilla.moblin.org/show_bug.cgi?id=9338
--- Comment #4 from yongsheng zhu <yongsheng.zhu(a)intel.com> 2010-02-01 00:16:51 PST
---
(In reply to comment #3)
(In reply to comment #2)
> so now suppose we have 'foo@default' and 'foo@bar', If i want to
use
> 'foo@default' implicitly by 'foo', it seems to me that it's
impossible,
It should be possible. The normalized name of "foo@default" is "foo",
therefore
it will be matched against "foo" first.
Do you have reason to believe that this doesn't work?
Yes, you are ok. here
your match are based on peer name regardless of context
names.
+ BOOST_FOREACH(const StringPair &entry, getConfigs()) {
+ string entry_peer, entry_context;
+ splitConfigString(entry.first, entry_peer, entry_context);
I miss this line. sorry.
+ if (normal == entry_peer) {
+ // found a matching, existing config, use it
+ normal = entry.first;
+ break;
+ }
+ }
please go on.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
8:17 p.m.
New subject: [Bug 9338] --configure and non-standard context: wrong shared properties written
http://bugzilla.moblin.org/show_bug.cgi?id=9338
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |INTEGRATED
--- Comment #5 from pohly <patrick.ohly(a)intel.com> 2010-02-04 01:17:39 PST ---
In 0.99.5.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
4609
days inactive
4615
days old
syncevolution-issues@syncevolution.org
5 comments
1 participants
participants (1)
-
bugzilla＠moblin.org