4:28 p.m.
http://bugzilla.moblin.org/show_bug.cgi?id=6500
Summary: [Neg] Invalid RetryInterval leads to never retry
Classification: Moblin Projects
Product: SyncEvolution
Version: upstream
Platform: Netbook
OS/Version: Moblin Linux
Status: NEW
Severity: normal
Priority: Undecided
Component: SyncEvolution
AssignedTo: patrick.ohly(a)intel.com
ReportedBy: yanshuang.zheng(a)intel.com
QAContact: yanshuang.zheng(a)intel.com
CC: shuang.wan(a)intel.com, syncevolution(a)lists.intel.com
Release Milestone: Undecided
pkg: sync-0.9.0.99.2
If set an invalid value to RetryInterval, like -2, then sync will hang when
network disconnected.
Reproduce steps
========================
1.$syncevolution -c -y username=<your_usename> -y password=<your_password>
funambol
2.$syncevolution -c -y RetryInterval=-2 funambol
3.run "$syncevolution funambol calendar" and once it starts syncing, unplug
network cable
Expect results
========================
when set invalid values to RetryInterval, sync should give error info and show
usage that they must be integers >0.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
3:11 a.m.
New subject: [Bug 6500] [Neg] Invalid RetryInterval leads to never retry
http://bugzilla.moblin.org/show_bug.cgi?id=6500
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #1 from pohly <patrick.ohly(a)intel.com> 2009-10-05 09:11:48 ---
commit 0d9f0efe98f200a5cef3bc0d64c39659d39f0c3d
Author: Patrick Ohly <patrick.ohly(a)intel.com>
Date: Mon Oct 5 18:06:13 2009 +0200
RetryInterval/Delay: only accept unsigned integers (MB #6500)
Negative values silently disabled message resending. This was
not documented and thus unexpected, so trigger an error for
this kind of values now (using the new type checking for
integer values).
To disable the feature users would have to use very large
integer numbers (not documented, but kind of obvious I hope).
commit c094b76659284d4554fceaac734e975c108762cc
Author: Patrick Ohly <patrick.ohly(a)intel.com>
Date: Mon Oct 5 18:00:38 2009 +0200
config value checking: be more strict for integer values
The old check used istringstream >> type as check, which
happened to accept invalid input like -1 for an unsigned
type. Now strol() strtoul() are used to do the conversion,
with the full range of error checking possible with those
functions:
for unsigned: "-1" => range error
for int: "10000000000" => range error
"", "x" => decimal value expected
"10x" => unexpected trailing non-whitespace characters: x
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
7:39 a.m.
New subject: [Bug 6500] [Neg] Invalid RetryInterval leads to never retry
http://bugzilla.moblin.org/show_bug.cgi?id=6500
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |INTEGRATED
--- Comment #2 from pohly <patrick.ohly(a)intel.com> 2009-10-07 13:38:59 ---
Integrated into Moblin 2.1 as 0.99.0.99.3 aka 0.9 beta 1.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
2:39 p.m.
New subject: [Bug 6500] [Neg] Invalid RetryInterval leads to never retry
http://bugzilla.moblin.org/show_bug.cgi?id=6500
--- Comment #3 from shuangeeer <yanshuang.zheng(a)intel.com> 2009-10-08 20:39:24 ---
retest with pkg 0.99.0.99.3 integrated into image 2.1-preview-20091008-001, the
results are:
RetryInterval=-2 ==> [[[RetryInterval = -2: cannot parse value]]] when running
RetryInterval=5000000000 ==> [[[ERROR: '-y RetryInterval=5000000000': range
error]]] when configuring
RetryInterval=1.2 ==> [[[ERROR: '-y RetryInterval=1.2': unexpected trailing
non-whitespace characters: .2]]] when configuring
RetryInterval=15s ==> [[[ERROR: '-y RetryInterval=15s': unexpected trailing
non-whitespace characters: s]]] when configuring
RetryInterval=a ==> [[[ERROR: '-y RetryInterval=a': decimal value expected]]]
when configuring
RetryInterval=';' ==> [[[ERROR: '-y RetryInterval=;': decimal value
expected]]]
when configuring
Just two issues before verification:
1)RetryInterval=-2 ==> [[[RetryInterval = -2: cannot parse value]]] when
running
---> this error info pops up when running, but not configuring. Is this
expected?
2) if configure RetryInterval to zero, then sync will resend messages 24220
times in 30 seconds. Does it make sense? Or shall we be more strict to reject
zero?
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
9:19 a.m.
New subject: [Bug 6500] [Neg] Invalid RetryInterval leads to never retry
http://bugzilla.moblin.org/show_bug.cgi?id=6500
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|INTEGRATED |
--- Comment #4 from pohly <patrick.ohly(a)intel.com> 2009-10-12 15:19:14 ---
(In reply to comment #3)
Just two issues before verification:
1)RetryInterval=-2 ==> [[[RetryInterval = -2: cannot parse value]]] when
running
---> this error info pops up when running, but not configuring. Is this
expected?
No, and I cannot reproduce it:
$ ./syncevolution --configure --sync-property RetryInterval=-2 scheduleworld_1
ERROR: '--sync-property RetryInterval=-2': range error
This is on my 64 bit Linux desktop. Hmm, I might have to try it in 32 bit mode.
2) if configure RetryInterval to zero, then sync will resend messages
24220
times in 30 seconds. Does it make sense? Or shall we be more strict to reject
zero?
Yes, I think a minimum value of 1 makes more sense. Should we use "0" to mean
"don't resend"?
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
12:01 p.m.
New subject: [Bug 6500] [Neg] Invalid RetryInterval leads to never retry
http://bugzilla.moblin.org/show_bug.cgi?id=6500
--- Comment #5 from shuangeeer <yanshuang.zheng(a)intel.com> 2009-10-12 18:01:07 ---
(In reply to comment #4)
Yes, I think a minimum value of 1 makes more sense. Should we use
"0" to mean
"don't resend"?
Yes, that is more considerate since users may disable retrying once the network
is not available.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
6:56 a.m.
New subject: [Bug 6500] [Neg] Invalid RetryInterval leads to never retry
http://bugzilla.moblin.org/show_bug.cgi?id=6500
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |FIXED
--- Comment #6 from pohly <patrick.ohly(a)intel.com> 2009-10-13 12:56:38 ---
(In reply to comment #4)
This is on my 64 bit Linux desktop. Hmm, I might have to try it in 32
bit mode.
Yes, this was a 32 vs 64 bit issue. Fixed.
> 2) if configure RetryInterval to zero, then sync will resend
messages 24220
> times in 30 seconds. Does it make sense? Or shall we be more strict to reject
> zero?
Yes, I think a minimum value of 1 makes more sense. Should we use "0" to mean
"don't resend"?
Implemented. I also documented that the retry interval and duration are
measured in seconds.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
7:51 a.m.
New subject: [Bug 6500] [Neg] Invalid RetryInterval leads to never retry
http://bugzilla.moblin.org/show_bug.cgi?id=6500
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |INTEGRATED
--- Comment #7 from pohly <patrick.ohly(a)intel.com> 2009-10-19 13:51:16 ---
Integrated in SyncEvolution 0.9.1 beta 2 = 0.9.0.99.4 in Moblin.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
1:43 p.m.
New subject: [Bug 6500] [Neg] Invalid RetryInterval leads to never retry
http://bugzilla.moblin.org/show_bug.cgi?id=6500
shuangeeer <yanshuang.zheng(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--- Comment #8 from shuangeeer <yanshuang.zheng(a)intel.com> 2009-10-19 19:42:59 ---
retest with pkg 0.99.0.99.4:
RetryInterval=-2 ==> [[[ERROR: '-y RetryInterval=-2': range error]]] when
configuring
RetryInterval=5000000000 ==> [[[ERROR: '-y RetryInterval=5000000000': range
error]]] when configuring
RetryInterval=1.2 ==> [[[ERROR: '-y RetryInterval=1.2': unexpected trailing
non-whitespace characters: .2]]] when configuring
RetryInterval=15s ==> [[[ERROR: '-y RetryInterval=15s': unexpected trailing
non-whitespace characters: s]]] when configuring
RetryInterval=a ==> [[[ERROR: '-y RetryInterval=a': decimal value expected]]]
when configuring
RetryInterval=';' ==> [[[ERROR: '-y RetryInterval=;': decimal value
expected]]]when configuring
RetryInterval=0 ==> Transport giving up after 0 retries and 0:00 min
Perfect! verified
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
4716
days inactive
4736
days old
syncevolution-issues@syncevolution.org
8 comments
1 participants
participants (1)
-
bugzilla＠moblin.org