9:48 p.m.
http://bugs.meego.com/show_bug.cgi?id=5819
Summary: syncevo-dbus-server: does not honor disabling of
autosync
Classification: MeeGo Projects
Product: SyncEvolution
Version: unspecified
Platform: All
Architecture: ---
Status: NEW
Severity: major
Priority: High
Component: SyncEvolution
AssignedTo: yongsheng.zhu(a)intel.com
ReportedBy: patrick.ohly(a)intel.com
QAContact: jingke.zhang(a)intel.com
CC: syncevolution-bugs(a)meego.bugs,
syncevolution-default-bugs(a)meego.bugs
Estimated Hours: 0.0
BUILD IMAGE(yyyy-mm-dd): MeeGo 1.0
HARDWARE MODEL (on what HW this bug is uncovered): na
BUG DETAILED DESCRIPTIONS
===========================================================
Enable automatic syncing. To simplify testing, set autoSyncInterval to
something small (1 min). Disable automatic syncing. Automatic syncing
continues.
EXACT STEPS LEADING TO PROBLEM:
(Explain in detail what you do (e.g. tap on OK) and what you see (e.g. message
Connection Failed appears))
===========================================================
1. syncevolution --configure --sync-property autoSync=1 --sync-property
autoSyncDelay=0 --sync-property autoSyncInterval=1m <config>
2. wait until syncing starts
3. syncevolution --configure --sync-property autoSync=0 <config>
EXPECTED OUTCOME:
===================
No more automatic syncs.
ACTUAL OUTCOME:
===================
Syncing continues at the selected interval.
Yongsheng, do you have time to look into this?
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
10:42 p.m.
New subject: [Bug 5819] syncevo-dbus-server: does not honor disabling of autosync
http://bugs.meego.com/show_bug.cgi?id=5819
--- Comment #1 from pohly <patrick.ohly(a)intel.com> 2010-08-25 06:42:00 PDT ---
Another situation which IMHO is not handled well is removal of a configuration
which is currently autosyncing. Session::setConfig() does not set m_setConfig
in this case, therefore I suspect that the daemon will continue to attempt auto
syncs - or at least attempts it once. It should stop after the failure.
I'm going to set m_setConfig in that code branch, because I need it for bug
#3558.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
10:04 p.m.
New subject: [MeeGo Projects - Bug 5819] syncevo-dbus-server: does not honor disabling of autosync
http://bugs.meego.com/show_bug.cgi?id=5819
--- Comment #2 from yongsheng <yongsheng.zhu(a)intel.com> 2010-11-22 05:04:18 PST ---
Patrick, it seems the patch is ready in the commit
1b243b7b8356a27b0c7872cd20649ac29147d282, right? maybe we should change the
status.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
10:20 p.m.
New subject: [MeeGo Projects - Bug 5819] syncevo-dbus-server: does not honor disabling of autosync
http://bugs.meego.com/show_bug.cgi?id=5819
--- Comment #3 from pohly <patrick.ohly(a)intel.com> 2010-11-22 05:20:38 PST ---
(In reply to comment #2)
Patrick, it seems the patch is ready in the commit
1b243b7b8356a27b0c7872cd20649ac29147d282, right? maybe we should change the
status.
That commit was about something else (adding Server.ConfigChanged signal, bug
#3558). Are you sure it solves the problem described here?
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
5:47 p.m.
New subject: [MeeGo Projects - Bug 5819] syncevo-dbus-server: does not honor disabling of autosync
http://bugs.meego.com/show_bug.cgi?id=5819
--- Comment #4 from yongsheng <yongsheng.zhu(a)intel.com> 2010-12-06 00:47:30 PST ---
(In reply to comment #3)
(In reply to comment #2)
> Patrick, it seems the patch is ready in the commit
> 1b243b7b8356a27b0c7872cd20649ac29147d282, right? maybe we should change the
> status.
That commit was about something else (adding Server.ConfigChanged signal, bug
#3558). Are you sure it solves the problem described here?
I'll have a test
for this.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
7:29 p.m.
New subject: [MeeGo Projects - Bug 5819] syncevo-dbus-server: does not honor disabling of autosync
http://bugs.meego.com/show_bug.cgi?id=5819
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|1.1 |1.1.1
--- Comment #5 from pohly <patrick.ohly(a)intel.com> 2010-12-15 02:29:10 PST ---
Ping?
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
9:30 p.m.
New subject: [MeeGo Projects - Bug 5819] syncevo-dbus-server: does not honor disabling of autosync
http://bugs.meego.com/show_bug.cgi?id=5819
yongsheng <yongsheng.zhu(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #6 from yongsheng <yongsheng.zhu(a)intel.com> 2010-12-30 04:30:24 PST ---
(In reply to comment #5)
Ping?
Patrick, I verified that this issue was resolved and the patch is
1b243b7b8356a27b0c7872cd20649ac29147d282.
below is extracted from your patch commit message:
This patch introduces a Server.ConfigChanged signal which is at the
end of a session if and only if it modified (removed, updated, added)
a config. This includes the Session.SetConfig() as well as command
line operations executed inside the server.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
10:24 p.m.
New subject: [MeeGo Projects - Bug 5819] syncevo-dbus-server: does not honor disabling of autosync
http://bugs.meego.com/show_bug.cgi?id=5819
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
--- Comment #7 from pohly <patrick.ohly(a)intel.com> 2010-12-30 05:24:47 PST ---
(In reply to comment #6)
(In reply to comment #5)
> Ping?
Patrick, I verified that this issue was resolved and the patch is
1b243b7b8356a27b0c7872cd20649ac29147d282.
below is extracted from your patch commit message:
This patch introduces a Server.ConfigChanged signal which is at the
end of a session if and only if it modified (removed, updated, added)
a config. This includes the Session.SetConfig() as well as command
line operations executed inside the server.
Can you explain to me why you think that this patch fixes the problem?
I can still reproduce the problem that I describe. Reopening.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
10:35 a.m.
New subject: [MeeGo Projects - Bug 5819] syncevo-dbus-server: does not honor disabling of autosync
http://bugs.meego.com/show_bug.cgi?id=5819
--- Comment #8 from yongsheng <yongsheng.zhu(a)intel.com> 2010-12-30 17:35:45 PST ---
(In reply to comment #7)
(In reply to comment #6)
> (In reply to comment #5)
> > Ping?
>
> Patrick, I verified that this issue was resolved and the patch is
> 1b243b7b8356a27b0c7872cd20649ac29147d282.
> below is extracted from your patch commit message:
> This patch introduces a Server.ConfigChanged signal which is at the
> end of a session if and only if it modified (removed, updated, added)
> a config. This includes the Session.SetConfig() as well as command
> line operations executed inside the server.
Can you explain to me why you think that this patch fixes the problem?
I can still reproduce the problem that I describe. Reopening.
I use
'master' code to test. Here are my steps:
1) I create a profile 'goo' with 'autoSync=1' and
'autoSyncInterval=1M'
2) start 'syncevo-dbus-server -d unlimited' and autosync will start
3) run 'syncevolution --configure --sync-property autoSync=0 goo' and observe
logs of syncevo-dbus-server for many minutes and no auto sync any more
4) run 'syncevolution --configure --sync-property autoSync=1 goo' and auto sync
will be start again
If one task has been put in the task list, then then setting autoSync=0 won't
disable it. But there is no future task added in the list. I think this is
current behavior.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
4:22 a.m.
New subject: [MeeGo Projects - Bug 5819] syncevo-dbus-server: does not honor disabling of autosync
http://bugs.meego.com/show_bug.cgi?id=5819
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|yongsheng.zhu(a)intel.com |patrick.ohly(a)intel.com
--- Comment #9 from pohly <patrick.ohly(a)intel.com> 2011-01-02 11:21:58 PST ---
(In reply to comment #8)
If one task has been put in the task list, then then setting
autoSync=0 won't
disable it. But there is no future task added in the list.
Perhaps this is what I was seeing. I'll check again.
I still don't get why you think that my patch fixes the original problem. Can
you explain this to me?
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
5:01 p.m.
New subject: [MeeGo Projects - Bug 5819] syncevo-dbus-server: does not honor disabling of autosync
http://bugs.meego.com/show_bug.cgi?id=5819
yongsheng <yongsheng.zhu(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |yongsheng.zhu(a)intel.com
--- Comment #10 from yongsheng <yongsheng.zhu(a)intel.com> 2011-01-03 00:01:44 PST
---
(In reply to comment #9)
(In reply to comment #8)
> If one task has been put in the task list, then then setting autoSync=0 won't
> disable it. But there is no future task added in the list.
Perhaps this is what I was seeing. I'll check again.
I still don't get why you think that my patch fixes the original problem. Can
you explain this to me?
1) The patch firstly checks whether the command line will
change the config(see
Cmdline.cpp)
2) It gets the result to show whether the command line changes the config(via
configWasModified) and set 'm_setConfig'
3) Once the current session is done, then it invokes auto sync manager to
remove the task related to the current config and re-load the changed config
and add the auto sync task if needed (see AutoSyncManager::update(const string&
configName).
The one thing I should explain is that if we set 'autosync=0' without via
dbus-server(i mean flushing them into files directly), then dbus-server won't
disable autosync for it doesn't track file changes, you know.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
5:17 p.m.
New subject: [MeeGo Projects - Bug 5819] syncevo-dbus-server: does not honor disabling of autosync
http://bugs.meego.com/show_bug.cgi?id=5819
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |FIXED
--- Comment #11 from pohly <patrick.ohly(a)intel.com> 2011-01-03 00:17:55 PST ---
(In reply to comment #10)
(In reply to comment #9)
> (In reply to comment #8)
> > If one task has been put in the task list, then then setting autoSync=0
won't
> > disable it. But there is no future task added in the list.
> Perhaps this is what I was seeing. I'll check again.
> I still don't get why you think that my patch fixes the original problem. Can
> you explain this to me?
1) The patch firstly checks whether the command line will change the config(see
Cmdline.cpp)
2) It gets the result to show whether the command line changes the config(via
configWasModified) and set 'm_setConfig'
3) Once the current session is done, then it invokes auto sync manager to
remove the task related to the current config and re-load the changed config
and add the auto sync task if needed (see AutoSyncManager::update(const string&
configName).
Are we talking about the same patch? 1b243b7b8356a27b0c7872cd20649ac29147d282
does not call AutoSyncManager::update().
After reviewing the code I now understand why 1b243b7b fixes this issue:
- AutoSyncManager::update() has been called if m_configSet was true for a
while.
- m_configSet was not set for command line sessions (causing this issue here).
- 1b243b7b fixes that by introducing m_setConfig =
m_cmdline->configWasModified()
That last change was motivated by the need to have ConfigChanged signals also
for command line session; I wasn't aware that I fixed some other issue as well
;-}
I can no longer reproduce the issue, so now I am okay with closing it.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
5:26 p.m.
New subject: [MeeGo Projects - Bug 5819] syncevo-dbus-server: does not honor disabling of autosync
http://bugs.meego.com/show_bug.cgi?id=5819
--- Comment #12 from yongsheng <yongsheng.zhu(a)intel.com> 2011-01-03 00:26:07 PST
---
That last change was motivated by the need to have ConfigChanged
signals also
for command line session; I wasn't aware that I fixed some other issue as well
;-}
I can no longer reproduce the issue, so now I am okay with closing it.
:) glad to
hear that.
"life is like a box of chocolate, you never know what you will get"
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
3709
days inactive
3840
days old
syncevolution-issues@syncevolution.org
12 comments
1 participants
participants (1)
-
bugzilla＠meego.com