12:15 a.m.
http://bugs.meego.com/show_bug.cgi?id=3566
Summary: sync-ui: need unique config name for phone configs
Classification: MeeGo Projects
Product: SyncEvolution
Version: unspecified
Platform: All
Architecture: ---
Status: ASSIGNED
Severity: normal
Priority: High
Component: GTK UI
AssignedTo: jku(a)linux.intel.com
ReportedBy: patrick.ohly(a)intel.com
QAContact: jingke.zhang(a)intel.com
CC: syncevolution-bugs(a)meego.bugs,
syncevolution-gtk-ui-bugs(a)meego.bugs
Estimated Hours: 0.0
"Moreover, since I keep updated two phones (E61 and 6220) with my Evolution,
sync-ui mixed up the two configurations and so I found some of the settings of
the 6220 in the E61 configuration, which made me upset. I turned back to the
shell script."
Jussi, do you check whether setting up a new phone overwrites an existing
config?
I fear we'll need an input field for the config name because naming a config
after some unrelated phone just because the template of that phone matches is
unintuitive. Or do we handle that via the PeerName property?
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
7:15 p.m.
New subject: [Bug 3566] sync-ui: need unique config name for phone configs
http://bugs.meego.com/show_bug.cgi?id=3566
--- Comment #1 from jku <jku(a)linux.intel.com> 2010-07-06 02:15:49 PDT ---
(In reply to comment #0)
Jussi, do you check whether setting up a new phone overwrites an
existing
config?
I fear we'll need an input field for the config name because naming a config
after some unrelated phone just because the template of that phone matches is
unintuitive. Or do we handle that via the PeerName property?
This turned out a bit more complicated than expected... Anyway, current status
is:
* device model name is used as configuration name
* no checking for overwrites is done
Both are problematic, the latter one is a bug that should have been fixed
already, somehow slipped through the cracks.
I've got a fix for both issues that seems to work, but it wasn't as simple as I
hoped. I'll test the configuration setups I can think of and push if it all
looks good.
There are still edge cases that are not fully working: If you manually setup
two different configurations for the same SyncURL only one will currently be
shown in the UI. This is a result of the device templates getting added after
the configuration UI code was in place... I have an idea how this should be
solved and I'll document that.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
9:20 p.m.
New subject: [Bug 3566] sync-ui: need unique config name for phone configs
http://bugs.meego.com/show_bug.cgi?id=3566
jku <jku(a)linux.intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #2 from jku <jku(a)linux.intel.com> 2010-07-13 04:20:45 PDT ---
jku branch has a commit that fixes this. As I said, the code is still more
complex than I hoped -- a rewrite of the configuration loading would do good,
but that is not appropriate for a bug fix release, I think.
So, when picking a name for a new device configuration:
* use deviceName as the base name
* add incremental postfix if a configuration already exists
The logic of combining different templates/configs into one graphical item is
still the same so I'm sure it's possible to create two configurations manually
so that only one is actually shown in the UI -- this is a bug but it should
only happen if you have several configurations for the same device url and it
should not end up with any configuration data loss.
Testing is appreciated as there are quite a few possible combinations here...
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
11:42 p.m.
New subject: [Bug 3566] sync-ui: need unique config name for phone configs
http://bugs.meego.com/show_bug.cgi?id=3566
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
Target Milestone|--- |1.1
--- Comment #3 from pohly <patrick.ohly(a)intel.com> 2010-07-13 06:42:00 PDT ---
I can confirm that it now uses the device name for the config. I created a
config for a device called "Nokia N97 mini" and got:
$ syncevolution -q --print-config "nokia n97 mini" | grep URL
syncURL = obex-bt://A0:4E:04:1E:AD:30
But the fix for not overwriting configs does not work for me. Steps to
reproduce:
1. pair a phone
2. create a config for that phone with sync-ui
3. quit sync-ui
4. modify the syncURL (I changed :30 into :31 for the N97)
5. start sync-ui again
6. change configs (shows "Nokia N97 mini" twice, once with settings,
once without - okay)
7. set up and use the one without settings, using the same template
(S60 in my case)
I ended up with only one config, which had the real :30 MAC address.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
12:03 a.m.
New subject: [Bug 3566] sync-ui: need unique config name for phone configs
http://bugs.meego.com/show_bug.cgi?id=3566
--- Comment #4 from jku <jku(a)linux.intel.com> 2010-07-16 07:03:31 PDT ---
After a few iterations, I think I've got a usable version in jku:
commit bf55c2b9dad72fd6f9db71e50842453a24c62801
Author: Jussi Kukkonen <jku(a)linux.intel.com>
Date: Fri Jul 16 10:25:27 2010 +0300
prevent overwriting device configs by accident (MBC #3566,1194)
Currently the configuration name for a new config is the
fingerPrint and it overwrites any existing configuration.
This commit starts using deviceName as the base name and adds a
incremental number to the end if a configuration already exists
for that name.
In more detail, the save session is started with the DeviceName as the config
name. Before saving, the code runs GetConfigs() and proceeds only if it gets
SYNCEVO_DBUS_ERROR_NO_SUCH_CONFIG. If there is no error (in other words the
config exists already), a new session is started with name "original_name__N"
where N is a increasing integer and the same happens again.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
12:06 a.m.
New subject: [Bug 3566] sync-ui: need unique config name for phone configs
http://bugs.meego.com/show_bug.cgi?id=3566
jku <jku(a)linux.intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |FIXED
--- Comment #5 from jku <jku(a)linux.intel.com> 2010-07-16 07:06:50 PDT ---
Whoops, too fast.
(In reply to comment #4)
After a few iterations, I think I've got a usable version in jku
Patrick, I think this is good to go but it is quite difficult to test with good
coverage... I'll mark it fixed, but would appreciate a sanity test.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
4447
days inactive
4465
days old
syncevolution-issues@syncevolution.org
5 comments
1 participants
participants (1)
-
bugzilla＠meego.com