1:11 a.m.
http://bugzilla.moblin.org/show_bug.cgi?id=5633
Summary: TEL TYPE HOME,CELL and HOME not understood by
Evolution
Classification: Moblin Projects
Product: SyncEvolution
Version: upstream
Platform: Netbook
OS/Version: Moblin Linux
Status: ASSIGNED
Severity: normal
Priority: P2
Component: SyncML
AssignedTo: syncevolution(a)lists.intel.com
ReportedBy: patrick.ohly(a)intel.com
QAContact: yanshuang.zheng(a)intel.com
CC: shuang.wan(a)intel.com, syncevolution(a)lists.intel.com
Release Milestone: Undecided
From the mailing list:
From: Dietmar Gottke <dietmar(a)gottke.com>
To: syncevolution(a)moblin.org <syncevolution(a)moblin.org>
Subject: [SyncEvolution] "Mobiltelefon" entry is empty after sync
Date: 08/25/2009 12:20:46 AM (Mon, 24 Aug 2009 23:20:46 +0100)
Hello,
first I have to thank very much the programmer of this very very useful tool. I
just switched to Deb Ubuntu 9.04 over from Windows and I'm very impressed what
I
have now on my desktop. In the moment I think I'll never switch back.
But back to syncevolution which serves me a small bug which results in
disappearing of the "Mobiltelefon" entry in the Evolution contacts view.
Evolution is version 2.26.1, syncevolution is version 0.9-2 and I use Genesis
0.4.1 too but the bug shows up also without Genesis. My Syncserver is Memotoo
and the configurated vcard format is vcard 2.1 I also tried vcard 3, but with
the same bug. What happens: I set up a completely empty contacts list. Then I
put in a test contact with all fields filled with records. I started
"syncevolution memotoo" and found all records in my Evolution contacts view,
except the "Mobiltelefon" entry. The field in the listview and cardview is
empty. But when I open the contact in the contacteditor then the "Mobiltelefon"
entry is filled correctly. Only switching back to the listview changes nothing,
but when I change the cellphone number in the contacteditor then the cellphone
number shows up afterwards in the listview. Doing a new sync will again make
the
"Mobiltelefon" entry empty.
Cause I'm a real novice concerning Linux and all this pretty good stuff I hope
that this list can help me solve the problem.
Best regards and again all thumbs up for this very good syncing tool.
From: Zheng, Yanshuang <yanshuang.zheng(a)intel.com>
To: Dietmar Gottke <dietmar(a)gottke.com>, Burton, Ross
<ross.burton(a)intel.com>
Cc: syncevolution(a)moblin.org <syncevolution(a)moblin.org>
Subject: Re: [SyncEvolution] "Mobiltelefon" entry is empty after sync
Date: 08/25/2009 07:24:44 AM (Tue, 25 Aug 2009 06:24:44 +0100)
I can reproduce it on Fedora10 with EDS 2.24.1 when syncing contacts with
Memotoo. Then more investigation is taken
1. testing with Memotoo on Fedora10:
Create a contact with “mobile phone” filled on memotoo and then make it sync-ed
to client. The contact is displayed in cardview and listview with “mobile
phone” empty. Check the data in EDS:
TEL;TYPE=HOME,VOICE:87654321
TEL;TYPE=HOME,CELL:123456789 ( seems that this one can’t be parsed on fedora
and ubuntu )
After editing it from Evolution/Contacts, the item in EDS becomes
TEL;X-EVOLUTION-UI-SLOT=2;TYPE=CELL:123456789-mod
TEL;X-EVOLUTION-UI-SLOT=1;TYPE=HOME,VOICE:87654321
Then we can view it filled in the listview and cardview.
2. testing with Memotoo on moblin with EDS 2.25.91:
We can view “mobile phone” without any edition.
3. testing with Scheduleworld on Fedora10 with EDS 2.24.1
Create a contact with “mobile phone” filled on scheduleworld and then make it
sync-ed to client. The contact is displayed in cardview and listview with
“mobile phone” filled. Check the data in EDS:
TEL;TYPE=HOME,VOICE:87654321
TEL;TYPE=CELL:123456789
After editing it from Evolution/Contacts, the item in EDS becomes
TEL;X-EVOLUTION-UI-SLOT=2;TYPE=CELL:123456789-mod
TEL;X-EVOLUTION-UI-SLOT=1;TYPE=HOME,VOICE:87654321
4. testing with Google on Fedora10 with EDS 2.24.1
Create a contact with “mobile phone” and “home phone” filled on google and then
make it sync-ed to client. The contact is displayed in cardview and listview
with “mobile phone” filled, but “home phone” empty. Check the data in EDS:
TEL;TYPE=CELL:123456789
TEL;TYPE=HOME:87654321( seems that this one can’t be parsed on fedora and
ubuntu )
After editing it from Evolution/Contacts, the item in EDS becomes
TEL;X-EVOLUTION-UI-SLOT=2;TYPE=CELL:123456789-mod
TEL;X-EVOLUTION-UI-SLOT=1;TYPE=HOME,VOICE:87654321
Testing on both OS are based on vcard3.0.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
1:11 a.m.
New subject: [Bug 5633] TEL TYPE HOME, CELL and HOME not understood by Evolution
http://bugzilla.moblin.org/show_bug.cgi?id=5633
--- Comment #1 from pohly <patrick.ohly(a)intel.com> 2009-08-25 08:11:48 ---
On Tue, 2009-08-25 at 06:24 +0100, Zheng, Yanshuang wrote:
I can reproduce it on Fedora10 with EDS 2.24.1 when syncing contacts
with
Memotoo. Then more investigation is taken
Thanks! Both the original report and this additional investigation were really
helpful. If we don't have a "fill in all fields in the web and sync to
Evolution" test case in the QA plan, then adding it would be very useful to
catch cases like this.
Now, the problem obviously is that Evolution doesn't handle some TYPE
combinations. They can be stored, but the list view doesn't recognize them.
There must be some other code path in the contact editor because editing the
contact fixes the TYPE.
We should apply the same fix in a incoming script for contacts *if* we
synchronize with Evolution contacts:
TEL;TYPE=[HOME|WORK],CELL => TEL;TYPE=CELL
TEL;TYPE=[HOME|WORK] => TEL;TYPE=[HOME|WORK],VOICE
In other words, strip the distinction between home and work cell phone
(WORK,CELL wasn't mentioned in the bug report, but I expect it to suffer from
the same problem) and add VOICE if only HOME or WORK are set. The former looses
some information, whereas the latter should be safe.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
1:28 a.m.
New subject: [Bug 5633] TEL TYPE HOME, CELL and HOME not understood by Evolution
http://bugzilla.moblin.org/show_bug.cgi?id=5633
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |5635
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
7:45 p.m.
New subject: [Bug 5633] TEL TYPE HOME, CELL and HOME not understood by Evolution
http://bugzilla.moblin.org/show_bug.cgi?id=5633
--- Comment #3 from pohly <patrick.ohly(a)intel.com> 2009-08-27 02:45:19 ---
(In reply to comment #2)
When I fill all mobile phone on Memotoo(including home, work and
other), I
found that Evolution prefers to parse in "Other Mobile Phone"(TEL;TYPE=CELL)
instead of "Home Mobile Phone"(TEL;TYPE=HOME,CELL) when displaying in cardview
or listview.
Evolution simply doesn't have a concept of different kinds of mobile phones. It
has to pick one of the available ones when displaying.
We can help Evolution make that choice by mapping all kinds of mobile phone
numbers to just TYPE=CELL. It can handle more than one of them. But clearly
that looses information.
The alternative is to fix Evolution, so that it displays TYPE=HOME,CELL *and*
preserves the HOME flag when editing. Not an easy job and won't help users of
older Evolution releases.
Thoughts?
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
3:36 p.m.
New subject: [Bug 5633] TEL TYPE HOME, CELL and HOME not understood by Evolution
http://bugzilla.moblin.org/show_bug.cgi?id=5633
--- Comment #4 from shuangeeer <yanshuang.zheng(a)intel.com> 2009-08-27 22:36:06 ---
(In reply to comment #3)
Evolution simply doesn't have a concept of different kinds of
mobile phones. It
has to pick one of the available ones when displaying.
Another try is that I create
a contact with only work mobile filled on memotoo
and then sync them to evolution. In card view and list view, the mobile phone
shows empty. Thus I guess Evolution only read "TEL;TYPE=CELL" as its
default/main mobile phone.
We can help Evolution make that choice by mapping all kinds of mobile
phone
numbers to just TYPE=CELL. It can handle more than one of them. But clearly
that looses information.
Indeed. If so, when we sync them back to the server, then
server will be
confused and may make mismatch.
For now, if we create a contact on Evolution with 3 mobile phones:
TEL;X-EVOLUTION-UI-SLOT=3;TYPE=CELL:work mobile
TEL;X-EVOLUTION-UI-SLOT=2;TYPE=CELL:other mobile
TEL;X-EVOLUTION-UI-SLOT=1;TYPE=CELL:home mobile
and then sync them to memotoo, we will get:
Home>>Mobile phone: work mobile
Work>>Mobile phone: other mobile
Other>>Mobile phone: home mobile
The alternative is to fix Evolution, so that it displays
TYPE=HOME,CELL *and*
preserves the HOME flag when editing. Not an easy job and won't help users of
older Evolution releases.
Based on above results, I prefer to reserver HOME and
WORK flag. If so, our
issue becomes "Which one is default/main mobile phone in your opinion, home,
work or other?" Evolution now chooses "Other". But actually, we commonly
own
just one and consider it as "Home" or "Personal".
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
4:59 p.m.
New subject: [Bug 5633] TEL TYPE HOME, CELL and HOME not understood by Evolution
http://bugzilla.moblin.org/show_bug.cgi?id=5633
--- Comment #5 from pohly <patrick.ohly(a)intel.com> 2009-08-27 23:59:53 ---
(In reply to comment #4)
> The alternative is to fix Evolution, so that it displays
TYPE=HOME,CELL *and*
> preserves the HOME flag when editing. Not an easy job and won't help users of
> older Evolution releases.
Based on above results, I prefer to reserver HOME and WORK flag.
reserver = preserve? Do I understand it correctly that you think that this
should be handled inside the Evolution GUI?
The problem is that a) this is an area where we don't have any experience
(making it hard to improve Evolution) and b) a solution won't become available
for at least a year and take even longer to reach users of normal distros.
What about this solution: for incoming contacts, if there is only one CELL,
strip the HOME or WORK flag from it. Evolution then should show it. Sending it
back to Memotoo will (randomly?) show it as home/work/other cell phone. That's
okay, because with just one cell phone the distinction is pretty useless.
If there are multiple CELLs, leave the flags because the creator of the contact
apparently cared about the distinction.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
5:20 p.m.
New subject: [Bug 5633] TEL TYPE HOME, CELL and HOME not understood by Evolution
http://bugzilla.moblin.org/show_bug.cgi?id=5633
--- Comment #6 from shuangeeer <yanshuang.zheng(a)intel.com> 2009-08-28 00:20:03 ---
(In reply to comment #5)
reserver = preserve? Do I understand it correctly that you think that
this
should be handled inside the Evolution GUI?
Sorry for typo :-)
Yes, I meant. But seems that it is hard for us to get it fixed soon.
The problem is that a) this is an area where we don't have any
experience
(making it hard to improve Evolution) and b) a solution won't become available
for at least a year and take even longer to reach users of normal distros.
What about this solution: for incoming contacts, if there is only one CELL,
strip the HOME or WORK flag from it. Evolution then should show it. Sending it
back to Memotoo will (randomly?) show it as home/work/other cell phone. That's
okay, because with just one cell phone the distinction is pretty useless.
If there are multiple CELLs, leave the flags because the creator of the contact
apparently cared about the distinction.
This sounds reasonable. But for contact with home cell and work cell at the
same time( no other cell phone) on memotoo, Evolution will show empty cell
phone in card/list view. I think nothing we can do to improve this now :-(
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
3:38 p.m.
New subject: [Bug 5633] TEL TYPE HOME, CELL and HOME not understood by Evolution
http://bugzilla.moblin.org/show_bug.cgi?id=5633
yongsheng zhu <yongsheng.zhu(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |yongsheng.zhu(a)intel.com
AssignedTo|syncevolution(a)lists.intel.c |yongsheng.zhu(a)intel.com
|om |
--- Comment #7 from yongsheng zhu <yongsheng.zhu(a)intel.com> 2009-08-28 22:38:28
---
assign to me. I'll fix this according to discussion.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
9:35 p.m.
New subject: [Bug 5633] TEL TYPE HOME, CELL and HOME not understood by Evolution
http://bugzilla.moblin.org/show_bug.cgi?id=5633
--- Comment #8 from yongsheng zhu <yongsheng.zhu(a)intel.com> 2009-08-29 04:35:25
---
fix is done.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
8:31 p.m.
New subject: [Bug 5633] TEL TYPE HOME, CELL and HOME not understood by Evolution
http://bugzilla.moblin.org/show_bug.cgi?id=5633
--- Comment #9 from pohly <patrick.ohly(a)intel.com> 2009-08-31 03:31:16 ---
(In reply to comment #8)
fix is done.
The fix is applied to all SyncEvolution backends, even if they don't have
Evolution's limitation. Can we configure this script so that it is only active
when encoding a vCard for Evolution? Without having thought much about it, an
outgoing script which which checks for remote rule "Evolution" might work.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
11:26 p.m.
New subject: [Bug 5633] TEL TYPE HOME, CELL and HOME not understood by Evolution
http://bugzilla.moblin.org/show_bug.cgi?id=5633
--- Comment #10 from yongsheng zhu <yongsheng.zhu(a)intel.com> 2009-08-31 06:25:59
---
(In reply to comment #9)
(In reply to comment #8)
> fix is done.
The fix is applied to all SyncEvolution backends, even if they don't have
Evolution's limitation. Can we configure this script so that it is only active
when encoding a vCard for Evolution? Without having thought much about it, an
outgoing script which which checks for remote rule "Evolution" might work.
You mean by checking remote rule 'evolution', we can decide whether to
strip
this information?
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
1:06 a.m.
New subject: [Bug 5633] TEL TYPE HOME, CELL and HOME not understood by Evolution
http://bugzilla.moblin.org/show_bug.cgi?id=5633
--- Comment #11 from pohly <patrick.ohly(a)intel.com> 2009-08-31 08:06:01 ---
(In reply to comment #10)
(In reply to comment #9)
> (In reply to comment #8)
> > fix is done.
>
> The fix is applied to all SyncEvolution backends, even if they don't have
> Evolution's limitation. Can we configure this script so that it is only active
> when encoding a vCard for Evolution? Without having thought much about it, an
> outgoing script which which checks for remote rule "Evolution" might
work.
You mean by checking remote rule 'evolution', we can decide whether to strip
this information?
Yes, but note that this will only be set inside the MAKETEXTWITHPROFILE macro
call that SyncSource.cpp adds to get the item converted for Evolution. I'm not
entirely sure whether that'll really work. Checking the MAKETEXTWITHPROFILE
implementation in sysync/scriptcontext.cpp func_MakeTextWithProfile I see that
no scripts are called.
This means we'll have to try something else. You could set
info.m_profile in the Evolution contact backend to something like this:
" <initscript><![CDATA[\n"
" string itemdata;\n"
" ]]></initscript>\n"
" <beforewritescript><![CDATA[\n"
" VCARD_INCOMING_SCRIPT_EVOLUTION;\n"
" itemdata = MAKETEXTWITHPROFILE(" << info.m_profile
<<
", \"EVOLUTION\");\n"
" ]]></beforewritescript>\n"
" <afterreadscript><![CDATA[\n"
" PARSETEXTWITHPROFILE(itemdata, " << info.m_profile
<<
", \"EVOLUTION\");\n"
" ]]></afterreadscript>\n"
" <map name='data' references='itemdata'
type='string'/>\n";
To avoid copying that whole string perhaps we should introduce an
info.m_incomingScipt and info.m_outgoingScript which are pasted into that text
if non-empty inside SyncSource.cpp?
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
4:40 p.m.
New subject: [Bug 5633] TEL TYPE HOME, CELL and HOME not understood by Evolution
http://bugzilla.moblin.org/show_bug.cgi?id=5633
--- Comment #12 from yongsheng zhu <yongsheng.zhu(a)intel.com> 2009-08-31 23:40:01
---
(In reply to comment #11)
(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #8)
> > > fix is done.
> >
> > The fix is applied to all SyncEvolution backends, even if they don't have
> > Evolution's limitation. Can we configure this script so that it is only
active
> > when encoding a vCard for Evolution? Without having thought much about it, an
> > outgoing script which which checks for remote rule "Evolution" might
work.
> You mean by checking remote rule 'evolution', we can decide whether to
strip
> this information?
Yes, but note that this will only be set inside the MAKETEXTWITHPROFILE macro
call that SyncSource.cpp adds to get the item converted for Evolution. I'm not
entirely sure whether that'll really work. Checking the MAKETEXTWITHPROFILE
implementation in sysync/scriptcontext.cpp func_MakeTextWithProfile I see that
no scripts are called.
This means we'll have to try something else. You could set
info.m_profile in the Evolution contact backend to something like this:
" <initscript><![CDATA[\n"
" string itemdata;\n"
" ]]></initscript>\n"
" <beforewritescript><![CDATA[\n"
" VCARD_INCOMING_SCRIPT_EVOLUTION;\n"
" itemdata = MAKETEXTWITHPROFILE(" <<
info.m_profile <<
", \"EVOLUTION\");\n"
" ]]></beforewritescript>\n"
" <afterreadscript><![CDATA[\n"
" PARSETEXTWITHPROFILE(itemdata, " <<
info.m_profile <<
", \"EVOLUTION\");\n"
" ]]></afterreadscript>\n"
" <map name='data' references='itemdata'
type='string'/>\n";
To avoid copying that whole string perhaps we should introduce an
info.m_incomingScipt and info.m_outgoingScript which are pasted into that text
if non-empty inside SyncSource.cpp?
The next solution makes sense. Could you help
review the fix for this issue?
The branch is 'origin/bug5633'.
Also info.m_outgoingScript is enabled. I have tested it. Also works.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
6:25 p.m.
New subject: [Bug 5633] TEL TYPE HOME, CELL and HOME not understood by Evolution
http://bugzilla.moblin.org/show_bug.cgi?id=5633
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #13 from pohly <patrick.ohly(a)intel.com> 2009-09-01 01:25:05 ---
(In reply to comment #12)
The next solution makes sense. Could you help review the fix for this
issue?
The branch is 'origin/bug5633'.
Also info.m_outgoingScript is enabled. I have tested it. Also works.
Merged. I changed the description of the new m_incoming/outgoingScript fields.
Repeating the variable name doesn't add much new information. At the very
least, use different words because that sometimes makes the meaning clearer. In
this case, there's quite a bit that can be said about these fields:
- /** name of incoming script */
+ /**
+ * One or more Synthesis script statements, separated
+ * and terminated with a semicolon. Can be left empty.
+ *
+ * If not empty, then these statements are executed directly
+ * before converting the current item fields into
+ * a single string with MAKETEXTWITHPROFILE() in the sync source's
+ * <beforewritescript> (see SyncSourceBase::getDatastoreXML()).
+ *
+ * This value is currently only used by sync sources which
+ * set m_profile.
+ */
std::string m_incomingScript;
- /** name of outgoing script */
+ /**
+ * Same as m_incomingScript, but used directly after
+ * converting a string into fields with PARSETEXTWITHPROFILE()
+ * in <afterreadscript>.
+ */
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
12:06 a.m.
New subject: [Bug 5633] TEL TYPE HOME, CELL and HOME not understood by Evolution
http://bugzilla.moblin.org/show_bug.cgi?id=5633
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |INTEGRATED
--- Comment #14 from pohly <patrick.ohly(a)intel.com> 2009-09-28 07:06:35 ---
Integrated into Moblin 2.1 in syncevolution-0.9.0.99.2.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
5:25 p.m.
New subject: [Bug 5633] TEL TYPE HOME, CELL and HOME not understood by Evolution
http://bugzilla.moblin.org/show_bug.cgi?id=5633
shuangeeer <yanshuang.zheng(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--- Comment #15 from shuangeeer <yanshuang.zheng(a)intel.com> 2009-09-30 00:25:28
---
Retest in 2.1 preview 20090929-001.img with syncevolution-0.9.0.99.2, all are
improved except this:
when i sync google contacts with "mobile" and "home phone"
filled(refresh-from-server), "home phone" on evolution-2.24.1-2(fc10) can't
show in list view and card view.
tracked this issue in bug #6501 and close this one.
--
Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
4736
days inactive
4772
days old
syncevolution-issues@syncevolution.org
15 comments
1 participants
participants (1)
-
bugzilla＠moblin.org