8:38 p.m.
https://bugs.freedesktop.org/show_bug.cgi?id=97780
Bug ID: 97780
Summary: Backends for the Trinity Desktop (TDE)
Product: SyncEvolution
Version: 1.5.1
Hardware: All
OS: Linux (All)
Status: NEW
Severity: normal
Priority: medium
Component: SyncEvolution
Assignee: syncevolution-issues(a)syncevolution.org
Reporter: deloptes(a)yahoo.com
CC: syncevolution-issues(a)syncevolution.org
Created attachment 126471
--> https://bugs.freedesktop.org/attachment.cgi?id=126471&action=edit
code for the two backends for the Trinity Desktop (TDE)
I attach here the code for the two backends for the Trinity Desktop (TDE).
1) tdepim - the PIM backend (addressbook, calendar/todo/journal and
notes/knotes)
2) tde - untested backend for the tdewallet.
Unfortunately I could not manage the ITEM_NEEDS_MERGE as discussed on the
mailing list, so the code performs an update as DEL+ADD in
calendar/todo/journal and notes/knotes and replace in addressbook.
Unfortunately (again) I don't have test cases, which is on the TODO for the
future.
Last but not least there is some useful information in the tdepim/README on
configuring, compiling and testing
thanks in advance
regards
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
7:32 a.m.
New subject: [Bug 97780] Backends for the Trinity Desktop (TDE)
https://bugs.freedesktop.org/show_bug.cgi?id=97780
--- Comment #1 from Patrick Ohly <patrick.ohly(a)gmx.de> ---
Regarding testing: you can re-use the existing tests and get them applied to
your new backend, using either the existing testcases or testcases specific to
your backend.
See how AkonadiSyncSourceRegister.cpp instantiates one custom
RegisterSyncSourceTest per item type:
static class vCard30Test : public RegisterSyncSourceTest {
public:
vCard30Test() : RegisterSyncSourceTest("kde_contact",
"eds_contact") {}
virtual void updateConfig(ClientTestConfig &config) const
{
config.m_type = "kde-contacts";
}
} vCard30Test;
This defines the "Client::Source::kde_contact" tests, using the existing
eds_contact = syncevolution/test/testcases/eds_contact.vcf testcases.
Build with integration testing enabled, dynamic linking disabled (easier that
way) and then you can run (without installation, directly in the "src"
directory:
./client-test Client::Source::kde_contact (or whatever you are going to call
it).
The HACKING document has some more information about this, although I can't
vouch for it being entirely up-to-date.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
7:24 p.m.
New subject: [Bug 97780] Backends for the Trinity Desktop (TDE)
https://bugs.freedesktop.org/show_bug.cgi?id=97780
--- Comment #2 from EKO <deloptes(a)yahoo.com> ---
Thanks for the hint - will do next.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
11:37 a.m.
New subject: [Bug 97780] Backends for the Trinity Desktop (TDE)
https://bugs.freedesktop.org/show_bug.cgi?id=97780
--- Comment #3 from Patrick Ohly <patrick.ohly(a)gmx.de> ---
Do you have more recent code or shall I add the code from 2016-09-12?
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
11:37 a.m.
New subject: [Bug 97780] Backends for the Trinity Desktop (TDE)
https://bugs.freedesktop.org/show_bug.cgi?id=97780
Patrick Ohly <patrick.ohly(a)gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|syncevolution-issues@syncev |patrick.ohly(a)gmx.de
|olution.org |
Status|NEW |ASSIGNED
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
12:02 p.m.
New subject: [Bug 97780] Backends for the Trinity Desktop (TDE)
https://bugs.freedesktop.org/show_bug.cgi?id=97780
EKO <deloptes(a)yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |deloptes(a)yahoo.com
--- Comment #4 from EKO <deloptes(a)yahoo.com> ---
Created attachment 126786
--> https://bugs.freedesktop.org/attachment.cgi?id=126786&action=edit
code for the two backends for the Trinity Desktop (TDE) >= 14.1
Thank you for asking. It is rather complicated.
The first patch (code) works with TDE as is at the moment.
However to make work with notes easier (get/set proper revision) I extended the
knotes interface and have a new code now.
Perhaps it would be better to add both
1. for TDE < 14.1
2. for TDE => 14.1
2. is definitely the desired/targeted version.
So either both or 2, should go in.
Thanks in advance
--
You are receiving this mail because:
You are on the CC list for the bug.
7:19 p.m.
New subject: [Bug 97780] Backends for the Trinity Desktop (TDE)
https://bugs.freedesktop.org/show_bug.cgi?id=97780
--- Comment #5 from Patrick Ohly <patrick.ohly(a)gmx.de> ---
I've imported both code drops, so now one can do a "git log -p" to see the
changes. It seems that the more recent code also improves the non-note support
(unit testing, more error checks).
See https://cgit.freedesktop.org/SyncEvolution/syncevolution/log/?h=tde
But now TDE >= 14.1 is required. If you want to support both, then you'll have
to add a configure version check and ifdefs to the code.
Please let me know how you want to proceed - it's your call, I don't know
enough about TDE to decide.
--
You are receiving this mail because:
You are on the CC list for the bug.
8:20 p.m.
New subject: [Bug 97780] Backends for the Trinity Desktop (TDE)
https://bugs.freedesktop.org/show_bug.cgi?id=97780
--- Comment #6 from EKO <deloptes(a)yahoo.com> ---
I want to focus on the latter version.
There were some changes pushed to TDE to fix UTF8 and also I extended the
knotes interface to handle revision(s) properly, so this is the primary and
final target.
If someone is interested to build the plugins for TDE <14.1 s/he can pull the
former version from the git repo.
I do not want to over-complicate things without a good reason and I really do
not see any in this case.
As you see I started working on the testing as you suggested but was not able
to advance that much. I do not expect this part to work.
Thank you Patrick for assisting in such a friendly way.
--
You are receiving this mail because:
You are on the CC list for the bug.
1:31 p.m.
New subject: [Bug 97780] Backends for the Trinity Desktop (TDE)
https://bugs.freedesktop.org/show_bug.cgi?id=97780
--- Comment #7 from Patrick Ohly <patrick.ohly(a)gmx.de> ---
When adding the "tde" branch to the automated testing, I ran into build issues.
I've fixed them for the "backend not enabled" case (see the latest commit
in
https://cgit.freedesktop.org/SyncEvolution/syncevolution/log/?h=for-maste...:
https://cgit.freedesktop.org/SyncEvolution/syncevolution/commit/?h=for-ma...
But I'm wondering whether the untested "backend enabled" case really worked.
To
me it seemed that some includes were missing. I've changed that.
EKO, can you test that branch and if further changes are needed, submit patches
here against it?
--
You are receiving this mail because:
You are on the CC list for the bug.
9:29 a.m.
New subject: [Bug 97780] Backends for the Trinity Desktop (TDE)
https://bugs.freedesktop.org/show_bug.cgi?id=97780
Patrick Ohly <patrick.ohly(a)gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #8 from Patrick Ohly <patrick.ohly(a)gmx.de> ---
The backends were merged into 1.5.2 already.
--
You are receiving this mail because:
You are on the CC list for the bug.
1392
days inactive
1870
days old
syncevolution-issues@syncevolution.org
9 comments
1 participants
participants (1)
-
bugzilla-daemon＠freedesktop.org