http://bugs.meego.com/show_bug.cgi?id=1007
--- Comment #9 from pohly <patrick.ohly(a)intel.com> 2010-05-26 08:31:06 PDT ---
(In reply to comment #7)
In vtimezone.cpp, valgrind issue is at line 431: dBias is not
initilised.
416 short dBias; // the full bias for DST
417 bool success = true;
418
419 t.name = "";
420 t.ident = "";
421 t.dynYear= "CUR";
422 t.biasDST= 0;
423 if (!GetTZInfo( aText,VTZ_STD, t.std, t.bias, aStdName, -1, aLogP )) {
424 success = false;
425 }
426 if (!GetTZInfo( aText,VTZ_DST, t.dst, dBias, aDstName, -1, aLogP )) {
427 dBias= t.bias;
428 success = false;
429 }
430
431 if (t.bias == dBias) ClrDST( t ); // no DST ?
This auto dBias never be set. I don't know the reason. It seems to me that the
logic here is strange. 'dBias' is set if and only if 426 is true.
No, GetTZInfo() gets dBias as reference and initializes it. It seems that you
have found a case where it returns "true" without initializing dBias. That case
needs to be fixed inside GetTZInfo(), it should return false if it cannot find
dBias.
--
Configure bugmail:
http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.