http://bugzilla.moblin.org/show_bug.cgi?id=3604 --- Comment #10 from pohly <patrick.ohly(a)intel.com&gt; 2009-09-03 07:51:17 --- * please remove Copyright (C) 2005-2009 Patrick Ohly <patrick.ohly(a)gmx.de&gt; from the new files * askPassword should not access the keyring unless told to do so. The reason is that this may trigger dialogs about unlocking the keyring or granting access, which is not desirable unless the user wanted that. * How does the code handle non-HTTP server passwords? I don't see any kind of check for that in the code. getServerUsers() seems to assume that it will invoked only for the "password" property in the main config.ini. That's not the case. Most likely you have to add more parameters to askPassword and savePassword to handle the other cases, because the "description" string doesn't help. * Don't add "extern" statements in .cpp files. That belongs into header files included by users and implementors of these items. * Why is the branch with 're-write the password value with a string "-"' commented out? This is necessary. * By putting CmdlineSyncClient.cpp into libsyncevolution, the core library still depends on the GNOME keyring libs. The code must go into the syncevolution binary. Use a virtual factory method to customize which class is created by the SyncEvolutionCmdline. * I don't understand why overriding the flush() method is necessary. -- Configure bugmail: http://bugzilla.moblin.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching someone on the CC list of the bug.