http://bugzilla.moblin.org/show_bug.cgi?id=9312
--- Comment #9 from Chen Congwu <congwu.chen(a)intel.com> 2010-03-03 18:06:47 PST
---
(In reply to comment #5)
(In reply to comment #4)
> Code pushed to san11 branch in SyncEvolution adn Libsynthesis, besides the
> MessageID problem (waiting for information from synthesis and affects the
> interoperability with opensync), please review and test with your phone if
> applicable.
The commit message for "syncevo-dbus-server: accept SAN 1.0/1.1 pacakge"
consists of only that line doesn't describe anything of the patch. This is
particularly important because you move around quite a bit of code, making it
harder to follow the patch. It depends on a modified libsynthesis, which needs
to be mentioned. How does it fail when libsynthesis is not updated?
If libsynthesis is not updated, a normal synchronization message from a client
will first be taken as a SAN package and will pass sliently, thus always
treating it as a server contacting us.
What's the bug number for it? This issue here was meant to cover
sending a SAN
1.0, not receiving it, although now that the code exists, we might as well
merge it.
No bug tracts it, however I think this bug can be extended to cover it.
Regarding SAN 1.1 - is there really such a version? I know that I was confused
about this at some point. If there is only SAN 1.0 (from SyncML 1.0) and SAN
1.2 (from SyncML 1.2), then we should never talk of 1.1.
I think there is, in OMA
DS Sync 1.0 and 1.1, the server alerted sync section,
both is introduced and even have slightly different descriptions about the
format of the message.
"SAN 1.0/1.1 generation support" - again, bug number
missing. Same comments as
above apply again (SAN 1.1?, dependency on libsynthesis)
faield => failed
Regarding "SANFormat": should we rename this to "SyncMLVersion"? When
acting as
server, it applies to the SAN message. When acting as client, it sets the
version of the standard used when talking to the server (see mailing list
discussion "Force SyncML 1.1 ?").
If you agree with this, please use the following description and also change
the "<client>" XML config creation accordingly so that it contains a
<defaultsyncmlversion> if the option is set. That way we don't have to detect
failures caused by unsupported SyncML versions.
Agree.
(In reply to comment #8)
The fallback from 1.2 to 1.1 (1.0?) doesn't work:
Agree. I reworked the patch in san11 branch, please review.
--
Configure bugmail:
http://bugzilla.moblin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.