5:23 a.m.
http://bugs.meego.com/show_bug.cgi?id=4027
Summary: contacts' PHOTOs are pushed with local file:// uris
Classification: MeeGo Projects
Product: SyncEvolution
Version: unspecified
Platform: All
Architecture: ---
Status: NEW
Severity: normal
Priority: Undecided
Component: Maemo 5
AssignedTo: ovek(a)debian.org
ReportedBy: Axel.Thimm(a)ATrpms.net
QAContact: jingke.zhang(a)intel.com
CC: syncevolution-bugs(a)meego.bugs,
syncevolution-maemo5-bugs(a)meego.bugs
Estimated Hours: 0.0
BUILD IMAGE(yyyy-mm-dd):PR1.2
HARDWARE MODEL (on what HW this bug is uncovered):N900
BUG DETAILED DESCRIPTIONS
===========================================================
syncevolution's transferred vcf files truncate the PHOTO attributes to a few
characters, example:
[...]
PHOTO;ENCODING=B:ZmlsZTovLy9ob21lL3VzZXIvLm9zc28tYWJvb2svcGhvdG9zLzRHMDJGVg
==
[...]
It turns out that this is the encoding of local file:// uris (as seen on the
n900 in the cached addressbook.before folders):
[...]
PHOTO;VALUE=uri:file:///home/user/.osso-abook/photos/5JA9FV
[...]
EXACT STEPS LEADING TO PROBLEM:
(Explain in detail what you do (e.g. tap on OK) and what you see (e.g. message
Connection Failed appears))
===========================================================
1.Set up a syncevolution server on http://some.ip:9000/syncevolution
2.Setup the service on the n900
3.run the gui or simply syncevolution --run server in a terminal
4.
5.
EXPECTED OUTCOME:
===================
The uploaded contacts should contain the embedded pictures.
ACTUAL OUTCOME:
===================
The uploaded contacts contain an encoded local uri path that doesn't resolve
outside the n900.
USER IMPACT:
===================
Broken avatars for contacts
REPRODUCIBILITY:
(always, less than 1/10, 5/10, 9/10)
=====================================
always
EXTRA SOFTWARE INSTALLED:
============================
I tested against stable and the latest 1.0 syncevolution in the repos.
OTHER COMMENTS:
===================
I mentioned setting up the server as I can see there what is really deposited.
The issue with the local uris is valid for all other services I tested it with
(by examining the addressbook.before folder, as I have no direct access to the
storage of myfunambol etc.). But I cannot rule out that this bug is
syncevolution http-server specific since some of my tries did actually get
pictures on these servers. OTOH I was also using export/import functionality to
get things going.
Exported vcf cards do properly embed the pictures.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
9:16 a.m.
New subject: [Bug 4027] contacts' PHOTOs are pushed with local file:// uris
http://bugs.meego.com/show_bug.cgi?id=4027
--- Comment #1 from ovek <ovek(a)debian.org> 2010-07-26 16:16:18 PDT ---
Hm. I think that might only be fixable by writing a Maemo-specific backend for
the addressbook (using Maemo-specific addressbook APIs), instead of using
syncevolution's standard Evolution backend. Writing such a backend might be a
fair bit of work...
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
6:20 p.m.
New subject: [Bug 4027] contacts' PHOTOs are pushed with local file:// uris
http://bugs.meego.com/show_bug.cgi?id=4027
--- Comment #2 from athimm <Axel.Thimm(a)ATrpms.net> 2010-07-27 01:20:51 PDT ---
I think the backend is fine, it extracts valid contacts, uris are part of the
vcard specification. In fact a non-local uri (say one pointing to a gravatar)
should indeed be just passed along.
The problem is that file:// uris are by definition only locally defined. I'm
also not sure this is a maemo specific issue, maybe other contact stores use
file:// uris as well. It does make sense to keep user data and avatars
separated, as avatars are changed frequently.
Anyway looking at the code (master) it probably needs to be fixed in
src/backends/addressbook/AddressBookSource.cpp in vCard2ABPerson::fromPerson:
if (photo) {
StringBuffer encoded;
b64_encode(encoded, (void *)CFDataGetBytePtr(photo),
CFDataGetLength(photo));
VProperty vprop("PHOTO");
vprop.addParameter("ENCODING", asVCard30 ? "B" :
"BASE64");
vprop.setValue(encoded.c_str());
m_vobj.addProperty(&vprop);
}
Before calling b64_encode one should compare photo to "file://" and if that
matches the referenced file should be opened and used instead. I don't have the
SDK set up otherwise I'd give it a try.
What I find strange is that no one reported this before. There seem to be quite
a few n900/syncevolution users out there. The syncing does work towards the
phone, maybe these users feed their PHOTOs from other sources?
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
7:18 p.m.
New subject: [Bug 4027] contacts' PHOTOs are pushed with local file:// uris
http://bugs.meego.com/show_bug.cgi?id=4027
--- Comment #3 from ovek <ovek(a)debian.org> 2010-07-27 02:18:26 PDT ---
Well, the osso-abook API has methods of retrieving a full vcard of a contact,
with the option of photo blob properly embedded. Perhaps it's better to use
osso-abook than to hack up the Evolution backend, in case more is needed.
What if you're syncing contacts with photos *to* the phone? Then, if using
osso-abook, it might want to split out the photo to a separate file again,
perhaps comparing with an existing file to avoid duplicates. But by bypassing
osso-abook and using ebook directly, the old URI field will probably be
overwritten with the actual photo data, and the database bloated with blobs and
duplicate blobs, and the old detached photo files unused and wasting space.
Handling something like that properly in the syncevolution backend would
probably take platform-specific code anyway, I'm guessing. And in that case,
the platform-specific backend may be cleaner anyway.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
3:46 a.m.
New subject: [Bug 4027] contacts' PHOTOs are pushed with local file:// uris
http://bugs.meego.com/show_bug.cgi?id=4027
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |patrick.ohly(a)intel.com
--- Comment #4 from pohly <patrick.ohly(a)intel.com> 2010-08-10 10:46:41 PDT ---
Sorry for not commenting earlier, I was on vacation and then did catch up with
everything.
I think an extension of the EvolutionContactSource.cpp
EvolutionContactSource::readItem() method (not Addressbook, that's the Mac OS X
backend) to handle this special case would be acceptable. An ifdef could be
used to enable it when compiling for Maemo.
That's for sending photos. For storing them outside of the main address book,
insertItem() needs to be modified.
I can imagine that deleting a contact also needs to delete the detached
contact, which would require changes to removeItem().
Perhaps it'll be easier after all to either write a completely new backend
based on osso-abook or replace libebook calls inside EvolutionContactSource.cpp
with osso-abook ones.
As always, patches are welcome (and required) to fix this issue.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
9:45 p.m.
New subject: [Bug 4027] contacts' PHOTOs are pushed with local file:// uris
http://bugs.meego.com/show_bug.cgi?id=4027
pohly <patrick.ohly(a)intel.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|Undecided |Medium
Status|NEW |ASSIGNED
--- Comment #5 from pohly <patrick.ohly(a)intel.com> 2010-08-24 04:45:38 PDT ---
Ove, given that this is currently only affecting the N900 port, I'll leave it
assigned to you. Please reassign to syncevolution-bugs(a)meego.bugs if you want
to put this bug up for adoption by some other developer.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
1:55 a.m.
New subject: [Bug 4027] contacts' PHOTOs are pushed with local file:// uris
http://bugs.meego.com/show_bug.cgi?id=4027
lciani <lciani(a)yahoo.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lciani(a)yahoo.it
--- Comment #6 from lciani <lciani(a)yahoo.it> 2010-08-24 08:55:55 PDT ---
I just wanted to tell you guys that I also noticed this bug and that I would be
very happy if it was resolved.
I'm not a software developer but I do own one N900.
Please let me know if I can be of help.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
12:37 p.m.
New subject: [MeeGo Projects - Bug 4027] contacts' PHOTOs are pushed with local file:// uris
http://bugs.meego.com/show_bug.cgi?id=4027
joergen <jorgen.scheibengruber(a)nokia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jorgen.scheibengruber@nokia
| |.com
--- Comment #7 from joergen <jorgen.scheibengruber(a)nokia.com> 2010-11-05 18:37:48
PDT ---
Maemo libebook has 2 extra APIs for this btw: e_contact_persist_data() and
e_contact_inline_data(), so fixing this should be just a matter of using those
on maemo + some ifdef.
The reason why we extract photos from the vcards is performance; since eds
represents contacts as vcards and transfers them like that between
client/server, it's a pretty bad idea to have huge amounts of base64 encoded
data in them.
I don't think it makes a lot of sense to write a different backend for maemo;
what libosso-abook adds is mostly irrelevant for synchronization (it's mostly
about integration with telepathy and UI stuff).
There is another difference though, that might make sense to add a ifdef for.
Maemo eds can actually convert the 3.0 vcards eds uses internally to 2.1 vcards
(i.e. it implements e_vcard_to_string_vcard_21()). That's quite important for
interoperability with a lot of phones.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
7:39 p.m.
New subject: [MeeGo Projects - Bug 4027] contacts' PHOTOs are pushed with local file:// uris
http://bugs.meego.com/show_bug.cgi?id=4027
--- Comment #8 from pohly <patrick.ohly(a)intel.com> 2010-11-08 00:39:23 PST ---
Thanks for the pointers.
(In reply to comment #7)
Maemo libebook has 2 extra APIs for this btw:
e_contact_persist_data() and
e_contact_inline_data(), so fixing this should be just a matter of using those
on maemo + some ifdef.
http://maemo.org/api_refs/5.0/5.0-final/libebook/EContact.html#e-contact-...
Which dir should SyncEvolution be using? /home/user/.osso-abook/photos?
Do you think you could come up with a patch?
There is another difference though, that might make sense to add a
ifdef for.
Maemo eds can actually convert the 3.0 vcards eds uses internally to 2.1 vcards
(i.e. it implements e_vcard_to_string_vcard_21()). That's quite important for
interoperability with a lot of phones.
This is something that the Synthesis engine does for SyncEvolution. But on the
N900, syncing with phones is done with the Nokia sync technology anyway, not
with SyncEvolution.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
6:24 a.m.
New subject: [MeeGo Projects - Bug 4027] contacts' PHOTOs are pushed with local file:// uris
http://bugs.meego.com/show_bug.cgi?id=4027
adi <adi(a)cg.tuwien.ac.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |adi(a)cg.tuwien.ac.at
--- Comment #9 from adi <adi(a)cg.tuwien.ac.at> 2010-11-19 11:24:46 PST ---
(In reply to comment #8)
This is something that the Synthesis engine does for SyncEvolution.
But on the
N900, syncing with phones is done with the Nokia sync technology anyway, not
with SyncEvolution.
I am sorry, I think I do not fully understand that: I am
using SyncEvolution on
the N900 to sync with Funambol into a SOGo backend.
SyncEvolution sends a base64 encoded photo to syncml server that actually
contains a "file://" uri pointing to the image file.
I have never tried syncing via bluetooth/USB to a SyncEvolution server on my
desktop using the Nokia sync stuff. And so does -- I think -- the original
poster as well (with the difference that he uses SyncEvolution at the other end
as well).
So I think this is not related to the evolution backend but is maemo specific?
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
6:37 a.m.
New subject: [MeeGo Projects - Bug 4027] contacts' PHOTOs are pushed with local file:// uris
http://bugs.meego.com/show_bug.cgi?id=4027
--- Comment #10 from pohly <patrick.ohly(a)intel.com> 2010-11-19 11:37:01 PST ---
(In reply to comment #9)
(In reply to comment #8)
> This is something that the Synthesis engine does for SyncEvolution. But on the
> N900, syncing with phones is done with the Nokia sync technology anyway, not
> with SyncEvolution.
I am sorry, I think I do not fully understand that: I am using SyncEvolution on
the N900 to sync with Funambol into a SOGo backend.
In that case, SyncEvolution is used. The comment you quoted is about using
something in the Nokia backend which SyncEvolution/Synthesis don't need.
SyncEvolution sends a base64 encoded photo to syncml server that
actually
contains a "file://" uri pointing to the image file.
That is something that needs to be changed in SyncEvolution.
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
6:45 a.m.
New subject: [MeeGo Projects - Bug 4027] contacts' PHOTOs are pushed with local file:// uris
http://bugs.meego.com/show_bug.cgi?id=4027
--- Comment #11 from adi <adi(a)cg.tuwien.ac.at> 2010-11-19 11:45:56 PST ---
(In reply to comment #10)
In that case, SyncEvolution is used. The comment you quoted is about
using
something in the Nokia backend which SyncEvolution/Synthesis don't need.
Thank
you for clearing this up! (And for being incredibly fast!) ;-)
--
Configure bugmail: http://bugs.meego.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching someone on the CC list of the bug.
4321
days inactive
4437
days old
syncevolution-issues@syncevolution.org
11 comments
1 participants
participants (1)
-
bugzilla＠meego.com